From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D58C433DF for ; Thu, 14 May 2020 10:31:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9672D2073E for ; Thu, 14 May 2020 10:31:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tnbyA16C"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UQTkLxLr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9672D2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YlDB2/kijdhvFH9Pff/fdIkH489qi6CPIbgsw0EskLY=; b=tnbyA16C90BM4W +5Hqfirr9668QUWo/W0o63/jy8zuVGEM2Wml+PGJA/ylQfgE44rvBp9LhKU0xtzS4CNC2mxY89fWo 1GTyq71+lnIWWNu+h2NW09KuUergdNp2uYk6uz8hcUkx2r7++wab08hF7nfNxge5oxCe4WfPZQJK0 +anuhviw8YDWVEWSH8v0afGgBAe6oZsXm3aLO36WfzzN8IvkYG7hhRYgkVzKwmwR8pnIaUObliLgL LiJms3Y9CuM8GONyzDArLqYdMuh84BVtlmlIjYRQPepxxYjnPiPLiClcBs1Mk6YUbQw6c3X8CNWTu je3Rdw5ICU49iLFPML7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZB8x-0004Ob-Sm; Thu, 14 May 2020 10:31:11 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZB8p-0004G3-ME; Thu, 14 May 2020 10:31:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vhtzypa8Bx13xatsh1CUSoTcvV4kyL0IlKzEm2ZdrM0=; b=UQTkLxLrAn5v3NF2X27Cum0Wpd axsYuIarPaZlpnLGO8WYxzK2/r+nrtp+IfLaZHxzUB+t5NWyOHg/WN/HMED2dg2XWjnJ7XdcbeeSD n/U0Z/GEabxrGOTNiGq98DLBZUwCb+TWTa5IojGhC2Vl8+WqBjaPAjxOSYuXJfeF7/ew5C2jExl7m +l0Nv4w+t/F+6uFTRAg4YYsXhTbSVo0mKkcpFNdGknsFt+oH8G0TNfaqVU64h/wWjdfWbw59ratjY z/2woS10lgbM8R7TkeurXorCK4Nu7Aj6bMru4zJLxYKbzSb6VogAtcyBO2EwbJxbJONdn/Z8ej4Ol LQqJYpUQ==; Received: from mga03.intel.com ([134.134.136.65]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZB8f-0002o4-7m; Thu, 14 May 2020 10:31:02 +0000 IronPort-SDR: IdAAql4/iiUWMpk7hV86vrHRGYjJtuFkWLoyyupNA9hfSj7ySEjnPn2PaF7GTha9QOuYZbGZOU Amcy94uY+9SQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2020 03:30:41 -0700 IronPort-SDR: r8Nk4+fFZDhHQX1Zr5aadLZd0qYhhg8PahPl/N9JBp9dR1cRkCMqrCW/Bju5Hl2/p1DmAMRMdf RXckwUinazsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,390,1583222400"; d="scan'208";a="464281101" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 14 May 2020 03:30:39 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jZB8U-006bX7-7k; Thu, 14 May 2020 13:30:42 +0300 Date: Thu, 14 May 2020 13:30:42 +0300 From: Andy Shevchenko To: Fengping Yu Subject: Re: [PATCH v7 2/3] drivers: input: keyboard: Add mtk keypad driver Message-ID: <20200514103042.GA185537@smile.fi.intel.com> References: <20200514061747.25466-1-fengping.yu@mediatek.com> <20200514061747.25466-3-fengping.yu@mediatek.com> <20200514102701.GZ185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200514102701.GZ185537@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_113053_730082_2CB72DD4 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , Marco Felsch , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Yingjoe Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, May 14, 2020 at 01:27:01PM +0300, Andy Shevchenko wrote: > On Thu, May 14, 2020 at 02:17:48PM +0800, Fengping Yu wrote: > > From: "fengping.yu" > > > > This adds matrix keypad support for Mediatek SoCs. > > ... > > > +config KEYBOARD_MTK_KPD > > + tristate "MediaTek Keypad Support" > > > + depends on OF && HAVE_CLK > > What makes it OF dependent? Actually you missed regmap dependencies or selection. I dunno which one should be used (IIRC selection). > > + help > > + Say Y here if you want to use the keypad on MediaTek SoCs. > > + If unsure, say N. > > + To compile this driver as a module, choose M here: the > > + module will be called mtk-kpd. -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek