From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC35C433E1 for ; Mon, 18 May 2020 17:49:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5840520715 for ; Mon, 18 May 2020 17:49:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RVAYUWow" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5840520715 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JHsS1vXIBesco24AwEFSToi7HRBfSqo2bS87DsK5BrU=; b=RVAYUWowFWtsUS c83rSBQGKbqj4e5Haupr0IU1yK4kq7evB2Lzly9gwNtZ3fdm9aXS638lfeEfm3kDB1gk+pg3vH0Ms NVzJDyoMbMKkg1WzvquCK85/6UYIaELsy6txXazopDG1VEnRluMSS4HOGtvI2zrKhKYorlSB2eyyh 8Z+4/oL9/V4MdBaQiDGMZkm1UhSqIX1+sScAobM3AP2t4YYLmwbmS7qkLohRG6FVxRMFloar+CvFV JFu4PTxcUN57TglBsg+9cJOLtXAt+uQAm7PoopWB62zTkZSeQMAd8dfZCCsL9FqdlCLW5lEDs+WHo YfpH9t8cmDrF1zY/9koQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jajt3-0000SH-Jv; Mon, 18 May 2020 17:49:13 +0000 Received: from asavdk4.altibox.net ([109.247.116.15]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jajsq-0000Et-Oz; Mon, 18 May 2020 17:49:02 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 4F54380512; Mon, 18 May 2020 19:48:49 +0200 (CEST) Date: Mon, 18 May 2020 19:48:47 +0200 From: Sam Ravnborg To: Enric Balletbo Serra Subject: Re: [PATCH v4 7/7] drm/mediatek: mtk_dsi: Create connector for bridges Message-ID: <20200518174847.GA770263@ravnborg.org> References: <20200501152335.1805790-1-enric.balletbo@collabora.com> <20200501152335.1805790-8-enric.balletbo@collabora.com> <53683f2d-23c7-57ab-2056-520c50795ffe@collabora.com> <37191700-5832-2931-5764-7f7fddd023b9@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=MOBOZvRl c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=33rsfa9LKxz_d3rkTGwA:9 a=mxk1C73UtW0IAQGh:21 a=CjuIK1q_8ugA:10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_104900_997711_36C62C1A X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Nicolas Boichat , Daniel Vetter , David Airlie , linux-kernel , dri-devel , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Laurent Pinchart , Philipp Zabel , Hsin-Yi Wang , Enric Balletbo i Serra , Collabora Kernel ML , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Enric/Chun-Kuang. > > > > My point is: when do you attach panel to a connector? > > In this patch, > > > > ret = drm_bridge_attach(&dsi->encoder, &dsi->bridge, NULL, > > DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > > > it would call into mtk_dsi_bridge_attach() with > > DRM_BRIDGE_ATTACH_NO_CONNECTOR, and call into panel_bridge_attach() > > with DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > My understanding is that the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is to > ease transition between the old and the new model. The drivers that > support the new model shall set that flag. Yes, right now we have fous on migrating all bridge drivers to the new model and next step is to make the transition for the display drivers one by one. Display drivers that uses the old model rely on the bridge driver to create the connector, whereas display drivers using the new model will create the connector themself. Display drivers following the new model will pass DRM_BRIDGE_ATTACH_NO_CONNECTOR to tell the bridge drive that no connector shall be created by the bridge driver. For this driver where only the new model is needed there is no reason to try to support both models. So the display driver shall always create the connector, and never ask the bridge driver to do it (always pass DRM_BRIDGE_ATTACH_NO_CONNECTOR). I hope this confirm and clarifies it. Sam _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek