From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CF2C433DF for ; Fri, 29 May 2020 19:25:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2291A20810 for ; Fri, 29 May 2020 19:25:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gCMTSM0D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2291A20810 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H0XNkiIzU0Oueow02/mL2fYejhgDfi60SRmFLcVHhOg=; b=gCMTSM0DLxY2tu 1SSuNqCgFjkooZ1+wppale4DrZ3xy2VyWCjkR8JBEDENNW4Dnv5w+T9gZRU/gmw4bIWBgkh2V1jzq LX6kqt16qn93aqk3ndNDVQiuLfjR4g+5UF0Ot1fPMY57Fg1QNbi8urbgm7HYw0UatAynr7nCs0SjP gRI1oqbfHEb7d7dJLKUOeLQiGLS+i9GiMl5EthkslwxLXWNtN4gNykdj1xxB7m0b89++Wkqz8HUxt VedEj+bT2Pm6Nl77UWEkqZmdRxDcssFFHXn09VCvzgtak2J4OPYoxKOficlveApAcOEMC80G2QGLG 31baFb8uCOY1HhqPIIGg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jekcr-00088B-50; Fri, 29 May 2020 19:25:05 +0000 Received: from mail-io1-f66.google.com ([209.85.166.66]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jekcb-0007it-FL; Fri, 29 May 2020 19:24:50 +0000 Received: by mail-io1-f66.google.com with SMTP id p20so506952iop.11; Fri, 29 May 2020 12:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ncA1UY1KFuVSo+dgrM2Ia9S54/5AbQa0Xrtk2pQ7Rpg=; b=T0xWl0Ws+mb6EMCNQqVN/JvQlfHg3cjQ1Vwq8sf63PrdcGy+ngsQnlIdmSLLrN2n1S rYj9KqcSUexY4QCzByTB0kVQMctSF+8Naog8MEXiK3wtbFkBC0wAdBvWOLPDFicMM4Pq tr99nNfLlXpZA9UqW8invIJB+PUO034rvCq0XFS7GhhVYZtczYYKzRXMioq2j2l+E9c+ qVHpNQBi6j0ZtdhTamoqsEmklG8QP9dTI1NzagmNekI2XHFSXyni9drdv0KVec9RT8qW upswftaAiNhTG5fRjSP0EXqMhwihsu+8N4t6m5C/4XKdltInAHNZMgEMQ6I3U+M8UcdO 44iw== X-Gm-Message-State: AOAM530f7nha8IdPNAruyX663GDDX7dnr+ThzMCibyJ+ohUts0xF8u6X ZtYYSn9MYItIstsXlArs4w== X-Google-Smtp-Source: ABdhPJwqvXK5Nh8UeEPtncN2XbompTf/OSEA4G54suYQIG3STlJL/YnP452nV6nfPe4nUqyJuC6XDw== X-Received: by 2002:a6b:e714:: with SMTP id b20mr8135145ioh.195.1590780287110; Fri, 29 May 2020 12:24:47 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id p3sm4241556iog.31.2020.05.29.12.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2020 12:24:45 -0700 (PDT) Received: (nullmailer pid 2795396 invoked by uid 1000); Fri, 29 May 2020 19:24:43 -0000 Date: Fri, 29 May 2020 13:24:43 -0600 From: Rob Herring To: EastL Subject: Re: [PATCH v4 1/4] dt-bindings: dmaengine: Add MediaTek Command-Queue DMA controller bindings Message-ID: <20200529192443.GA2785767@bogus> References: <1590659832-31476-1-git-send-email-EastL.Lee@mediatek.com> <1590659832-31476-2-git-send-email-EastL.Lee@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1590659832-31476-2-git-send-email-EastL.Lee@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_122449_512024_41627945 X-CRM114-Status: GOOD ( 17.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Sean Wang , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 05:57:09PM +0800, EastL wrote: > Document the devicetree bindings for MediaTek Command-Queue DMA controller > which could be found on MT6779 SoC or other similar Mediatek SoCs. > > Signed-off-by: EastL Need a full name. > --- > .../devicetree/bindings/dma/mtk-cqdma.yaml | 100 +++++++++++++++++++++ > 1 file changed, 100 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > > diff --git a/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > new file mode 100644 > index 0000000..045aa0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/mtk-cqdma.yaml > @@ -0,0 +1,100 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/mtk-cqdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Command-Queue DMA controller Device Tree Binding > + > +maintainers: > + - EastL > + > +description: > + MediaTek Command-Queue DMA controller (CQDMA) on Mediatek SoC > + is dedicated to memory-to-memory transfer through queue based > + descriptor management. > + Need a $ref to dma-controller.yaml > +properties: > + "#dma-cells": > + minimum: 1 > + # Should be enough > + maximum: 255 > + description: > + Used to provide DMA controller specific information. > + > + compatible: > + const: mediatek,cqdma Needs SoC specific compatible string(s). > + > + reg: > + minItems: 1 > + maxItems: 255 You can have 255 register regions? You need to define what each region is if more than 1. > + > + interrupts: > + minItems: 1 > + maxItems: 255 255 interrupts? > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: cqdma > + > + dma-channel-mask: > + description: > + Bitmask of available DMA channels in ascending order that are > + not reserved by firmware and are available to the > + kernel. i.e. first channel corresponds to LSB. > + The first item in the array is for channels 0-31, the second is for > + channels 32-63, etc. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32-array > + items: > + minItems: 1 > + # Should be enough > + maxItems: 255 This already has a definition in dma-common.yaml. Don't copy-n-paste it. Just add any constraints you have. Like what is the max number of channels? > + > + dma-channels: > + $ref: /schemas/types.yaml#definitions/uint32 > + description: > + Number of DMA channels supported by the controller. > + > + dma-requests: > + $ref: /schemas/types.yaml#definitions/uint32 > + description: > + Number of DMA request signals supported by the controller. Same comment on these 2. > + > +required: > + - "#dma-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - dma-channel-mask > + - dma-channels > + - dma-requests > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + cqdma: dma-controller@10212000 { > + compatible = "mediatek,cqdma"; > + reg = <0 0x10212000 0 0x80>, > + <0 0x10212080 0 0x80>, > + <0 0x10212100 0 0x80>; Examples default to 1 cell each for address and size. > + interrupts = , > + , > + ; > + clocks = <&infracfg_ao CLK_INFRA_CQ_DMA>; > + clock-names = "cqdma"; > + dma-channel-mask = <63>; > + dma-channels = <3>; > + dma-requests = <32>; > + #dma-cells = <1>; > + }; > + > +... > -- > 1.9.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek