linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac'
       [not found] <20200819072402.3085022-1-lee.jones@linaro.org>
@ 2020-08-19  7:23 ` Lee Jones
  2020-08-19 16:31   ` Jakub Kicinski
  2020-09-01  9:07   ` [15/28] " Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Lee Jones @ 2020-08-19  7:23 UTC (permalink / raw)
  To: kvalo, davem, kuba
  Cc: Felix Fietkau, Jakub Kicinski, netdev, linux-wireless,
	linux-kernel, linux-mediatek, Matthias Brugger, Lee Jones

Fixes the following W=1 kernel build warning(s):

 drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Function parameter or member 'dac' not described in 'mt7601u_set_tx_dac'
 drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Excess function parameter 'path' description in 'mt7601u_set_tx_dac'

Cc: Jakub Kicinski <kubakici@wp.pl>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/net/wireless/mediatek/mt7601u/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c
index d863ab4a66c96..3c4462487ab5c 100644
--- a/drivers/net/wireless/mediatek/mt7601u/phy.c
+++ b/drivers/net/wireless/mediatek/mt7601u/phy.c
@@ -1210,7 +1210,7 @@ void mt7601u_set_rx_path(struct mt7601u_dev *dev, u8 path)
 /**
  * mt7601u_set_tx_dac - set which tx DAC to use
  * @dev:	pointer to adapter structure
- * @path:	DAC index, values are 0-based
+ * @dac:	DAC index, values are 0-based
  */
 void mt7601u_set_tx_dac(struct mt7601u_dev *dev, u8 dac)
 {
-- 
2.25.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac'
  2020-08-19  7:23 ` [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac' Lee Jones
@ 2020-08-19 16:31   ` Jakub Kicinski
  2020-09-01  9:07   ` [15/28] " Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-08-19 16:31 UTC (permalink / raw)
  To: Lee Jones
  Cc: Felix Fietkau, Jakub Kicinski, netdev, linux-wireless,
	linux-kernel, linux-mediatek, Matthias Brugger, davem, kvalo

On Wed, 19 Aug 2020 08:23:49 +0100 Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Function parameter or member 'dac' not described in 'mt7601u_set_tx_dac'
>  drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Excess function parameter 'path' description in 'mt7601u_set_tx_dac'

Acked-by: Jakub Kicinski <kubakici@wp.pl>

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [15/28] mt7601u: phy: Fix misnaming when documented function parameter 'dac'
  2020-08-19  7:23 ` [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac' Lee Jones
  2020-08-19 16:31   ` Jakub Kicinski
@ 2020-09-01  9:07   ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2020-09-01  9:07 UTC (permalink / raw)
  To: Lee Jones
  Cc: Felix Fietkau, Jakub Kicinski, netdev, linux-wireless,
	linux-kernel, linux-mediatek, Matthias Brugger, kuba, Lee Jones,
	davem

Lee Jones <lee.jones@linaro.org> wrote:

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Function parameter or member 'dac' not described in 'mt7601u_set_tx_dac'
>  drivers/net/wireless/mediatek/mt7601u/phy.c:1216: warning: Excess function parameter 'path' description in 'mt7601u_set_tx_dac'
> 
> Cc: Jakub Kicinski <kubakici@wp.pl>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Felix Fietkau <nbd@openwrt.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>

10 patches applied to wireless-drivers-next.git, thanks.

e6cf87bfe869 mt7601u: phy: Fix misnaming when documented function parameter 'dac'
a8433a92521b rsi: Fix misnamed function parameter 'rx_pkt'
5dfcdc7a520e rsi: Fix a few kerneldoc misdemeanours
311175173c8a rsi: Fix a myriad of documentation issues
9463fd554bb8 rsi: File header comments should not be kernel-doc
7951a3bfa2b1 iwlegacy: 4965: Demote a bunch of nonconformant kernel-doc headers
2de64ca7c9fa brcmfmac: p2p: Deal with set but unused variables
457023556e94 libertas: Fix misnaming for function param 'device'
f030ed4079d0 libertas_tf: Fix function documentation formatting errors
ec511969097f hostap: Remove set but unused variable 'hostscan'

-- 
https://patchwork.kernel.org/patch/11723151/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-01  9:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20200819072402.3085022-1-lee.jones@linaro.org>
2020-08-19  7:23 ` [PATCH 15/28] wireless: mediatek: mt7601u: phy: Fix misnaming when documented function parameter 'dac' Lee Jones
2020-08-19 16:31   ` Jakub Kicinski
2020-09-01  9:07   ` [15/28] " Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).