From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDED2C43461 for ; Tue, 8 Sep 2020 22:26:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6F8C2067C for ; Tue, 8 Sep 2020 22:26:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gVPsiLq1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6F8C2067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gGc1T9ilsW5LoFY1t+bu3YuhfYYH0TsuScZDwD/0J/g=; b=gVPsiLq1OlQGFWjlPdAP/SikD R6JbyeJW9JdPCiJYne8XMcM/6oAdl2/MqbnT3DT+oKku0tKsb5V1fy8YCwhXmAatRm2ZRz2rCbfra ozNij2x7LxpkNUOHHfihYBIT1Ed/f0XSWVwbCtBnYDkd5PxwEYpMFe9jCLnNi6AuY3tBHXGkX+KYZ 7MUSjA3CaayvcdhE/Y4vYBhrqzlEX5+EWkfs8kAlSM2JMsxDojq/YpVvhtdVyyKGda1tvEOU/xo1A mx/O2CCqAB3N+sfUEfBP5q6nw0lDeup3OK77lwNPlsZ/jDLowzdOUMXgwiek3BE4JTQFzkxsN/y2I IA0bDmXYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFm3j-0003wg-KK; Tue, 08 Sep 2020 22:25:51 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFm3f-0003vu-OL; Tue, 08 Sep 2020 22:25:48 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CEECC1C0B87; Wed, 9 Sep 2020 00:25:45 +0200 (CEST) Date: Wed, 9 Sep 2020 00:25:44 +0200 From: Pavel Machek To: Gene Chen Subject: Re: [PATCH v3 1/2] leds: mt6360: Add LED driver for MT6360 Message-ID: <20200908222544.GF1005@bug> References: <1599474459-20853-1-git-send-email-gene.chen.richtek@gmail.com> <1599474459-20853-2-git-send-email-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1599474459-20853-2-git-send-email-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_182547_917096_BE792E8B X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, cy_huang@richtek.com, linux-kernel@vger.kernel.org, gene_chen@richtek.com, benjamin.chao@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, jacek.anaszewski@gmail.com, matthias.bgg@gmail.com, shufan_lee@richtek.com, Wilma.Wu@mediatek.com, linux-leds@vger.kernel.org, dmurphy@ti.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi! > From: Gene Chen > > Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, > and 4-channel RGB LED support Register/Flash/Breath Mode > > Signed-off-by: Gene Chen > --- > drivers/leds/Kconfig | 11 + > drivers/leds/Makefile | 1 + > drivers/leds/leds-mt6360.c | 681 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 693 insertions(+) > create mode 100644 drivers/leds/leds-mt6360.c > > + help > + This option enables support for dual Flash LED drivers found on > + Mediatek MT6360 PMIC. > + Independent current sources supply for each flash LED support torch and strobe mode. > + Includes Low-VF and short protection. > + 80 columns. And perhaps user does not need to know about protections... and actually about independend sources, either. "Enable this for RGB LED and flash LED support on..."? > +static int mt6360_torch_brightness_set(struct led_classdev *lcdev, enum led_brightness level) > +{ > + struct mt6360_led *led = container_of(lcdev, struct mt6360_led, flash.led_cdev); > + struct mt6360_priv *priv = led->priv; > + u32 enable_mask = MT6360_TORCHEN_MASK | MT6360_FLCSEN_MASK(led->led_no); > + u32 val = (level) ? MT6360_FLCSEN_MASK(led->led_no) : 0; > + u32 prev = priv->fled_torch_used, curr; > + int ret; > + > + dev_dbg(lcdev->dev, "[%d] brightness %d\n", led->led_no, level); > + if (priv->fled_strobe_used) { > + dev_warn(lcdev->dev, "Please disable strobe first [%d]\n", priv->fled_strobe_used); > + return -EINVAL; > + } So... how does its userland interface look like? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek