From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73623C43464 for ; Thu, 17 Sep 2020 20:12:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CBB42075B for ; Thu, 17 Sep 2020 20:12:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hDu6qIZQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="gXtNWWra" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CBB42075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f4p0xldY9XNDoFV1ZEEPQfZ80M71PJIaE58K4jEDmmc=; b=hDu6qIZQRJt8U9jFulY20W7EO x3YuchPlsQGu889fcbiTegrtt3Gc3n80g4gvw3YAO7nSjTHLin97IK0pAmWUWlVEf/jurMx07LooQ 7pbnNp9FMm+D2lSkC8Gtd6/FsJex07GxkuOo9fQuXR0kLDdKxBbXPMXVseVnoE3+5xJ0h4Go/43dX hqkjAyW3XmxDxxHyodcgLPTqIHsHn81slAIUFWo+SwbJjEutHm7/hvLkOTIrW7SEd99G3dZd7B/Gs eC0HQTgva8T7/4gYzuOOcCg3bEeMLc1bw//0grAs7P0WpR0Q3UeZOZUFUGJ7YUIdUbKrMTSi39E3M yOz4qfZWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ0Gk-0002Z8-68; Thu, 17 Sep 2020 20:12:38 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJ0Gi-0002Yf-5I; Thu, 17 Sep 2020 20:12:37 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7270FFD1; Thu, 17 Sep 2020 22:12:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600373554; bh=ImtDkhOM3E58XUZj9vjsNqp730R4NQ3rMHUu/Xaa14E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gXtNWWraWwEmJdkNh1LFbj1LUPr5Rh6c2/gqhc04TotlmCEVMe9driHUsSEp7s6IV v0lgY95h6Z5kaJoqD7Viq+KMIl50T/q4bx5UMjGwUaP1gbIrkc4dOJceRtJNIijJj8 rmxsypz7uhzzO3+03nbKH86AhoEVZASp7Sw6kvqs= Date: Thu, 17 Sep 2020 23:12:04 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Subject: Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers Message-ID: <20200917201204.GG3969@pendragon.ideasonboard.com> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-10-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200917165301.23100-10-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_161236_342660_1E04B5A0 X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amelie Delaunay , Geert Uytterhoeven , Matti Vaittinen , Linus Walleij , alsa-devel@alsa-project.org, Stefan Agner , Bjorn Andersson , Paul Cercueil , Masahiro Yamada , Chris Brandt , Srinivas Kandagatla , Manivannan Sadhasivam , linux-riscv@lists.infradead.org, Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Alexandre Torgue , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Anson Huang , Lee Jones , Takashi Iwai , Magnus Damm , Bartosz Golaszewski , Chen-Yu Tsai , Andy Gross , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , Andy Teng , Jacopo Mondi , Jaroslav Kysela , Sungbo Eo , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Cristian Ciocaltea , Charles Keepax , Maxime Coquelin , Ray Jui , Sascha Hauer , Sean Wang , Maxime Ripard , linux-gpio@vger.kernel.org, Richard Fitzgerald , Rob Herring , linux-mediatek@lists.infradead.org, Paul Walmsley , Matthias Brugger , Sricharan R , Mauro Carvalho Chehab , Hoan Tran , linux-arm-kernel@lists.infradead.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Scott Branden , linux-unisoc@lists.infradead.org, - , Chris Packham , Liam Girdwood , Serge Semin , linux-kernel@vger.kernel.org, Paul Kocialkowski , Yash Shah , Kieran Bingham , Palmer Dabbelt , Mark Brown , Pengutronix Kernel Team , linux-media@vger.kernel.org, Shawn Guo , Andreas =?utf-8?Q?F=C3=A4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thank you for the patch. On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote: > Include the common GPIO schema in GPIO controllers to be sure all common > properties are properly validated. Shouldn't we delete the properties that are now redundant from these schemas ? > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch > --- > .../devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml | 3 +++ > .../bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml | 1 + > .../devicetree/bindings/pinctrl/cirrus,lochnagar.yaml | 3 +++ > Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 3 +++ > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml | 3 +++ > .../devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml | 3 +++ > .../devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml | 3 +++ > 11 files changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > index 33391d30c00c..51bfc214bba6 100644 > --- a/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/actions,s500-pinctrl.yaml > @@ -15,6 +15,9 @@ description: | > GPIO function selection & GPIO attributes configuration. Please refer to > pinctrl-bindings.txt in this directory for common binding part and usage. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: actions,s500-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > index 7556be6e2754..55662f8d1f94 100644 > --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sun4i-a10-pinctrl.yaml > @@ -143,6 +143,7 @@ allOf: > # boards are defining it at the moment so it would generate a lot of > # warnings. > > + - $ref: /schemas/gpio/gpio-common.yaml# > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml > index 420d74856032..ed478b0ed4cc 100644 > --- a/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/cirrus,lochnagar.yaml > @@ -31,6 +31,9 @@ description: | > This binding must be part of the Lochnagar MFD binding: > [4] ../mfd/cirrus,lochnagar.yaml > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml > index 44c04d11ae4c..ffa64832b4f9 100644 > --- a/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml > @@ -59,6 +59,9 @@ properties: > patternProperties: > "^gpio@[0-9]$": > type: object > + allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > enum: > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > index 152c151c27ad..7d0a4cb96f39 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml > @@ -14,6 +14,9 @@ description: |+ > required property: > - compatible: "syscon" > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: mediatek,mt6779-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml > index 5556def6b99b..bc8bc0ac1926 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8192.yaml > @@ -12,6 +12,9 @@ maintainers: > description: | > The Mediatek's Pin controller is used to control SoC pins. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: mediatek,mt8192-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml > index c64c93206817..22a6b80b4c0e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,ipq6018-pinctrl.yaml > @@ -13,6 +13,9 @@ description: | > This binding describes the Top Level Mode Multiplexer block found in the > IPQ6018 platform. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: qcom,ipq6018-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > index 1f0f5757f9e1..9855d859fe61 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8226-pinctrl.yaml > @@ -13,6 +13,9 @@ description: | > This binding describes the Top Level Mode Multiplexer block found in the > MSM8226 platform. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: qcom,msm8226-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > index 8508c57522fd..e5757b6ced40 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8250-pinctrl.yaml > @@ -13,6 +13,9 @@ description: | > This binding describes the Top Level Mode Multiplexer block found in the > SM8250 platform. > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > compatible: > const: qcom,sm8250-pinctrl > diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml > index b7911a994f3a..4d7bf4340262 100644 > --- a/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rza2-pinctrl.yaml > @@ -10,6 +10,9 @@ maintainers: > - Chris Brandt > - Geert Uytterhoeven > > +allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > description: > The Renesas SoCs of the RZ/A2 series feature a combined Pin and GPIO > controller. > diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > index 72877544ca78..28b861362ba0 100644 > --- a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.yaml > @@ -56,6 +56,9 @@ properties: > patternProperties: > '^gpio@[0-9a-f]*$': > type: object > + allOf: > + - $ref: /schemas/gpio/gpio-common.yaml# > + > properties: > gpio-controller: true > '#gpio-cells': -- Regards, Laurent Pinchart _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek