From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B819C43463 for ; Fri, 18 Sep 2020 14:19:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE900208C3 for ; Fri, 18 Sep 2020 14:19:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yTWmK6LR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="E/Zvmkqb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE900208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HNXxZn/pa4cIYQX4st21DT7G+dkU31bNIMt6jEadNpo=; b=yTWmK6LRCrur8Ur2hb4chbR5s +3bbVr2cL9JGYHq008cISs3F8XMB1TFEOxwfJP338TbCURnrqPRXxXjvvXUw+EtPjQX/zcoW0j3+J ofB6w9LsDvHj4XdzVH0/EZIZ8kIuk/oY8Y0d67hhb+eapI/GtoKr4tD+T8Zmud+RNA3Z4IwZJ0pzE 1b3IiUWIsVM+gS81XoiIoXLPW3thTWK+oKY51M3Ub83HXwt89VMjn5KEUeEFcGt1PHnSUZg89ocDG +IrmPDE1kn/DfU9lrIR8Im9fPRvvekkK3B4nHSVLKOoXIiBTZA35iD1PX7Eg9mRPiQaCzUM+GKOLZ hAmnKNJzg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJHET-00012P-0j; Fri, 18 Sep 2020 14:19:25 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJHEQ-00011V-Ie; Fri, 18 Sep 2020 14:19:23 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EC382D7; Fri, 18 Sep 2020 16:19:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1600438758; bh=fIZGQZZYM2FyHIfA+1pya2D9PN88lhv1BbBbmjKpOQY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E/ZvmkqbpHcJAzSJWAcR9DD4mJds6aQ4ZFQLl81hgVUiAjz1lfibYnZHTp00xOuII mcjifMkOztY3aI9rZ53HCbQjoKLmJZelTc6VG1oDpdrdIMGDhNOqDxzZ/QnX7EXqLb tevVCNbQW2u28SmRYp6swCcNwEWZ9cVPc2mEccA8= Date: Fri, 18 Sep 2020 17:18:47 +0300 From: Laurent Pinchart To: Krzysztof Kozlowski Subject: Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers Message-ID: <20200918141847.GE28436@pendragon.ideasonboard.com> References: <20200917165301.23100-1-krzk@kernel.org> <20200917165301.23100-2-krzk@kernel.org> <20200917200936.GF3969@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_101922_750211_C1827E80 X-CRM114-Status: GOOD ( 21.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amelie Delaunay , Geert Uytterhoeven , Matti Vaittinen , Linus Walleij , alsa-devel@alsa-project.org, Stefan Agner , Bjorn Andersson , Paul Cercueil , Masahiro Yamada , Chris Brandt , Srinivas Kandagatla , Manivannan Sadhasivam , linux-riscv@lists.infradead.org, Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Alexandre Torgue , linux-renesas-soc@vger.kernel.org, Laurent Pinchart , Anson Huang , Lee Jones , Takashi Iwai , Magnus Damm , Bartosz Golaszewski , Chen-Yu Tsai , Andy Gross , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , Andy Teng , Jacopo Mondi , Jaroslav Kysela , Sungbo Eo , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Cristian Ciocaltea , Charles Keepax , Maxime Coquelin , Ray Jui , Sascha Hauer , Sean Wang , Maxime Ripard , linux-gpio@vger.kernel.org, Richard Fitzgerald , Rob Herring , linux-mediatek@lists.infradead.org, Paul Walmsley , Matthias Brugger , Sricharan R , Mauro Carvalho Chehab , Hoan Tran , linux-arm-kernel@lists.infradead.org, Niklas =?utf-8?Q?S=C3=B6derlund?= , Scott Branden , linux-unisoc@lists.infradead.org, - , Chris Packham , Liam Girdwood , Serge Semin , "linux-kernel@vger.kernel.org" , Paul Kocialkowski , Yash Shah , Kieran Bingham , Palmer Dabbelt , Mark Brown , Pengutronix Kernel Team , linux-media@vger.kernel.org, Shawn Guo , Andreas =?utf-8?Q?F=C3=A4rber?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Fri, Sep 18, 2020 at 09:52:57AM +0200, Krzysztof Kozlowski wrote: > On Thu, 17 Sep 2020 at 22:10, Laurent Pinchart wrote: > > On Thu, Sep 17, 2020 at 06:52:49PM +0200, Krzysztof Kozlowski wrote: > > > Convert parts of gpio.txt bindings into common dtschema file for GPIO > > > controllers. > > > > How about deleting the part that has been converted from gpio.txt ? > > I did not move everything from the gpio.txt and it is really nicely > explained there. I think to leave it as it works as a overview/guide > better than YAML. I'm just a bit worried that duplicating some of the information in two places will lead to them becoming out of sync, but maybe the risk isn't that high. > > > The schema enforces proper naming of GPIO controller nodes and GPIO > > > hogs. > > > > > > The schema should be included by specific GPIO controllers bindings. > > > > Instead of including it manually, could we use a conditional select: to > > apply the schema automatically when a gpio-controller property is > > present ? > > You mean the same way as generic schema for GPIO controllers work? > This could be done but the point is to enforce the GPIO controller > bindings in GPIO controllers, so also in cases when someone forgets to > add "gpio-controller" property. Although, if given GPIO controller > schema requires "gpio-controller" then indeed select would work... You could just make gpio-controller mandatory in the schema, and get everything else automatically selected based on that, without needing a manual $ref. -- Regards, Laurent Pinchart _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek