From: Mark Brown <broonie@kernel.org>
To: Fabien Parent <fparent@baylibre.com>
Cc: DTML <devicetree@vger.kernel.org>, Rob Herring <robh@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
lgirdwood@gmail.com, Rob Herring <robh+dt@kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392
Date: Mon, 26 Oct 2020 17:24:31 +0000 [thread overview]
Message-ID: <20201026172431.GI7402@sirena.org.uk> (raw)
In-Reply-To: <CAOwMV_w5N0_Qgg3MFph1147cbvFP1Y=mUtNjGbcr-Tca4ZJ3yA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 893 bytes --]
On Mon, Oct 26, 2020 at 06:18:35PM +0100, Fabien Parent wrote:
> On Mon, Oct 26, 2020 at 1:13 PM Mark Brown <broonie@kernel.org> wrote:
> > On Sat, Oct 24, 2020 at 10:03:03PM +0200, Fabien Parent wrote:
> > > +Required properties:
> > > +- compatible: "mediatek,mt6392-regulator"
> > This is no longer used by the driver, should be unneeded and therefore
> > should be removed.
> It is not used by the driver but it will be used by the MFD driver [0]
> like this:
> static const struct mfd_cell mt6392_devs[] = {
> {
> [snip]
> }, {
> [snip]
> }, {
> .name = "mt6392-regulator",
> .of_compatible = "mediatek,mt6392-regulator"
This is still unneeded, it's just a reflection of Linux implementation
details and should be removed. The MFD can just register the child
without supplying a compatible and things will continue to work just as
well.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-10-26 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 20:03 [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392 Fabien Parent
2020-10-24 20:03 ` [PATCH v5 2/2] regulator: mt6392: Add support for MT6392 regulator Fabien Parent
2020-10-26 12:13 ` [PATCH v5 1/2] dt-bindings: regulator: add support for MT6392 Mark Brown
2020-10-26 17:18 ` Fabien Parent
2020-10-26 17:24 ` Mark Brown [this message]
2020-10-26 18:38 ` Fabien Parent
2020-10-26 20:36 ` Mark Brown
2020-10-27 21:16 ` Fabien Parent
2020-10-28 12:32 ` Mark Brown
2020-10-28 13:14 ` Fabien Parent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026172431.GI7402@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox