Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

Pavel Machek
2020-11-18T21:37:36Z

[-- Attachment #1.1: Type: text/plain, Size: 1080 bytes --]

Hi!

> From: Gene Chen <gene_chen@richtek.com>
>
> Add LED_COLOR_ID_MOONLIGHT definitions

Why is moonlight a color? Camera flashes are usually white, no?

At least it needs a comment...

Best regards,
Pavel

> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> include/dt-bindings/leds/common.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 52b619d..1409e9a 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -33,7 +33,8 @@
> #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
> so this would include RGBW and similar */
> -#define LED_COLOR_ID_MAX 10
> +#define LED_COLOR_ID_MOONLIGHT 10
> +#define LED_COLOR_ID_MAX 11
>
> /* Standard LED functions */
> /* Keyboard LEDs, usually it would be input4::capslock etc. */

--
http://www.livejournal.com/~pavelmachek

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]