Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

Gene Chen
2020-11-19T02:20:42Z

Pavel Machek <pavel@ucw.cz> 於 2020年11月19日 週四 上午5:37寫道：
>
> Hi!
>
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add LED_COLOR_ID_MOONLIGHT definitions
>
> Why is moonlight a color? Camera flashes are usually white, no?
>
> At least it needs a comment...
>
> Best regards,
> Pavel
>

Moonlight has more current level(150mA) from general RGB LED (24mA).
It can be used as night-light and usually use color AMBER.
Camera flashes are usually use two flash LED. One is YELLOW, and one is WHITE.

>
>
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> > include/dt-bindings/leds/common.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> > index 52b619d..1409e9a 100644
> > --- a/include/dt-bindings/leds/common.h
> > +++ b/include/dt-bindings/leds/common.h
> > @@ -33,7 +33,8 @@
> > #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */
> > #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary color,
> > so this would include RGBW and similar */
> > -#define LED_COLOR_ID_MAX 10
> > +#define LED_COLOR_ID_MOONLIGHT 10
> > +#define LED_COLOR_ID_MAX 11
> >
> > /* Standard LED functions */
> > /* Keyboard LEDs, usually it would be input4::capslock etc. */
>
> --
> http://www.livejournal.com/~pavelmachek