* [PATCH 0/1] Mediatek pinctrl patch @ 2020-11-20 9:30 Zhiyong Tao 2020-11-20 9:30 ` [PATCH] pinctrl: fix low level output voltage issue Zhiyong Tao 0 siblings, 1 reply; 3+ messages in thread From: Zhiyong Tao @ 2020-11-20 9:30 UTC (permalink / raw) To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang Cc: devicetree, eddie.huang, srv_heupstream, linux-gpio, biao.huang, zhiyong.tao, erin.lo, hui.liu, seiya.wang, linux-kernel, hongzhou.yang, sj.huang, linux-mediatek, sean.wang, jg_poxu, linux-arm-kernel This series includes 1 patches: 1.fix low level output voltage issue. Zhiyong Tao (1): pinctrl: fix low level output voltage issue drivers/pinctrl/mediatek/pinctrl-paris.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] pinctrl: fix low level output voltage issue 2020-11-20 9:30 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao @ 2020-11-20 9:30 ` Zhiyong Tao 2020-12-04 8:43 ` Linus Walleij 0 siblings, 1 reply; 3+ messages in thread From: Zhiyong Tao @ 2020-11-20 9:30 UTC (permalink / raw) To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang Cc: devicetree, eddie.huang, srv_heupstream, linux-gpio, biao.huang, zhiyong.tao, erin.lo, hui.liu, seiya.wang, linux-kernel, hongzhou.yang, sj.huang, linux-mediatek, sean.wang, jg_poxu, linux-arm-kernel This patch is used to fix low level output voltage issue. A pin is changed from input pull-up to output high. The Dout value of the pin is default as 0. If we change the direction of the pin before the dout value of the pin, It maybe produce a low level output voltage between "input pull-up" and "output high". Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> --- drivers/pinctrl/mediatek/pinctrl-paris.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c index 623af4410b07..039ce9be19c5 100644 --- a/drivers/pinctrl/mediatek/pinctrl-paris.c +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c @@ -247,13 +247,13 @@ static int mtk_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin, err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_SR, !!arg); break; case PIN_CONFIG_OUTPUT: - err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DIR, - MTK_OUTPUT); + err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, + arg); if (err) goto err; - err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DO, - arg); + err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_DIR, + MTK_OUTPUT); break; case PIN_CONFIG_INPUT_SCHMITT: case PIN_CONFIG_INPUT_SCHMITT_ENABLE: -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: fix low level output voltage issue 2020-11-20 9:30 ` [PATCH] pinctrl: fix low level output voltage issue Zhiyong Tao @ 2020-12-04 8:43 ` Linus Walleij 0 siblings, 0 replies; 3+ messages in thread From: Linus Walleij @ 2020-12-04 8:43 UTC (permalink / raw) To: Zhiyong Tao Cc: Mark Rutland, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Sean Wang, srv_heupstream, open list:GPIO SUBSYSTEM, Biao Huang, Erin Lo, hui.liu, seiya.wang, linux-kernel@vger.kernel.org, Hongzhou Yang, sj.huang, Rob Herring, moderated list:ARM/Mediatek SoC support, Linux ARM, Sean Wang, Matthias Brugger, huang eddie, jg_poxu On Fri, Nov 20, 2020 at 10:31 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote: > This patch is used to fix low level output voltage issue. > A pin is changed from input pull-up to output high. > The Dout value of the pin is default as 0. > If we change the direction of the pin before the dout value of the pin, > It maybe produce a low level output voltage between "input pull-up" and > "output high". > > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com> Patch applied! Yours, Linus Walleij _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-04 8:44 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-20 9:30 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao 2020-11-20 9:30 ` [PATCH] pinctrl: fix low level output voltage issue Zhiyong Tao 2020-12-04 8:43 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).