From: Krzysztof Kozlowski <krzk@kernel.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: youlin.pei@mediatek.com, anan.sun@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, yi.kuo@mediatek.com,
Tomasz Figa <tfiga@google.com>,
iommu@lists.linux-foundation.org,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] memory: mtk-smi: Switch MTK_SMI to tristate
Date: Mon, 25 Jan 2021 09:44:50 +0100 [thread overview]
Message-ID: <20210125084450.wurwhi2hbbuueapy@kozik-lap> (raw)
In-Reply-To: <1611557384.3184.22.camel@mhfsdcap03>
On Mon, Jan 25, 2021 at 02:49:44PM +0800, Yong Wu wrote:
> On Fri, 2021-01-22 at 22:35 +0100, Krzysztof Kozlowski wrote:
> > On Thu, Jan 21, 2021 at 02:24:29PM +0800, Yong Wu wrote:
> > > This patch switches MTK_SMI to tristate. Support it could be 'm'.
> > >
> > > Meanwhile, Fix a build issue while MTK_SMI is built as module.
> >
> > s/Fix/fix.
> >
> > What error is being fixed here? How can I reproduce it? Aren't you just
> > adjusting it to being buildable by module?
>
> Sorry, I didn't copy the fail log here. This is the build log:
>
> In file included from .../drivers/iommu/mtk_iommu.c:34:0:
> .../drivers/iommu/mtk_iommu.h:84:28: error: array type has incomplete
> element type 'struct mtk_smi_larb_iommu'
> struct mtk_smi_larb_iommu larb_imu[MTK_LARB_NR_MAX];
>
> Our iommu driver will use this structure. but it was contained by
> "#ifdef CONFIG_MTK_SMI". thus I change it to "#if
> IS_ENABLED(CONFIG_MTK_SMI)"
>
> If reproducing it, we should change mtk-iommu to module_init[1]. and
> switch kconfig MTK_IOMMU to tristate, then change the CONFIG_MTK_IOMMU
> to m. we could get the fail log.
>
> In this case, Should I squash this change into this patch? I though this
> is a preparing patch and the fail is caused by MTK_SMI. thus I squash
> that into this patch. or change it as a independent patch and send when
> I change MTK_IOMMU to tristate?
If I understand correctly, there is no error before this patch. In such
case just don't mention the error to fix, because it is simply part of
making things modular.
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-01-25 8:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 6:24 Support MTK_SMI modular Yong Wu
2021-01-21 6:24 ` [PATCH 1/3] memory: mtk-smi: Use platform_register_drivers Yong Wu
2021-01-22 21:31 ` Krzysztof Kozlowski
2021-01-21 6:24 ` [PATCH 2/3] memory: mtk-smi: Add module_exit and module_license Yong Wu
2021-01-22 21:34 ` Krzysztof Kozlowski
2021-01-25 6:49 ` Yong Wu
2021-01-25 8:40 ` Krzysztof Kozlowski
2021-01-25 9:28 ` Yong Wu
2021-01-25 10:40 ` Krzysztof Kozlowski
2021-01-26 6:12 ` Yong Wu
2021-01-21 6:24 ` [PATCH 3/3] memory: mtk-smi: Switch MTK_SMI to tristate Yong Wu
2021-01-22 21:35 ` Krzysztof Kozlowski
2021-01-25 6:49 ` Yong Wu
2021-01-25 8:44 ` Krzysztof Kozlowski [this message]
2021-01-25 10:11 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210125084450.wurwhi2hbbuueapy@kozik-lap \
--to=krzk@kernel.org \
--cc=anan.sun@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox