From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
stable@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH] staging/mt7621-dma: mtk-hsdma.c->hsdma-mt7621.c
Date: Tue, 2 Feb 2021 09:54:38 +0300 [thread overview]
Message-ID: <20210202065438.GO2696@kadam> (raw)
In-Reply-To: <20210130034507.2115280-1-ilya.lipnitskiy@gmail.com>
On Fri, Jan 29, 2021 at 07:45:07PM -0800, Ilya Lipnitskiy wrote:
> Also use KBUILD_MODNAME for module name.
>
> This driver is only used by RALINK MIPS MT7621 SoCs. Tested by building
> against that target using OpenWrt with Linux 5.10.10.
>
> Fixes the following error:
> error: the following would cause module name conflict:
> drivers/dma/mediatek/mtk-hsdma.ko
> drivers/staging/mt7621-dma/mtk-hsdma.ko
>
The only part of this commit message that I could understand at all was
the parts which were copy and pasted from the build system... :/
Please, write it like this:
[PATCH] staging/mt7621-dma: fix build conflict
This driver cannot be built because we have two modules with the same
name and it leads to an error:
error: the following would cause module name conflict:
drivers/dma/mediatek/mtk-hsdma.ko
drivers/staging/mt7621-dma/mtk-hsdma.ko
The fix is to rename mtk-hsdma.c to hsdma-mt7621.c. Also we can use the
KBUILD_MODNAME where appropriate instead of hard coding the name.
regards,
dan carpenter
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-02-02 6:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 3:45 [PATCH] staging/mt7621-dma: mtk-hsdma.c->hsdma-mt7621.c Ilya Lipnitskiy
2021-02-02 6:54 ` Dan Carpenter [this message]
2021-02-02 8:31 ` Dan Carpenter
2021-02-02 11:09 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202065438.GO2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilya.lipnitskiy@gmail.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox