public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: linux-mediatek@lists.infradead.org,
	Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	Shayne Chen <shayne.chen@mediatek.com>,
	linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] mt76: use PCI_VENDOR_ID_MEDIATEK to avoid open coded
Date: Tue, 2 Feb 2021 15:25:36 +0100	[thread overview]
Message-ID: <20210202142536.GA4823@lore-desk> (raw)
In-Reply-To: <404c3c6be07d4c8b2a9a7297c387509b801e62a5.1612274129.git.ryder.lee@mediatek.com>


[-- Attachment #1.1: Type: text/plain, Size: 3587 bytes --]

> Use PCI standard defines.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> ---
>  drivers/net/wireless/mediatek/mt76/mt7603/pci.c | 2 +-
>  drivers/net/wireless/mediatek/mt76/mt7615/pci.c | 6 +++---
>  drivers/net/wireless/mediatek/mt76/mt76x0/pci.c | 6 +++---
>  drivers/net/wireless/mediatek/mt76/mt76x2/pci.c | 6 +++---
>  drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 +-
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/pci.c b/drivers/net/wireless/mediatek/mt76/mt7603/pci.c
> index 06fa28f645f2..aa6cb668b012 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7603/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7603/pci.c
> @@ -7,7 +7,7 @@
>  #include "mt7603.h"
>  
>  static const struct pci_device_id mt76pci_device_table[] = {
> -	{ PCI_DEVICE(0x14c3, 0x7603) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7603) },
>  	{ },
>  };
>  
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/pci.c b/drivers/net/wireless/mediatek/mt76/mt7615/pci.c
> index 71487f532f36..11f169cdd603 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/pci.c
> @@ -13,9 +13,9 @@
>  #include "mcu.h"
>  
>  static const struct pci_device_id mt7615_pci_device_table[] = {
> -	{ PCI_DEVICE(0x14c3, 0x7615) },
> -	{ PCI_DEVICE(0x14c3, 0x7663) },
> -	{ PCI_DEVICE(0x14c3, 0x7611) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7615) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7663) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7611) },
>  	{ },
>  };
>  
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> index 02d0aa0b815e..5847f943e8da 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/pci.c
> @@ -221,9 +221,9 @@ mt76x0e_remove(struct pci_dev *pdev)
>  }
>  
>  static const struct pci_device_id mt76x0e_device_table[] = {
> -	{ PCI_DEVICE(0x14c3, 0x7610) },
> -	{ PCI_DEVICE(0x14c3, 0x7630) },
> -	{ PCI_DEVICE(0x14c3, 0x7650) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7610) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7630) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7650) },
>  	{ },
>  };
>  
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> index ecaf85b483ac..adf288e50e21 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> @@ -10,9 +10,9 @@
>  #include "mt76x2.h"
>  
>  static const struct pci_device_id mt76x2e_device_table[] = {
> -	{ PCI_DEVICE(0x14c3, 0x7662) },
> -	{ PCI_DEVICE(0x14c3, 0x7612) },
> -	{ PCI_DEVICE(0x14c3, 0x7602) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7662) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7612) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7602) },
>  	{ },
>  };
>  
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> index 5570b4a50531..33ed952d7f4c 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> @@ -13,7 +13,7 @@
>  #include "../trace.h"
>  
>  static const struct pci_device_id mt7921_pci_device_table[] = {
> -	{ PCI_DEVICE(0x14c3, 0x7961) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x7961) },
>  	{ },
>  };
>  
> -- 
> 2.18.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

      reply	other threads:[~2021-02-02 14:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 13:57 [PATCH] mt76: use PCI_VENDOR_ID_MEDIATEK to avoid open coded Ryder Lee
2021-02-02 14:25 ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210202142536.GA4823@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=nbd@nbd.name \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox