From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA83BC433E0 for ; Fri, 26 Feb 2021 14:22:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8331064DA8 for ; Fri, 26 Feb 2021 14:22:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8331064DA8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dbp0iLxT6tYn9Mecta4fNRG20U3CGgu2P14KoTFM4Qc=; b=a8BTNmwkT2b62DWNeob/DES6r9 vFjHALhMdFYF+7/OC6VHBlMH76OT44ON7ImSovm6MT6BWj1zJtpyCodse9rVQY0ELaMgR0S3w245Q hpgbhPRmlJThpcn8vB4XfwNe9D7UL2xX/ryRINhDyh8zF+9C+E9S5jjDHvJrAsqMWiW58VrcHNm1I yQjR9UkFwu/FjZVP8eFjPS8Ko3Yj7ScsKjV/9Xzf42qttkXFL9gefmF7rHLDir8CXYMC+N0QW+NWH PNkD3p/Emfh1hdJg8rCPSCIfc8XuQPm2QoWUagTz09VYcDMHzUVfSt+MoXFxi+EbH0H7rplkKWV/U 9OrgTW0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFe0w-0007e1-65; Fri, 26 Feb 2021 14:22:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFe0r-0007cz-Nn; Fri, 26 Feb 2021 14:22:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1B93164DE3; Fri, 26 Feb 2021 14:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614349356; bh=IscUE33njMPiVfvfUyjcKdZCxN3HpR68Nvvh7cCbHws=; h=From:To:Cc:Subject:Date:From; b=BO8GncTN/3+5/nrOKmXhLN/kayMmjVF8zfxh3Tnyqbm4LTzd/h9Zq7q5NPYgKasJy 3akSDqpje6K0b49u3O9RX5bgUrdH1IsGxQHE3aNu0ZlT2+9dgjRS1cog550IGoUS/R oBI4b1lvqZapmKv3D6yk8sl+ghIdwsWuykj7Pbi5fbX6samUdH+CmonOiD5jgUk3Ae el5aMWCd1bNKWWggvQSyAz5hpvDxs1SB9rjgHFpbkDdgcyqdvsUhrQ7j1Gcj5qKcFo QbtQugKHAxsY8ozewjcp1qWrjTBycHXY9kW0L8jzk1fsYOOqXK+Wvf1HFQ7EwtmPp1 HLGTiU3rb1vUw== From: Arnd Bergmann To: Felix Fietkau , Lorenzo Bianconi , Kalle Valo Subject: [PATCH] [v2] mt76: mt7915: fix unused 'mode' variable Date: Fri, 26 Feb 2021 15:21:27 +0100 Message-Id: <20210226142215.3482168-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210226_092237_977378_2B21443C X-CRM114-Status: GOOD ( 12.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryder Lee , Arnd Bergmann , Nick Desaulniers , linux-kernel@vger.kernel.org, Nathan Chancellor , clang-built-linux@googlegroups.com, linux-mediatek@lists.infradead.org, Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann clang points out a possible corner case in the mt7915_tm_set_tx_cont() function if called with invalid arguments: drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable 'mode' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~~~~~ drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597:13: note: uninitialized use occurs here rateval = mode << 6 | rate_idx; ^~~~ drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:506:37: note: initialize the variable 'mode' to silence this warning u8 rate_idx = td->tx_rate_idx, mode; ^ Change it to return an error instead of continuing with invalid data here. Fixes: 3f0caa3cbf94 ("mt76: mt7915: add support for continuous tx in testmode") Signed-off-by: Arnd Bergmann --- v2: remove the extra 'break;' after return. --- drivers/net/wireless/mediatek/mt76/mt7915/testmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c index 7fb2170a9561..bd798df748ba 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/testmode.c @@ -543,7 +543,7 @@ mt7915_tm_set_tx_cont(struct mt7915_phy *phy, bool en) tx_cont->bw = CMD_CBW_20MHZ; break; default: - break; + return -EINVAL; } if (!en) { @@ -591,7 +591,7 @@ mt7915_tm_set_tx_cont(struct mt7915_phy *phy, bool en) mode = MT_PHY_TYPE_HE_MU; break; default: - break; + return -EINVAL; } rateval = mode << 6 | rate_idx; -- 2.29.2 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek