* [PATCH] MIPS: ralink: select WEAK_REORDERING_BEYOND_LLSC on MT7621
@ 2021-03-07 19:08 Ilya Lipnitskiy
2021-03-12 10:33 ` Thomas Bogendoerfer
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Lipnitskiy @ 2021-03-07 19:08 UTC (permalink / raw)
To: Thomas Bogendoerfer, John Crispin
Cc: Ilya Lipnitskiy, linux-mediatek, linux-mips, linux-kernel
Upstream a long-standing OpenWrt patch for RALINK MT7621 SoC. Selecting
WEAK_REORDERING_BEYOND_LLSC fixes random kernel hangs. This bug and fix
was reported by MediaTek WCN division [0].
[0]: https://lists.infradead.org/pipermail/lede-commits/2017-August/004537.html
Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: linux-mediatek@lists.infradead.org
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
arch/mips/ralink/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/ralink/Kconfig b/arch/mips/ralink/Kconfig
index c20c44788b62..31671bbf26ff 100644
--- a/arch/mips/ralink/Kconfig
+++ b/arch/mips/ralink/Kconfig
@@ -62,6 +62,7 @@ choice
select CLKSRC_MIPS_GIC
select HAVE_PCI if PCI_MT7621
select SOC_BUS
+ select WEAK_REORDERING_BEYOND_LLSC
endchoice
choice
--
2.30.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: select WEAK_REORDERING_BEYOND_LLSC on MT7621
2021-03-07 19:08 [PATCH] MIPS: ralink: select WEAK_REORDERING_BEYOND_LLSC on MT7621 Ilya Lipnitskiy
@ 2021-03-12 10:33 ` Thomas Bogendoerfer
2021-03-16 0:40 ` Ilya Lipnitskiy
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Bogendoerfer @ 2021-03-12 10:33 UTC (permalink / raw)
To: Ilya Lipnitskiy; +Cc: John Crispin, linux-mediatek, linux-mips, linux-kernel
On Sun, Mar 07, 2021 at 11:08:06AM -0800, Ilya Lipnitskiy wrote:
> Upstream a long-standing OpenWrt patch for RALINK MT7621 SoC. Selecting
> WEAK_REORDERING_BEYOND_LLSC fixes random kernel hangs. This bug and fix
> was reported by MediaTek WCN division [0].
>
> [0]: https://lists.infradead.org/pipermail/lede-commits/2017-August/004537.html
I don't see the Mediatek WCN reporting there. Looking at the 1004K user
manual I couldn't find a notice about such behaviour. So this looks
more like a fix for papering over the real bug by just introducing
a few more syncs. Could you please point me to where this is
really documented ?
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: ralink: select WEAK_REORDERING_BEYOND_LLSC on MT7621
2021-03-12 10:33 ` Thomas Bogendoerfer
@ 2021-03-16 0:40 ` Ilya Lipnitskiy
0 siblings, 0 replies; 3+ messages in thread
From: Ilya Lipnitskiy @ 2021-03-16 0:40 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: John Crispin, linux-mediatek, linux-mips,
Linux Kernel Mailing List
Hi Thomas,
On Fri, Mar 12, 2021 at 2:34 AM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Sun, Mar 07, 2021 at 11:08:06AM -0800, Ilya Lipnitskiy wrote:
> > Upstream a long-standing OpenWrt patch for RALINK MT7621 SoC. Selecting
> > WEAK_REORDERING_BEYOND_LLSC fixes random kernel hangs. This bug and fix
> > was reported by MediaTek WCN division [0].
> >
> > [0]: https://lists.infradead.org/pipermail/lede-commits/2017-August/004537.html
>
> I don't see the Mediatek WCN reporting there. Looking at the 1004K user
> manual I couldn't find a notice about such behaviour. So this looks
> more like a fix for papering over the real bug by just introducing
> a few more syncs. Could you please point me to where this is
> really documented ?
You may actually be right. After doing some testing we may not need
this change after all. Let me drop this patch for now. FYI, the
following commit may have fixed LL SC issues this change was covering
up: https://lore.kernel.org/lkml/20190613134933.048961704@infradead.org/
>
> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea. [ RFC1925, 2.3 ]
Ilya
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-16 0:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-07 19:08 [PATCH] MIPS: ralink: select WEAK_REORDERING_BEYOND_LLSC on MT7621 Ilya Lipnitskiy
2021-03-12 10:33 ` Thomas Bogendoerfer
2021-03-16 0:40 ` Ilya Lipnitskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).