From: Boris Lysov <arzamas-16@mail.ee>
To: matthias.bgg@gmail.com, linux@roeck-us.net, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [PATCH v3 0/3] watchdog: mtk_wdt: refactor code to support more watchdogs
Date: Thu, 13 May 2021 04:35:12 +0300 [thread overview]
Message-ID: <20210513013515.31329-1-arzamas-16@mail.ee> (raw)
This series aims to refactor existing mtk_wdt driver by making some
constants dependent on a particular SoC. It is done because some mtk
watchdogs, while working in same manner, have slightly different
parameters such as specific register unlock key value and an offset of a
particular register field.
This patch set adds support for mt6577 watchdog.
Accepting these patches will make ground for submitting additional
changes related to the mainline support of mt6577 (and other compatible
SoCs) in future.
Proposed patches successfully pass all `checkpatch.pl` checks and don't
yield compiler warnings.
Resulting code has been thoroughly tested multiple times for hours on
real hardware (mt6577, mt6589) to ensure that proposed changes are
working properly.
Changes since v2 [3]:
- rename the newly introduced structure element ('data' -> 'config') to
avoid changing the names of already existing variables; suggested [4]
by Guenter Roeck.
Changes since v1 [1]:
- a complete rewrite to get rid of the configuration flags which made
the watchdog not support other SoCs; suggested [2] by Guenter Roeck.
[1] https://lore.kernel.org/linux-mediatek/20210131234425.9773-1-arzamas-16@mail.ee/
[2] https://lore.kernel.org/linux-mediatek/050f2f8e-9c3c-10e3-05ef-cd84e949b98f@roeck-us.net/
[3] https://lore.kernel.org/linux-mediatek/20210509211702.549-1-arzamas-16@mail.ee/
[4] https://lore.kernel.org/linux-mediatek/efdce3a5-e5b4-19a8-35f1-8a536220bb3f@roeck-us.net/
Boris Lysov (3):
watchdog: mtk_wdt: Refactor code to support more SoCs
dt-bindings: watchdog: mediatek: add support for mt6577 SoC
watchdog: mtk_wdt: add support for mt6577
.../devicetree/bindings/watchdog/mtk-wdt.txt | 1 +
drivers/watchdog/mtk_wdt.c | 88 +++++++++++++++----
2 files changed, 70 insertions(+), 19 deletions(-)
--
2.20.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next reply other threads:[~2021-05-13 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 1:35 Boris Lysov [this message]
2021-05-13 1:35 ` [PATCH v3 1/3] watchdog: mtk_wdt: Refactor code to support more SoCs Boris Lysov
2021-05-13 15:22 ` Guenter Roeck
2021-05-13 1:35 ` [PATCH v3 2/3] dt-bindings: watchdog: mediatek: add support for mt6577 SoC Boris Lysov
2021-05-13 2:28 ` Rob Herring
2021-05-13 15:22 ` Guenter Roeck
2021-05-13 1:35 ` [PATCH v3 3/3] watchdog: mtk_wdt: add support for mt6577 Boris Lysov
2021-05-13 15:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513013515.31329-1-arzamas-16@mail.ee \
--to=arzamas-16@mail.ee \
--cc=devicetree@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox