public inbox for linux-mediatek@lists.infradead.org
 help / color / mirror / Atom feed
From: Rocco Yue <rocco.yue@mediatek.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	 <wsd_upstream@mediatek.com>, <rocco.yue@gmail.com>,
	Rocco Yue <rocco.yue@mediatek.com>
Subject: Re: [PATCH] ipv6: create ra_mtu proc file to only record mtu in RA
Date: Wed, 2 Jun 2021 11:15:02 +0800	[thread overview]
Message-ID: <20210602031502.31600-1-rocco.yue@mediatek.com> (raw)
In-Reply-To: <7087f518-f86e-58fb-6f32-a7cda77fb065@gmail.com>

On Tue, 2021-06-01 at 18:38 -0600, David Ahern wrote:
On 6/1/21 3:16 AM, Rocco Yue wrote:
> > For this patch set, if RA message carries the mtu option,
> > "proc/sys/net/ipv6/conf/<iface>/ra_mtu" will be updated to the
> > mtu value carried in the last RA message received, and ra_mtu
> > is an independent proc file, which is not affected by the update
> > of interface mtu value.
> 
> I am not a fan of more /proc/sys files.
> 
> You are adding it to devconf which is good. You can add another link
> attribute, e.g., IFLA_RA_MTU, and have it returned on link queries.
> 
> Make sure the attribute can not be sent in a NEWLINK or SETLINK request;
> it should be read-only for GETLINK.

Thanks for your review and advice.
Do you mean that I should keep the ra_mtu proc and add an another extra netlink msg?
Or only use netlink msg instead of ra_mtu proc?
I will do it.

Thanks,
Rocco
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2021-06-02  3:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01  9:16 [PATCH] ipv6: create ra_mtu proc file to only record mtu in RA Rocco Yue
2021-06-02  0:38 ` David Ahern
2021-06-02  3:15   ` Rocco Yue [this message]
2021-06-02  4:20     ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602031502.31600-1-rocco.yue@mediatek.com \
    --to=rocco.yue@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rocco.yue@gmail.com \
    --cc=wsd_upstream@mediatek.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox