From: <mark-yw.chen@mediatek.com>
To: <marcel@holtmann.org>, <johan.hedberg@gmail.com>
Cc: <tedd.an@linux.intel.com>, <chris.lu@mediatek.com>,
<will-cy.lee@mediatek.com>, <sean.wang@mediatek.com>,
<linux-bluetooth@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <michaelfsun@google.com>,
<shawnku@google.com>, <jemele@google.com>, <apusaka@google.com>,
<mcchou@chromium.org>, mark-yw.chen <mark-yw.chen@mediatek.com>
Subject: [PATCH 1/1] Bluetooth: btusb: Fix fall-through warnings
Date: Thu, 5 Aug 2021 10:40:12 +0800 [thread overview]
Message-ID: <20210805024012.18022-1-mark-yw.chen@mediatek.com> (raw)
From: "mark-yw.chen" <mark-yw.chen@mediatek.com>
Fix fall-through warnings:
drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
drivers/bluetooth/btusb.c:4033:3: warning:
this statement may fall through [-Wimplicit-fallthrough=]
4033 | usb_disable_autosuspend(data->udev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:4034:2: note: here
4034 | case 0x05ff: /* Firmware debug logging 1 */
| ^~~~
Signed-off-by: mark-yw.chen <mark-yw.chen@mediatek.com>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a4cee8327295..89ff9182b7e2 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -4027,7 +4027,9 @@ static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb)
* suspend and thus disable auto-suspend.
*/
usb_disable_autosuspend(data->udev);
+ fallthrough;
case 0x05ff: /* Firmware debug logging 1 */
+ fallthrough;
case 0x05fe: /* Firmware debug logging 2 */
return hci_recv_diag(hdev, skb);
}
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next reply other threads:[~2021-08-05 2:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 2:40 mark-yw.chen [this message]
2021-08-05 13:18 ` [PATCH 1/1] Bluetooth: btusb: Fix fall-through warnings Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2021-08-06 1:35 mark-yw.chen
2021-08-06 12:50 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805024012.18022-1-mark-yw.chen@mediatek.com \
--to=mark-yw.chen@mediatek.com \
--cc=apusaka@google.com \
--cc=chris.lu@mediatek.com \
--cc=jemele@google.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=michaelfsun@google.com \
--cc=sean.wang@mediatek.com \
--cc=shawnku@google.com \
--cc=tedd.an@linux.intel.com \
--cc=will-cy.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox