* [PATCH 0/1] Mediatek pinctrl patch
@ 2020-11-20 9:30 Zhiyong Tao
0 siblings, 0 replies; 6+ messages in thread
From: Zhiyong Tao @ 2020-11-20 9:30 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: devicetree, eddie.huang, srv_heupstream, linux-gpio, biao.huang,
zhiyong.tao, erin.lo, hui.liu, seiya.wang, linux-kernel,
hongzhou.yang, sj.huang, linux-mediatek, sean.wang, jg_poxu,
linux-arm-kernel
This series includes 1 patches:
1.fix low level output voltage issue.
Zhiyong Tao (1):
pinctrl: fix low level output voltage issue
drivers/pinctrl/mediatek/pinctrl-paris.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1] Mediatek pinctrl patch
@ 2021-03-12 6:35 Zhiyong Tao
0 siblings, 0 replies; 6+ messages in thread
From: Zhiyong Tao @ 2021-03-12 6:35 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, eddie.huang, jg_poxu,
biao.huang, hongzhou.yang, erin.lo, sean.wang, seiya.wang,
sj.huang, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek, linux-gpio
This series includes 1 patches:
1.add lock in mtk_rmw function.
Zhiyong Tao (1):
pinctrl: add lock in mtk_rmw function.
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 ++
drivers/pinctrl/mediatek/pinctrl-paris.c | 2 ++
3 files changed, 8 insertions(+)
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1] Mediatek pinctrl patch
@ 2021-11-04 1:40 Zhiyong Tao
2021-11-04 1:40 ` [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
0 siblings, 1 reply; 6+ messages in thread
From: Zhiyong Tao @ 2021-11-04 1:40 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio
This series includes 1 patches:
1. fix global-out-of-bounds issue.
Zhiyong Tao (1):
pinctrl: mediatek: fix global-out-of-bounds issue
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-04 1:40 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
@ 2021-11-04 1:40 ` Zhiyong Tao
2021-11-04 6:07 ` Sean Wang
0 siblings, 1 reply; 6+ messages in thread
From: Zhiyong Tao @ 2021-11-04 1:40 UTC (permalink / raw)
To: robh+dt, linus.walleij, mark.rutland, matthias.bgg, sean.wang
Cc: srv_heupstream, zhiyong.tao, hui.liu, light.hsieh, sean.wang,
seiya.wang, rex-bc.chen, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, linux-gpio, Guodong Liu
From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
When eint virtual eint number is greater than gpio number,
it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
---
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 45ebdeba985a..9d57c897835c 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -286,7 +286,8 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
*gpio_chip = &hw->chip;
/* Be greedy to guess first gpio_n is equal to eint_n */
- if (desc[eint_n].eint.eint_n == eint_n)
+ if (((*gpio_chip)->ngpio > eint_n) &&
+ desc[eint_n].eint.eint_n == eint_n)
*gpio_n = eint_n;
else
*gpio_n = mtk_xt_find_eint_num(hw, eint_n);
--
2.25.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-04 1:40 ` [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
@ 2021-11-04 6:07 ` Sean Wang
2021-11-04 8:25 ` zhiyong.tao
0 siblings, 1 reply; 6+ messages in thread
From: Sean Wang @ 2021-11-04 6:07 UTC (permalink / raw)
To: Zhiyong Tao
Cc: Rob Herring, Linus Walleij, Mark Rutland, Matthias Brugger,
srv_heupstream, hui.liu, Light Hsieh,
Sean Wang (王志亘), Seiya Wang, rex-bc.chen,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
linux-arm Mailing List, moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM, Guodong Liu
HI, Zhiyong
On Wed, Nov 3, 2021 at 6:40 PM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
>
> From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
>
> When eint virtual eint number is greater than gpio number,
> it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 45ebdeba985a..9d57c897835c 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -286,7 +286,8 @@ static int mtk_xt_get_gpio_n(void *data, unsigned long eint_n,
> *gpio_chip = &hw->chip;
>
> /* Be greedy to guess first gpio_n is equal to eint_n */
> - if (desc[eint_n].eint.eint_n == eint_n)
> + if (((*gpio_chip)->ngpio > eint_n) &&
please use "hw->soc->npins > eint_n" to perform the boundary check to
be consistent with the other places for the same purpose
> + desc[eint_n].eint.eint_n == eint_n)
> *gpio_n = eint_n;
> else
> *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> --
> 2.25.1
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue
2021-11-04 6:07 ` Sean Wang
@ 2021-11-04 8:25 ` zhiyong.tao
0 siblings, 0 replies; 6+ messages in thread
From: zhiyong.tao @ 2021-11-04 8:25 UTC (permalink / raw)
To: Sean Wang
Cc: Rob Herring, Linus Walleij, Mark Rutland, Matthias Brugger,
srv_heupstream, hui.liu, Light Hsieh,
Sean Wang (王志亘), Seiya Wang, rex-bc.chen,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
linux-arm Mailing List, moderated list:ARM/Mediatek SoC support,
open list:GPIO SUBSYSTEM, Guodong Liu
On Wed, 2021-11-03 at 23:07 -0700, Sean Wang wrote:
> HI, Zhiyong
>
> On Wed, Nov 3, 2021 at 6:40 PM Zhiyong Tao <zhiyong.tao@mediatek.com>
> wrote:
> >
> > From: Guodong Liu <guodong.liu@mediatek.corp-partner.google.com>
> >
> > When eint virtual eint number is greater than gpio number,
> > it maybe produce 'desc[eint_n]' size globle-out-of-bounds issue.
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > Signed-off-by: Guodong Liu <
> > guodong.liu@mediatek.corp-partner.google.com>
> > ---
> > drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > index 45ebdeba985a..9d57c897835c 100644
> > --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> > @@ -286,7 +286,8 @@ static int mtk_xt_get_gpio_n(void *data,
> > unsigned long eint_n,
> > *gpio_chip = &hw->chip;
> >
> > /* Be greedy to guess first gpio_n is equal to eint_n */
> > - if (desc[eint_n].eint.eint_n == eint_n)
> > + if (((*gpio_chip)->ngpio > eint_n) &&
>
> please use "hw->soc->npins > eint_n" to perform the boundary check to
> be consistent with the other places for the same purpose
Hi sean,
Thanks for your suggestion.
We will change it in next version(v1)
Thanks.
>
> > + desc[eint_n].eint.eint_n == eint_n)
> > *gpio_n = eint_n;
> > else
> > *gpio_n = mtk_xt_find_eint_num(hw, eint_n);
> > --
> > 2.25.1
> >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-04 8:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-04 1:40 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
2021-11-04 1:40 ` [PATCH] pinctrl: mediatek: fix global-out-of-bounds issue Zhiyong Tao
2021-11-04 6:07 ` Sean Wang
2021-11-04 8:25 ` zhiyong.tao
-- strict thread matches above, loose matches on Subject: below --
2021-03-12 6:35 [PATCH 0/1] Mediatek pinctrl patch Zhiyong Tao
2020-11-20 9:30 Zhiyong Tao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).