Re: [PATCH v9 02/22] dt-bindings: mediatek,dp: Add Display Port binding

Rob Herring
2022-03-28T16:33:37Z

On Mon, Mar 28, 2022 at 12:39:07AM +0200, Guillaume Ranquet wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This controller is present on several mediatek hardware. Currently
> mt8195 and mt8395 have this controller without a functional difference,
> so only one compatible field is added.
>
> The controller can have two forms, as a normal display port and as an
> embedded display port.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> ---
> .../display/mediatek/mediatek,dp.yaml | 100 ++++++++++++++++++
> 1 file changed, 100 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
> new file mode 100644
> index 000000000000..802cc406c72b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
> @@ -0,0 +1,100 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/mediatek/mediatek,dp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek Display Port Controller
> +
> +maintainers:
> + - CK Hu <ck.hu@mediatek.com>
> + - Jitao shi <jitao.shi@mediatek.com>
> +
> +description: |
> + Device tree bindings for the Mediatek (embedded) Display Port controller
> + present on some Mediatek SoCs.
> +
> +properties:
> + compatible:
> + items:
> + - const: mediatek,mt8195-dp-tx
> + - const: syscon

Add something to the above description to convince me this is a syscon.

If you need a regmap, the driver can create one. 'syscon' is really only
needed if there's not a specific driver.

Rob