Re: [RESEND v17 3/7] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

CK Hu
2022-04-07T05:58:50Z

Hi, Jason:

On Thu, 2022-04-07 at 11:04 +0800, jason-jh.lin wrote:
> 1. Add mt8195 mmsys compatible for vdosys0.
> 2. Add mt8195 routing table settings and fix build fail.
> 3. Add clock name, clock driver name and routing table into the
> driver data
> of mt8195 vdosys0.
> 4. Add get match data by clock name function and clock platform
> labels
> to identify which mmsys node is corresponding to vdosys0.
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
>

[snip]

>
> +static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data
> = {
> + .clk_name = "cfg_vdo0",
> + .clk_driver = "clk-mt8195-vdo0",
> + .routes = mmsys_mt8195_routing_table,
> + .num_routes = ARRAY_SIZE(mmsys_mt8195_routing_table),
> +};
> +
>

[snip]

>
> +static int mtk_mmsys_get_match_data_by_clk_name(const struct
> mtk_mmsys_driver_data **data,
> + struct device *dev)
> +{
> + int i;
> + struct clk *clk;
> + const char *clk_name;
> + const struct of_device_id *of_id =
> of_match_node(mtk_clk_platform_labels,
> + dev->of_node);
> + const struct mtk_mmsys_driver_data *drvdata[] = {
> + &mt8195_vdosys0_driver_data,
> + };
> +
> + if (!of_id || !of_id->data) {
> + dev_err(dev, "Can't find match clk platform labels\n");
> + return -EINVAL;
> + }
> +
> + clk = devm_clk_get(dev, NULL);
> + if (IS_ERR(clk)) {
> + dev_err(dev, "failed to get mmsys clk\n");
> + return PTR_ERR(clk);
> + }
> +
> + clk_name = __clk_get_name(clk);
> + if (!clk_name) {
> + dev_err(dev, "invalid mmsys clk name\n");
> + return -EINVAL;
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(drvdata); i++)
> + if (strncmp(drvdata[i]->clk_name, clk_name,
> strlen(clk_name)) == 0 &&

Why not

strcmp(drvdata[i]->clk_name, clk_name) == 0

Regards,
CK

> + strncmp(drvdata[i]->clk_driver, of_id->data,
> strlen(of_id->data)) == 0) {
> + *data = drvdata[i];
> + return 0;
> + }
> +
> + return -EINVAL;
> +}
> +