From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14F28C433EF for ; Fri, 29 Apr 2022 15:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=x8dkLsuP9E9TEmDgu2L/CKEY1YcZB7mpBo8baYi88p0=; b=CVq/vZeVG4hlY9wP3sPzROz7cw VyLX0bvFLLtaOsWONPn381rqUbRJmMnqf9fWOQd+7wh1+p1WKzf2ZCZcqvIr4lnJ527xKIXlehw4n bWuMlMRZxDms3cbYIae7i7GCgaOSpBvwtWOD0H6kcGh20ZSG0AFjyBfCZ/adiyp+f5w7PBLI2U3ma IIHUKtt4A4BkGl+rVChibvUmJrHWzoah/JFfb9U5a05lur0ERbP5twU2/kXIHBiSJEcXQub+bVELa eiumu247Y2bViOmiV/NPM+S+3Bhl/arhK2U2t/BoQ1rDjQjJ/qr4mu6lNl9aE6MuQhel5cqxCDvMm ldfVa+kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkSRx-00BksB-Dp; Fri, 29 Apr 2022 15:22:29 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkSRj-00BklP-RE for linux-mediatek@lists.infradead.org; Fri, 29 Apr 2022 15:22:18 +0000 Received: by mail-wr1-x42e.google.com with SMTP id x18so11281914wrc.0 for ; Fri, 29 Apr 2022 08:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BLvBmPgWkNIYBzQnMsLjrqJ6Q+Wo6mPOinOOp47QPLM=; b=ggJGd8qKt0ELuTvuMsbWNZtzSIw9cGxyNauKWCMmtHioFLC20Rc/OmS7a7krR8bwlh 06MV7aFOWcmY9ZSq18dLu7TDzMa+yDXAUB1N/0PYfmmdhQPzzRfProzG6hiP8eVix5oe Dyj5cDIG9yE45kT+TvfwqlprC1UXuyed54SQ47VfpKCakjesL943hVZK9hHKGVWcPj4F 9rHtNWzb6K2FNXItMTONP3YVZv31FwkqLwkBYps2pyh9quG0/oahmhTLwnywmBLtY/gK F9iF3XvdrY33ZOXBN/J5HJJL/kMB3lXLyqZ3SJNNH4/HbUOitp416cQt5ey7Fgc0k01u 88Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BLvBmPgWkNIYBzQnMsLjrqJ6Q+Wo6mPOinOOp47QPLM=; b=sz+TtdAKg9+QU8iDENAWbufI3KDFIFBNQ/EoLo9xHz4m+t+ZIKz+HMQOP/ZvuiSm2l K6CruhR0Q8Tq1jFaNkFNLQW07F3tzp52BBey+lanNd8tBmzIwPW3f1sde2aEOTa+yGjk cBjitEcK5NwwgrOOGOmTGLlKb6lrI0SHNyKvxH6UCIuZiAfkeXBSvoZGNnSgTuCSQaJL 3XZdKjMFbh1MmFbFS9a/nBn4B1tEpDhH+uIcjIOrMRvRwVj/FtWd/f0GlL4NwIK69/nM keSmVp5LIGHJmQ87XBpXaG9XNjg0JL4Q/Cvt9KAuQLjC3LybI5te3P94kkeBV+SV2CB+ 8lRg== X-Gm-Message-State: AOAM532GYcT9T2c8GjQ1fj0WChIoqAkqyKVqBYK33geFmw485O/GVM2/ r1gkepmHnBtHuqUciuMTlflGIg== X-Google-Smtp-Source: ABdhPJyxAaDV29Pk5q4lL8bvqoUXIkNNDFy+Jel6MnDtQTC/NHbbOczZsAk1AeP9vUrxlLUEo7TeZg== X-Received: by 2002:adf:f745:0:b0:20a:c43b:3dfe with SMTP id z5-20020adff745000000b0020ac43b3dfemr29754985wrp.117.1651245730494; Fri, 29 Apr 2022 08:22:10 -0700 (PDT) Received: from radium ([88.160.162.107]) by smtp.gmail.com with ESMTPSA id l6-20020a1c2506000000b0038e6fe8e8d8sm3579793wml.5.2022.04.29.08.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 08:22:09 -0700 (PDT) Date: Fri, 29 Apr 2022 17:22:03 +0200 From: Fabien Parent To: Matthias Brugger Cc: Macpaul Lin , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: dts: mediatek: mt8195-demo: enable ethernet Message-ID: <20220429152203.ppuimwcka5d6rvq4@radium> References: <20220426134106.242353-1-fparent@baylibre.com> <20220426134106.242353-6-fparent@baylibre.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220429_082215_936102_49755C36 X-CRM114-Status: GOOD ( 21.00 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3104810538259598611==" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --===============3104810538259598611== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lzoq53ieck3g4u4f" Content-Disposition: inline --lzoq53ieck3g4u4f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 29, 2022 at 04:00:32PM +0200, Matthias Brugger wrote: >=20 >=20 > On 27/04/2022 08:25, Macpaul Lin wrote: > > On Tue, 2022-04-26 at 15:41 +0200, Fabien Parent wrote: > > > Enable ethernet on the MT8195 demo board. > > >=20 > > > Signed-off-by: Fabien Parent > > > --- > > > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 108 > > > +++++++++++++++++++ > > > 1 file changed, 108 insertions(+) > > >=20 > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > > b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > > index 08cab3b3943b..0b7985486e2a 100644 > > > --- a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > > @@ -80,6 +80,30 @@ optee_reserved: optee@43200000 { > > > }; > > > }; > > > +ð { > > > + phy-mode =3D "rgmii-rxid"; > > > + phy-handle =3D <ð_phy>; > > > + snps,reset-gpio =3D <&pio 93 GPIO_ACTIVE_HIGH>; > > > + snps,reset-delays-us =3D <0 10000 10000>; > > > + mediatek,tx-delay-ps =3D <2030>; > > > + pinctrl-names =3D "default", "sleep"; > > > + pinctrl-0 =3D <ð_default_pins>; > > > + pinctrl-1 =3D <ð_sleep_pins>; > > > + status =3D "okay"; > > > + > > > + mdio { > > > + compatible =3D "snps,dwmac-mdio"; > > > + #address-cells =3D <1>; > > > + #size-cells =3D <0>; > > > + > > > + eth_phy: phy@1 { > > > + compatible =3D "ethernet-phy-id001c.c916"; > > > + #phy-cells =3D <0>; > > > + reg =3D <0x1>; > > > + }; > > > + }; > > > +}; > > > + > > > &i2c6 { > > > clock-frequency =3D <400000>; > > > pinctrl-0 =3D <&i2c6_pins>; > > > @@ -260,6 +284,90 @@ &mt6359_vsram_others_ldo_reg { > > > }; > > > &pio { > > > + eth_default_pins: eth-default-pins { > > > + pins-cc { > > > + pinmux =3D , > > > + , > > > + , > > > + ; > > > + drive-strength =3D ; > > > + }; > > > + > > > + pins-mdio { > > > + pinmux =3D , > > > + ; > > > + input-enable; > > > + }; > > > + > > > + pins-phy-reset { > > > + pinmux =3D ; > > > + }; > > > + > > > + pins-power { > > > + pinmux =3D , > > > + ; > > > + output-high; > > > + }; > > > + > > > + pins-rxd { > > > + pinmux =3D , > > > + , > > > + , > > > + ; > > > + }; > > > + > > > + pins-txd { > > > + pinmux =3D , > > > + , > > > + , > > > + ; > > > + drive-strength =3D ; > > > + }; > > > + }; > > > + > > > + eth_sleep_pins: eth-sleep-pins { > > > + pins-cc { > > > + pinmux =3D , > > > + , > > > + , > > > + ; > > > + }; > > > + > > > + pins-mdio { > > > + pinmux =3D , > > > + ; > > > + input-disable; > > > + bias-disable; > > > + }; > > > + > > > + pins-phy-reset { > > > + pinmux =3D ; > > > + input-disable; > > > + bias-disable; > > > + }; > > > + > > > + pins-power { > > > + pinmux =3D , > > > + ; > > > + input-disable; > > > + bias-disable; > > > + }; > > > + > > > + pins-rxd { > > > + pinmux =3D , > > > + , > > > + , > > > + ; > > > + }; > > > + > > > + pins-txd { > > > + pinmux =3D , > > > + , > > > + , > > > + ; > > > + }; > > > + }; > > > + > > > gpio_keys_pins: gpio-keys-pins { > > > pins { > > > pinmux =3D ; > >=20 > > Tested-by: Macpaul Lin > >=20 >=20 > I get the following error: > Error: arch/arm64/boot/dts/mediatek/mt8195.dtsi:582.26-27 syntax error I think he used my upstreaming branch where I store the patches I sent and will send to the mailing list: [0]. I forgot there is a dependency between this patch and [1], and I forgot to test this patch serie independenly from the other commits from my branch. I will make sure to not forget next time. So from this patch serie, only patch 1-2, 6-7 can be applied since they don't have any hidden dependency: dt-bindings: usb: mediatek,mtu3: add binding for MT8195 SoC arm64: dts: mediatek: mt8195: add ssusb support arm64: dts: mediatek: mt8195-demo: Remove input-name property arm64: dts: mediatek: mt8195-demo: enable uart1 [0] https://github.com/Fabo/linux/tree/mt8195-demo [1] https://lore.kernel.org/all/20210615173233.26682-7-tinghan.shen@mediate= k.com/ >=20 >=20 >=20 > How did you test? >=20 > Regards, > Matthias --lzoq53ieck3g4u4f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQyJHfU3UNW7IG61XVJKc6g3CeAAFAmJsApoACgkQVJKc6g3C eADspw/+L2GTNsHF9vIW29/RPamW2SwAH5iyxGmnDfgAGPU5P2dIVC+TQv4bGPCf YCF58yZGnNRljB7gUISwbBpq+fXSsU0rusTqNV7HYTDQV55MAUt+qYUPHsJjTWLC NcrUEf532RGv2uD/fSaQlMsfx55KZUepAkljPrvesjiRB55zrJQeEFO/cCdPsEMG e9Dx/+uZC1HR0zgy35FuuSvQLAXEuLQP+i10NDfpNAb2Fx9dQGeQnGsLlLv80NUP h7p4kJpytmrMVI0qRnj9i9boAOaJQyA/3HXpZqxN68QeRWS5nnx/3SsFedpwjqRK 8IWz8DveEwUi1fxO7TjajgNPdKj6FuZWSoPTxg+Rl1uQzBSsYADidZ7JwyB/qH/w JbY1q+OlN/KJ8yx0eSQa6sFrjNIMbljcb0NJ4/FTWsnxI6UZ+93GbwpnPJ/MTc3J dX3G86mla/+lWLjz99e9bbgQndoXvPk0smBGM2roZYd5O5vzbP+CVBF63UXIOlCy jGOKd8fDRSMCRYSU56AV7WMdwbgzAMJ7sZmqF8OIZqJFfo7jijv/U500jmP++bQq 7sFaQcyvLFr75yNXNiBBAJgNjHcfM1zz3BQaWL62XoA7hqZ4wMdWNPz9dBu5A89x jxawIrm5GhlRAugRaKYFPoOoDyEGtIWqRQHp8ja2m8Fiibtn5g8= =u18v -----END PGP SIGNATURE----- --lzoq53ieck3g4u4f-- --===============3104810538259598611== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek --===============3104810538259598611==--