Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Fix optional reg-names for mtk,scp

Nícolas F. R. A. Prado
2022-05-02T18:33:29Z

On Mon, May 02, 2022 at 10:33:29AM -0500, Rob Herring wrote:
> On Fri, 29 Apr 2022 17:11:09 -0400, Nícolas F. R. A. Prado wrote:
> > The SCP has three memory regions: sram, l1tcm and cfg. Only sram is
> > required, the other two are optional. Fix the dt-binding so that the
> > optional regions can be omitted and passed in any order.
> >
> > Also add the missing minItems to the reg property and update the
> > description.
> >
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> >
> > ---
> >
> > .../devicetree/bindings/remoteproc/mtk,scp.yaml | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.

Hi Rob,

These indeed aren't new warnings. But in any case, the fix for the interrupts
one is already on its way to mainline [1]. And the memory-region one is what is
fixed by patch 2 in this series.

Thanks,
Nícolas

[1] https://lore.kernel.org/all/165066838719.2742284.7900096409445311556.b4-ty@linaro.org/

>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/
>
>
> scp@10500000: interrupts: [[0, 174, 4]] is not of type 'object'
> arch/arm64/boot/dts/mediatek/mt8183-evb.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb
>
> scp@10500000: memory-region: [[25]] is not of type 'object'
> arch/arm64/boot/dts/mediatek/mt8183-evb.dtb
>
> scp@10500000: memory-region: [[27]] is not of type 'object'
> arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dtb
>
> scp@10500000: memory-region: [[28]] is not of type 'object'
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel14-sku2.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper-sku16.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kappa.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-kenzo.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku0.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow-sku1.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu-sku22.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku16.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku272.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku288.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama-sku32.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku0.dtb
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dtb
>
>
> --
> To unsubscribe, send mail to kernel-unsubscribe@lists.collabora.co.uk.