Re: [PATCH 2/2] dt-bindings: remoteproc: mediatek: Add optional memory-region to mtk,scp

Nícolas F. R. A. Prado
2022-05-02T18:35:46Z

On Mon, May 02, 2022 at 11:04:11AM -0500, Rob Herring wrote:
> On Fri, Apr 29, 2022 at 05:11:10PM -0400, Nícolas F. R. A. Prado wrote:
> > The SCP co-processor can optionally be passed a reserved memory region
> > to use. Add this property in the dt-binding.
> >
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> >
> > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > index ec9ddeb6ca2c..64a9d2c7ed0d 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
> > @@ -51,6 +51,10 @@ properties:
> > interrupts:
> > maxItems: 1
> >
> > + memory-region:
> > + $ref: /schemas/types.yaml#/definitions/phandle
>
> memory-region has a type already, so drop. What's needed is how many
> entries and what they are if more than 1.

Hi Rob,

OK, didn't notice this common property was already documented elsewhere. In that
case I'll also drop the description since it's only 1.

Thanks,
Nícolas

>
> > + description: phandle to reserved memory region.
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.36.0
> >
> >