Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: "AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	kernel@collabora.com,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	"Allen-KH Cheng" <allen-kh.cheng@mediatek.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: [PATCH 3/3] arm64: dts: mt8192: Follow clock order for XHCI
Date: Fri, 17 Jun 2022 18:29:16 -0400	[thread overview]
Message-ID: <20220617222916.2435618-4-nfraprado@collabora.com> (raw)
In-Reply-To: <20220617222916.2435618-1-nfraprado@collabora.com>

Even though "ref_ck" and "xhci_ck" are optional clocks for XHCI, the
binding expects them to follow a specific order. Fix the order to get
rid of a dtbs_check warning.

Fixes: e5aac2258e66 ("arm64: dts: mt8192: Add xhci node")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---

 arch/arm64/boot/dts/mediatek/mt8192.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
index 733aec2e7f77..c8158b573bf8 100644
--- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
@@ -723,9 +723,9 @@ xhci: usb@11200000 {
 			assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D5_D4>,
 						 <&topckgen CLK_TOP_UNIVPLL_D5_D4>;
 			clocks = <&infracfg CLK_INFRA_SSUSB>,
-				 <&infracfg CLK_INFRA_SSUSB_XHCI>,
-				 <&apmixedsys CLK_APMIXED_USBPLL>;
-			clock-names = "sys_ck", "xhci_ck", "ref_ck";
+				 <&apmixedsys CLK_APMIXED_USBPLL>,
+				 <&infracfg CLK_INFRA_SSUSB_XHCI>;
+			clock-names = "sys_ck", "ref_ck", "xhci_ck";
 			wakeup-source;
 			mediatek,syscon-wakeup = <&pericfg 0x420 102>;
 			status = "disabled";
-- 
2.36.1



      parent reply	other threads:[~2022-06-17 22:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 22:29 [PATCH 0/3] Fixes for dtbs_check warnings on Mediatek XHCI nodes Nícolas F. R. A. Prado
2022-06-17 22:29 ` [PATCH 1/3] dt-bindings: usb: mtk-xhci: Allow wakeup interrupt-names to be optional Nícolas F. R. A. Prado
2022-06-18  1:30   ` Krzysztof Kozlowski
2022-06-19  7:47   ` Chunfeng Yun
2022-06-17 22:29 ` [PATCH 2/3] dt-bindings: usb: mtk-xhci: Allow middle optional clocks to be missing Nícolas F. R. A. Prado
2022-06-18  1:25   ` Krzysztof Kozlowski
2022-06-19  7:46     ` Chunfeng Yun
2022-06-19 12:05       ` Krzysztof Kozlowski
2022-06-20  6:59         ` Chunfeng Yun
2022-06-20  8:50           ` Krzysztof Kozlowski
2022-06-20 15:50             ` Nícolas F. R. A. Prado
2022-06-21  7:14               ` Krzysztof Kozlowski
2022-06-22  1:57                 ` Chunfeng Yun
2022-06-22  6:10                   ` Wenbin Mei
2022-06-22 13:22                     ` Nícolas F. R. A. Prado
2022-06-19  7:40   ` Chunfeng Yun
2022-06-19 11:49     ` Krzysztof Kozlowski
2022-06-17 22:29 ` Nícolas F. R. A. Prado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220617222916.2435618-4-nfraprado@collabora.com \
    --to=nfraprado@collabora.com \
    --cc=allen-kh.cheng@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox