Re: [PATCH v3 03/12] drm/mediatek: hdmi: use a regmap instead of iomem

Guillaume Ranquet
2022-11-07T14:59:07Z

On Mon, 07 Nov 2022 12:20, AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>Il 04/11/22 15:09, Guillaume Ranquet ha scritto:
>> To prepare support for newer chips that need to share their address
>> range with a dedicated ddc driver, use a regmap.
>>
>> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
>> ---
>> drivers/gpu/drm/mediatek/mtk_hdmi.c | 43 +++++++++++--------------------------
>> 1 file changed, 13 insertions(+), 30 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
>> index 4c80b6896dc3..9b02b30a193a 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
>> @@ -171,7 +171,7 @@ struct mtk_hdmi {
>> u32 ibias_up;
>> struct regmap *sys_regmap;
>> unsigned int sys_offset;
>> - void __iomem *regs;
>> + struct regmap *regs;
>> enum hdmi_colorspace csp;
>> struct hdmi_audio_param aud_param;
>> bool audio_enable;
>> @@ -187,44 +187,29 @@ static inline struct mtk_hdmi *hdmi_ctx_from_bridge(struct drm_bridge *b)
>> return container_of(b, struct mtk_hdmi, bridge);
>> }
>>
>> -static u32 mtk_hdmi_read(struct mtk_hdmi *hdmi, u32 offset)
>> +static int mtk_hdmi_read(struct mtk_hdmi *hdmi, u32 offset, u32 *val)
>> {
>> - return readl(hdmi->regs + offset);
>> + return regmap_read(hdmi->regs, offset, val);
>> }
>>
>> static void mtk_hdmi_write(struct mtk_hdmi *hdmi, u32 offset, u32 val)
>> {
>> - writel(val, hdmi->regs + offset);
>> + regmap_write(hdmi->regs, offset, val);
>> }
>>
>> static void mtk_hdmi_clear_bits(struct mtk_hdmi *hdmi, u32 offset, u32 bits)
>
>You don't need these functions anymore, as these are now simply wrapping
>regmap calls, hence these don't contain any "real" logic anymore.
>
>Please remove them and use the regmap API directly.
>
>Thanks,
>Angelo
>

Agree with that, my intent was to minimize the change size so that it
would be easy to review.

My mistake, I'll remove the wrappers.

Thx,
Guillaume.