Re: [PATCH v5 5/7] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema

Guenter Roeck
2022-11-09T13:53:41Z

On Wed, Nov 09, 2022 at 10:04:09AM +0100, Krzysztof Kozlowski wrote:
> On 08/11/2022 11:50, Matthias Brugger wrote:
> >
> >
> > On 08/11/2022 04:32, Allen-KH Cheng wrote:
> >> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >>
> >> Convert the MediaTek watchdog bindings to schema.
> >>
> >> The original binding only had 4 without a fallback but there is a reset
> >> controller on the "mediatek,mt7986-wdt", "mediatek,mt8186-wdt",
> >> "mediatek,mt8188-wdt" and "mediatek,mt8195-wdt" Since there is no reset
> >> controller for the mt6589, we remove "mediatek,mt6589-wdt" as a
> >> fallback.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> Co-developed-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> >> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> >> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> >
> > As I'm put as the maintainer:
> > Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> >
> > Shall I take that through my tree or shall it go through the watchdog tree?
> >
>
> In general, bindings should go via subsystem trees (so watchdog), just
> like drivers. However this got Guenter's review tag, so usually it means
> also an ack... Dunno... :)

For watchdog patches, if I send a Reviewed-by: tag, I expect Wim to pick
up the patch through the watchdog tree. If I expect some other tree to
pick it up, I use Acked-by: and usually add a note saying that I assume
that the patch will be picked up by someone else.

I usually also add watchdog patches to my own watchdog-next tree as
reference for Wim. I already have several mediatek devicetree patches
queued there. Handling some of the patches through watchdog and others
through some other tree would create a mess. Please don't do that.

Guenter