From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2B39C6FD19 for ; Sun, 12 Mar 2023 13:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1pg5Zo6BdnWLEvX0DvI/FucpOTpBbBwKPytQuXI8duE=; b=g+c+L+R6uRzjIamHkEsHs56RRc Z7laf5lhOMwsrnLS4wyKtBXEwpk8KOQ1FLab3zVBL7hQwYN30ALR9ViMIFPNpUXggLJJSJloDKOhG k4ryOy8y5BmlP73sRmg6gFuljxuNP24hjT4jRYqX2NbQl2YHFcmJ8tUyaFMdZVgVqA+qYuMIj+Iyj CDBGFXbtv5kO8KRxvrwm/iIhZxBwarPB284Gi+fwCYV29Ad/qtwQwxMwHcmbQXoUEeMUbGJD1m2L7 u/EfT6632uVWdwMSTC7lOwy+f/rLdcb8jvyfQizm4c1Gb9kWCd8ToZGs0Vl/KK+lEO2va0fg/UccH bD2IniCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbM3H-002XRY-6E; Sun, 12 Mar 2023 13:47:55 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbM0c-002W4q-Bj; Sun, 12 Mar 2023 13:45:12 +0000 Received: from pendragon.ideasonboard.com (85-76-21-162-nat.elisa-mobile.fi [85.76.21.162]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36404D5F; Sun, 12 Mar 2023 14:45:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1678628709; bh=Zge1++nlY4nQwaZw6hX8CIUKOyEq8hcIOLjF6pHDcZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XJZ//ZHE3EbQS8Y4lNXhTDBZP4Jjk20f3KPF//qHiq3BrXlTY/FD66fPC10Hvt2+w wHFbQfPcoD3oSwVMGOQUvrcnSdbypRP2LNA6j52wT64JJA/QzIyTJmopOinHD5nKiW ejmyEBAuYy3NuXFkDNOql56IcKUI3wPSj4tTVzEM= Date: Sun, 12 Mar 2023 15:44:56 +0200 From: Laurent Pinchart To: Krzysztof Kozlowski Cc: Joe Tessler , Hans Verkuil , Mauro Carvalho Chehab , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Thierry Reding , Jonathan Hunter , Manivannan Sadhasivam , Michael Tretter , Pengutronix Kernel Team , Jacopo Mondi , Kieran Bingham , Niklas =?utf-8?Q?S=C3=B6derlund?= , Rui Miguel Silva , Wenyou Yang , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Andrzej Pietrasiewicz , Jacek Anaszewski , Sylwester Nawrocki , Patrice Chotard , Yong Deng , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Lad, Prabhakar" , Ezequiel Garcia , Philipp Zabel , Sean Young , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 26/28] media: i2c: imx290: drop of_match_ptr for ID table Message-ID: <20230312134456.GN2545@pendragon.ideasonboard.com> References: <20230312131318.351173-1-krzysztof.kozlowski@linaro.org> <20230312131318.351173-26-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230312131318.351173-26-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230312_064510_617323_A40109FD X-CRM114-Status: GOOD ( 19.21 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thank you for the patch. On Sun, Mar 12, 2023 at 02:13:16PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table so the table should be always > used and the of_match_ptr does not have any sense (this also allows ACPI > matching via PRP0001, even though it might not be relevant here). This > also fixes !CONFIG_OF error: > > drivers/media/i2c/imx290.c:1354:34: error: ‘imx290_of_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/imx290.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index 49d6c8bdec41..3c9470fbfd53 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -1363,7 +1363,7 @@ static struct i2c_driver imx290_i2c_driver = { > .driver = { > .name = "imx290", > .pm = &imx290_pm_ops, > - .of_match_table = of_match_ptr(imx290_of_match), > + .of_match_table = imx290_of_match, > }, > }; > -- Regards, Laurent Pinchart