From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8EACC74A5B for ; Fri, 17 Mar 2023 08:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XOZB9qP4V2fnBtbj4A3gxU1/hFozIGe8d1PTdU+JLg0=; b=Blpi8bJ2BjrjAfQKeC3x5q2PmB xKhKrEKgyhbSdYgScy6sCoeuZ0N8P+8mUADZnQ5s0bez76uBq4xXNvGH2R/IdpKgQEDqzkrXEh0eb UHHxA54CQsnpxt62RuI6JS5ZGclsT5DnGsQ8uYhTZGK8jOkP3mfET4hUNYTb+IIjX5KAyRrYhsV46 jxR1ahNunAmV5AcqFdexy0uF8mRyvkY0q+gF3Hou+ZQrFHA8Y6aWnQSxZneWBz/hYYqGCi0nAR64E DW01ExEShSlAMnIbmqtlS0mrNEouYpjZXzgA5aHSb4An7rAjzd8utPeXuc1YbmjjuYAMCzBKjl4z3 A+C+BSrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd53l-001NwW-18; Fri, 17 Mar 2023 08:03:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pd53h-001Nvc-1k; Fri, 17 Mar 2023 08:03:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F0E93621E2; Fri, 17 Mar 2023 08:03:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ED5AC433D2; Fri, 17 Mar 2023 08:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679040208; bh=ZjbZpcLBddKRtJpy6gJho7oasohnkmV6uVOjo4XlR+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=beDZHSVdgZbTMffnz9NNHhkxeNptV/lBtxnwF+/IrRa4mEuBwIz1NMt/Ik70BgnEZ J98g67W1QwAfa20ougP7ZOZZxry+1y+6fTtGxUDeuxDl4C44A0qgIlUQoXtcaKgeqh etOtwS77uWFeS76GD8KOB3o9INr1PjlBB8pN73YzzTfH4RAQyCXWDIColH2LRxulKq EdCGb3xHZ+NsRD68jTqB33eaqLRpjxqGWYhGxRthZfSr2DDv2z8/QM81NVw8zrR62Z 1AA0ZH0o5zfcF5af1anv5Nfh9tPb3RxsX+FW9DJNPbbL53wNUf3gqE3aza4kQx6zhQ IzdBo6AUfoodw== Date: Fri, 17 Mar 2023 08:03:21 +0000 From: Lee Jones To: ChiaEn Wu Cc: corbet@lwn.net, pavel@ucw.cz, matthias.bgg@gmail.com, andriy.shevchenko@linux.intel.com, jacek.anaszewski@gmail.com, angelogioacchino.delregno@collabora.com, linux-doc@vger.kernel.org, peterwu.pub@gmail.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, szunichen@gmail.com, Alice Chen Subject: Re: [PATCH v18 2/3] leds: flash: mt6370: Add MediaTek MT6370 flashlight support Message-ID: <20230317080321.GC9667@google.com> References: <52480420a160e5a4c71715fbbf105e684a16e7c2.1678430444.git.chiaen_wu@richtek.com> <20230317080016.GB9667@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230317080016.GB9667@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230317_010329_850073_7B451CA3 X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 17 Mar 2023, Lee Jones wrote: > On Fri, 10 Mar 2023, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > The MediaTek MT6370 is a highly-integrated smart power management IC, > > which includes a single cell Li-Ion/Li-Polymer switching battery > > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash > > LED current sources, a RGB LED driver, a backlight WLED driver, > > a display bias driver and a general LDO for portable devices. > > > > Add support for the MT6370 Flash LED driver. Flash LED in MT6370 > > has 2 channels and support torch/strobe mode. > > > > Acked-by: Jacek Anaszewski > > Co-developed-by: Alice Chen > > Signed-off-by: Alice Chen > > Signed-off-by: ChiYuan Huang > > Signed-off-by: ChiaEn Wu > > --- > > v18: > > - Unwrap each line by 100 chars limit. > > - For joint flash, add more comments above the source code. > > - Remove 'sentinel' comment in of_device_id table declaration. > > --- > > drivers/leds/flash/Kconfig | 13 + > > drivers/leds/flash/Makefile | 1 + > > drivers/leds/flash/leds-mt6370-flash.c | 573 +++++++++++++++++++++++++++++++++ > > 3 files changed, 587 insertions(+) > > create mode 100644 drivers/leds/flash/leds-mt6370-flash.c > > Applied, thanks Next time, please make checkpatch.pl happy before submitting. -- Lee Jones [李琼斯]