* [PATCH] soc: mediatek: mutex: Use dev_err_probe()
@ 2023-03-24 2:17 ye.xingchen
2023-03-24 8:28 ` AngeloGioacchino Del Regno
2023-04-02 17:27 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: ye.xingchen @ 2023-03-24 2:17 UTC (permalink / raw)
To: matthias.bgg
Cc: angelogioacchino.delregno, linux-kernel, linux-arm-kernel,
linux-mediatek
From: Ye Xingchen <ye.xingchen@zte.com.cn>
Replace the open-code with dev_err_probe() to simplify the code.
Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
---
drivers/soc/mediatek/mtk-mutex.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
index 7751527fc30d..05c8ad3c2664 100644
--- a/drivers/soc/mediatek/mtk-mutex.c
+++ b/drivers/soc/mediatek/mtk-mutex.c
@@ -1014,11 +1014,8 @@ static int mtk_mutex_probe(struct platform_device *pdev)
if (!mtx->data->no_clk) {
mtx->clk = devm_clk_get(dev, NULL);
- if (IS_ERR(mtx->clk)) {
- if (PTR_ERR(mtx->clk) != -EPROBE_DEFER)
- dev_err(dev, "Failed to get clock\n");
- return PTR_ERR(mtx->clk);
- }
+ if (IS_ERR(mtx->clk))
+ return dev_err_probe(dev, PTR_ERR(mtx->clk), "Failed to get clock\n");
}
mtx->regs = devm_platform_get_and_ioremap_resource(pdev, 0, ®s);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: mutex: Use dev_err_probe()
2023-03-24 2:17 [PATCH] soc: mediatek: mutex: Use dev_err_probe() ye.xingchen
@ 2023-03-24 8:28 ` AngeloGioacchino Del Regno
2023-04-02 17:27 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-03-24 8:28 UTC (permalink / raw)
To: ye.xingchen, matthias.bgg; +Cc: linux-kernel, linux-arm-kernel, linux-mediatek
Il 24/03/23 03:17, ye.xingchen@zte.com.cn ha scritto:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: mutex: Use dev_err_probe()
2023-03-24 2:17 [PATCH] soc: mediatek: mutex: Use dev_err_probe() ye.xingchen
2023-03-24 8:28 ` AngeloGioacchino Del Regno
@ 2023-04-02 17:27 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2023-04-02 17:27 UTC (permalink / raw)
To: ye.xingchen
Cc: angelogioacchino.delregno, linux-kernel, linux-arm-kernel,
linux-mediatek
On 24/03/2023 03:17, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Applied, thanks
> ---
> drivers/soc/mediatek/mtk-mutex.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c
> index 7751527fc30d..05c8ad3c2664 100644
> --- a/drivers/soc/mediatek/mtk-mutex.c
> +++ b/drivers/soc/mediatek/mtk-mutex.c
> @@ -1014,11 +1014,8 @@ static int mtk_mutex_probe(struct platform_device *pdev)
>
> if (!mtx->data->no_clk) {
> mtx->clk = devm_clk_get(dev, NULL);
> - if (IS_ERR(mtx->clk)) {
> - if (PTR_ERR(mtx->clk) != -EPROBE_DEFER)
> - dev_err(dev, "Failed to get clock\n");
> - return PTR_ERR(mtx->clk);
> - }
> + if (IS_ERR(mtx->clk))
> + return dev_err_probe(dev, PTR_ERR(mtx->clk), "Failed to get clock\n");
> }
>
> mtx->regs = devm_platform_get_and_ioremap_resource(pdev, 0, ®s);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-02 17:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-24 2:17 [PATCH] soc: mediatek: mutex: Use dev_err_probe() ye.xingchen
2023-03-24 8:28 ` AngeloGioacchino Del Regno
2023-04-02 17:27 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).