From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Inki Dae <daeinki@gmail.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Xinliang Liu" <xinliang.liu@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
dri-devel@lists.freedesktop.org,
"Russell King" <linux@armlinux.org.uk>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Anitha Chrisanthus" <anitha.chrisanthus@intel.com>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Steven Price" <steven.price@arm.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Robert Foss" <rfoss@kernel.org>,
"Karol Herbst" <kherbst@redhat.com>,
"Samuel Holland" <samuel@sholland.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Kuogee Hsieh" <quic_khsieh@quicinc.com>,
"Akhil P Oommen" <quic_akhilpo@quicinc.com>,
"Danilo Krummrich" <dakr@redhat.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Miaoqian Lin" <linmq006@gmail.com>,
linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev,
"Rahul T R" <r-ravikumar@ti.com>,
"Raphael Gallais-Pou" <raphael.gallais-pou@foss.st.com>,
"Jani Nikula" <jani.nikula@intel.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
etnaviv@lists.freedesktop.org,
"Stephen Boyd" <swboyd@chromium.org>,
"Sean Paul" <sean@poorly.run>,
"Johan Hovold" <johan+linaro@kernel.org>,
"Hyun Kwon" <hyun.kwon@xilinx.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
kernel@pengutronix.de, "Alex Deucher" <alexander.deucher@amd.com>,
freedreno@lists.freedesktop.org,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
linux-aspeed@lists.ozlabs.org,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Yongqin Liu" <yongqin.liu@linaro.org>,
"Mihail Atanassov" <mihail.atanassov@arm.com>,
"Liang He" <windhl@126.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
lima@lists.freedesktop.org,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Alexey Brodkin" <abrodkin@synopsys.com>,
"Minghao Chi" <chi.minghao@zte.com.cn>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Russell King" <linux+etnaviv@armlinux.org.uk>,
"Alain Volmat" <alain.volmat@foss.st.com>,
linux-mips@vger.kernel.org, "Liu Ying" <victor.liu@nxp.com>,
linux-arm-msm@vger.kernel.org,
"Maxime Ripard" <mripard@kernel.org>,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Douglas Anderson" <dianders@chromium.org>,
"John Stultz" <jstultz@google.com>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Brian Starkey" <brian.starkey@arm.com>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Yuan Can" <yuancan@huawei.com>, "Stefan Agner" <stefan@agner.ch>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-tegra@vger.kernel.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Rob Herring" <robh@kernel.org>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Mali DP Maintainers" <malidp@foss.arm.com>,
"Joel Stanley" <joel@jms.id.au>,
nouveau@lists.freedesktop.org, "Orson Zhai" <orsonzhai@gmail.com>,
"Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
"Lyude Paul" <lyude@redhat.com>, "Arnd Bergmann" <arnd@arndb.de>,
"Guo Zhengkui" <guozhengkui@vivo.com>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
"Alison Wang" <alison.wang@nxp.com>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Christian Gmeiner" <christian.gmeiner@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Maxime Ripard" <maxime@cerno.tech>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Liu Shixin" <liushixin2@huawei.com>,
"Tomi Valkeinen" <tomba@kernel.org>,
"Deepak R Varma" <drv@mailo.com>,
"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
"Ricardo Ribalda" <ribalda@chromium.org>,
"Tian Tao" <tiantao6@hisilicon.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Yannick Fertre" <yannick.fertre@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Emma Anholt" <emma@anholt.net>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"David Airlie" <airlied@gmail.com>, "Marek Vasut" <marex@denx.de>,
linux-renesas-soc@vger.kernel.org,
"Jayshri Pawar" <jpawar@cadence.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Rob Clark" <robdclark@gmail.com>,
"Philippe Cornu" <philippe.cornu@foss.st.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Melissa Wen" <mwen@igalia.com>,
linux-mediatek@lists.infradead.org,
"Fabio Estevam" <festevam@gmail.com>,
"Laurentiu Palcu" <laurentiu.palcu@oss.nxp.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Qiang Yu" <yuq825@gmail.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Jyri Sarha" <jyri.sarha@iki.fi>,
"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH 00/53] drm: Convert to platform remove callback returning void
Date: Mon, 15 May 2023 11:20:19 +0200 [thread overview]
Message-ID: <20230515092019.a3uwmofkkujo772g@pengutronix.de> (raw)
In-Reply-To: <CAAQKjZP5jhwFg9sNndpa6_7G6HoV76heQbt=knoOEZZskexrhg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2089 bytes --]
On Mon, May 15, 2023 at 04:50:57PM +0900, Inki Dae wrote:
> Hi,
>
> 2023년 5월 8일 (월) 오전 1:32, Uwe Kleine-König <u.kleine-koenig@pengutronix.de>님이 작성:
> >
> > Hello,
> >
> > this patch series adapts the platform drivers below drivers/gpu/drm
> > to use the .remove_new() callback. Compared to the traditional .remove()
> > callback .remove_new() returns no value. This is a good thing because
>
> First of all, I apologize for the delay in providing my review comments.
>
> Not related to this patch but seems that the "remove_new" callback
> naming implicitly implies that there is no need to return anything
> since its return type is void. To help users understand the intended
> behavior based on the callback name, how about considering a modified
> naming convention like "remove_no_return" or something similar?
>
> The relevant patch has already been merged as outlined below,
> author Uwe Kleine-König <u.kleine-koenig@pengutronix.de> 2022-12-09
> 16:09:14 +0100
> committer Greg Kroah-Hartman <gregkh@linuxfoundation.org> 2023-01-17
> 19:04:17 +0100
> commit 5c5a7680e67ba6fbbb5f4d79fa41485450c1985c (patch)
> tree 0b6dbc003a6bb4a3f7fb084d31326bbfa3ba3f7c
> parent 7bbb89b420d9e290cb34864832de8fcdf2c140dc (diff)
> download linux-5c5a7680e67ba6fbbb5f4d79fa41485450c1985c.tar.gz
> platform: Provide a remove callback that returns no value
>
> Maybe a trivial thing but how about renaming it? I think the postfix,
> 'new', is a very generic word. I think you could introduce another
> patch for it if you think it's reasonable.
.remove_new is only a temporary name. Once all drivers are converted,
.remove is changed to return void and then all drivers are converted
back. While "remove_new" might not be a brilliant name choice, touching
all already converted drivers again just to improve the temporary
measures doesn't sound right.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-15 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 16:25 [PATCH 00/53] drm: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-07 16:25 ` [PATCH 28/53] drm/mediatek: " Uwe Kleine-König
2023-05-08 8:25 ` Matthias Brugger
2023-05-07 16:25 ` [PATCH 29/53] " Uwe Kleine-König
2023-05-08 8:26 ` Matthias Brugger
2023-05-08 7:06 ` [PATCH 00/53] drm: " Thomas Zimmermann
2023-05-08 7:50 ` Uwe Kleine-König
2023-05-15 7:50 ` Inki Dae
2023-05-15 9:20 ` Uwe Kleine-König [this message]
2023-09-09 14:37 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515092019.a3uwmofkkujo772g@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=abrodkin@synopsys.com \
--cc=airlied@gmail.com \
--cc=alain.volmat@foss.st.com \
--cc=alexander.deucher@amd.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=alison.wang@nxp.com \
--cc=andersson@kernel.org \
--cc=andrew@aj.id.au \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anitha.chrisanthus@intel.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=bbrezillon@kernel.org \
--cc=brian.starkey@arm.com \
--cc=broonie@kernel.org \
--cc=bskeggs@redhat.com \
--cc=chi.minghao@zte.com.cn \
--cc=christian.gmeiner@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=daeinki@gmail.com \
--cc=dakr@redhat.com \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=drv@mailo.com \
--cc=emma@anholt.net \
--cc=etnaviv@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=guozhengkui@vivo.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hyun.kwon@xilinx.com \
--cc=jani.nikula@intel.com \
--cc=javierm@redhat.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=joel@jms.id.au \
--cc=johan+linaro@kernel.org \
--cc=jonas@kwiboo.se \
--cc=jonathanh@nvidia.com \
--cc=jpawar@cadence.com \
--cc=jstultz@google.com \
--cc=jyri.sarha@iki.fi \
--cc=kernel@pengutronix.de \
--cc=kherbst@redhat.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=laurentiu.palcu@oss.nxp.com \
--cc=lima@lists.freedesktop.org \
--cc=linmq006@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liushixin2@huawei.com \
--cc=liviu.dudau@arm.com \
--cc=lyude@redhat.com \
--cc=malidp@foss.arm.com \
--cc=marex@denx.de \
--cc=marijn.suijten@somainline.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime@cerno.tech \
--cc=mcanal@igalia.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=mihail.atanassov@arm.com \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=noralf@tronnes.org \
--cc=nouveau@lists.freedesktop.org \
--cc=orsonzhai@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=paul@crapouillou.net \
--cc=philippe.cornu@foss.st.com \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=r-ravikumar@ti.com \
--cc=raphael.gallais-pou@foss.st.com \
--cc=rfoss@kernel.org \
--cc=ribalda@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=samuel@sholland.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=steven.price@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tomba@kernel.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wens@csie.org \
--cc=windhl@126.com \
--cc=xinliang.liu@linaro.org \
--cc=yannick.fertre@foss.st.com \
--cc=yongqin.liu@linaro.org \
--cc=yuancan@huawei.com \
--cc=yuq825@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox