[PATCH v2] regulator: mt6359: add read check for PMIC MT6359

[PATCH v2] regulator: mt6359: add read check for PMIC MT6359

[Sen Chu]

Add hardware version read check for PMIC MT6359

Signed-off-by: Sen Chu <sen.chu@mediatek.com>
---
Change in v1:
    Fix: this should be if (ret)
    [Sen Chu <sen.chu@mediatek.com>]
---
---
 drivers/regulator/mt6359-regulator.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/mt6359-regulator.c b/drivers/regulator/mt6359-regulator.c
index 1849566784ab..3eb86ec21d08 100644
--- a/drivers/regulator/mt6359-regulator.c
+++ b/drivers/regulator/mt6359-regulator.c
@@ -951,9 +951,12 @@ static int mt6359_regulator_probe(struct platform_device *pdev)
 	struct regulator_config config = {};
 	struct regulator_dev *rdev;
 	struct mt6359_regulator_info *mt6359_info;
-	int i, hw_ver;
+	int i, hw_ver, ret;
+
+	ret = regmap_read(mt6397->regmap, MT6359P_HWCID, &hw_ver);
+	if (ret)
+		return ret;
 
-	regmap_read(mt6397->regmap, MT6359P_HWCID, &hw_ver);
 	if (hw_ver >= MT6359P_CHIP_VER)
 		mt6359_info = mt6359p_regulators;
 	else
-- 
2.18.0

Re: [PATCH v2] regulator: mt6359: add read check for PMIC MT6359

[AngeloGioacchino Del Regno]

Il 18/05/23 06:06, Sen Chu ha scritto:
> Add hardware version read check for PMIC MT6359
> 
> Signed-off-by: Sen Chu <sen.chu@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH v2] regulator: mt6359: add read check for PMIC MT6359

[Chen-Yu Tsai]

On Thu, May 18, 2023 at 5:32 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 18/05/23 06:06, Sen Chu ha scritto:
> > Add hardware version read check for PMIC MT6359
> >
> > Signed-off-by: Sen Chu <sen.chu@mediatek.com>
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

No fixes tag?

Re: [PATCH v2] regulator: mt6359: add read check for PMIC MT6359

[AngeloGioacchino Del Regno]

Il 18/05/23 11:47, Chen-Yu Tsai ha scritto:
> On Thu, May 18, 2023 at 5:32 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Il 18/05/23 06:06, Sen Chu ha scritto:
>>> Add hardware version read check for PMIC MT6359
>>>
>>> Signed-off-by: Sen Chu <sen.chu@mediatek.com>
>>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
> No fixes tag?

You're right. This one needs a fixes tag.

The right tag is

Fixes: 4cfc96547512 ("regulator: mt6359: Add support for MT6359P regulator")

Cheers,
Angelo

Re: [PATCH v2] regulator: mt6359: add read check for PMIC MT6359

[Mark Brown]

On Thu, 18 May 2023 12:06:46 +0800, Sen Chu wrote:
> Add hardware version read check for PMIC MT6359
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: mt6359: add read check for PMIC MT6359
      commit: a511637502b1caa135046d0f8fdabd55a31af8ef

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark