From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E98BEC04A6A for ; Mon, 24 Jul 2023 16:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UJJiQpVV1gCXbsIeBMQje0c3sS6piHuyHA/brOf5kGE=; b=2uov//419DBje0bdXp54ZUqvtP 0jPiMpSQdJcffa5AUh4GjnG4SrtX3mulpq9rllmq6tG61MySWWGqiObnHnNXOxx2l5CqiErRlCant 7k7GMSaf60lxufJzGN/CuP764EeGOPYVghlEombRcWuZuQ38sLHTFGVogrwmMDfaIqUmsyFLHJCu7 9BERwEOn7n9lZUs7EeutCuYBnmU/THLykEVvnR6pEK8MSIY+WTbsZJzI+H61WQy+bNe1K26OpNWLO 6ZADpfn4TXQqqJwjdohhMe27dm/TAmGdNc3ZjlFb/G403W151TkAq3ZvXQB+jTmPKiM04QIlsU06v xLdqGYvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNyOT-004sGm-05; Mon, 24 Jul 2023 16:26:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNyOP-004sFm-31; Mon, 24 Jul 2023 16:26:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6047461262; Mon, 24 Jul 2023 16:26:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804F9C433C8; Mon, 24 Jul 2023 16:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690216000; bh=NnhraS8BL5Ulb0entmVSGXe3OMU1B/0GaHabwEyEAqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BO7H22sbEac8N0hk1Xfc94utPCZxOSeEAM9ndel6gZBAiG60AnLS8mftvn57mQXzc yc4oE1Y51O8MxBEN2ArPLcNQoaV2p4e/4K+7LGmv+wX1G9cdba/+z6xshhHEUPvn0o kPITafT4aArXOv8nOhPO2Tjyp0irsZkovf+dkQNATOlxJFNQAoFPQ/2hjJN3noLMW0 ysMf+5w4wZoFK3qqc7wtnwyuPAyQ/jOBT3IYOucfZigRbGBX/BuOvCbp19lQyiNjk/ k5ExV/uCqu9c+SFVjLhrZyvMESYWMbPFghVc1coNq3aWPmEl7OkulX5nvLSFsgUDkc HxRs5zjTRBQGQ== Received: (nullmailer pid 3786398 invoked by uid 1000); Mon, 24 Jul 2023 16:26:38 -0000 Date: Mon, 24 Jul 2023 10:26:38 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Jagan Sridharan , ChiYuan Huang , Min Guo , Gene Chen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector Message-ID: <20230724162638.GA3784203-robh@kernel.org> References: <20230723071105.40157-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230723071105.40157-1-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230724_092642_059172_37F2A479 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote: > The usb-connector.yaml schema allows any additional properties, thus its > usage should finish with unevaluatedProperties: false. Is it problematic if usb-connector.yaml is restricted? > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 + > Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 1 + > Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 1 + > Documentation/devicetree/bindings/usb/mediatek,musb.yaml | 1 + > Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 1 + > Documentation/devicetree/bindings/usb/richtek,rt1719.yaml | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > index 276bf7554215..45e093978b82 100644 > --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > @@ -25,6 +25,7 @@ properties: > connector: > type: object > $ref: ../connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > index 053264e60583..42b9d3a35c67 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > @@ -29,6 +29,7 @@ properties: > connector: > type: object > $ref: ../connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml > index a59d91243ac8..7eb880e4a270 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml > @@ -144,6 +144,7 @@ properties: > > connector: > $ref: /schemas/connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Connector for dual role switch, especially for "gpio-usb-b-connector" > type: object > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml > index a39d38db7714..924f74d45baa 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml > @@ -66,6 +66,7 @@ properties: > $ref: /schemas/connector/usb-connector.yaml# > description: Connector for dual role switch > type: object > + unevaluatedProperties: false > > dependencies: > usb-role-switch: [ connector ] > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > index 8da4d2ad1a91..980235e27a7f 100644 > --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > @@ -36,6 +36,7 @@ properties: > connector: > type: object > $ref: /schemas/connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml > index 4ced2f68e2a9..27978580b234 100644 > --- a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml > @@ -34,6 +34,7 @@ properties: > connector: > type: object > $ref: ../connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > -- > 2.34.1 >