From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40EA1C001DE for ; Thu, 27 Jul 2023 00:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uLgNg2grWhReofgXIpSQeENCUDkM2VHYbwpiD6k/MY4=; b=kyByWxkAmDFpYIH51+4fcXeuFc zSWVzr1czoFcOpuN5opJ4W+ra/wL2RV5oE/kbsrs57JAfyJmqM4QNG+pfBZaZFkcMIZkmPUsA791T tgvoEotr9WBg2A1OfkZAlSsjXVJ+FWoSG1jjUptJyuV9XEktI3FfowSQC7OrwMAgLI8llEpDtl6X9 XSfaydjGinOfDhha3YZkYf9PR0JKprvLdYABvlW/rulmmN+orRswMRsQPiCKGehWxbiUyIdJvwQen 2YQADPnZuwfzSfZ4GEBfDcvHermii53BzbPMHP/HBcgHsw80cnE8a8oW0639Nf7vNrXiTaHcDmtGA jSJ2JRdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOp2x-00Bnzk-01; Thu, 27 Jul 2023 00:40:03 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOp2r-00Bny1-0X; Thu, 27 Jul 2023 00:39:59 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CE4261CEB; Thu, 27 Jul 2023 00:39:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAFE0C433C7; Thu, 27 Jul 2023 00:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690418394; bh=hjLR4NUeMP4IVUC9ETRe2AQg79Rs8N5wqjGvIEE1P00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HnMhty9UoZVYTW2+QGN9V5v0VmCGklzjGs/NcHhcqmP7o5s77N+NrhxYytPNdPYSz cPvttFygDUPA6wFU6n0bunWdzCfsZvDk7ZNUOMkqL4S776tkebPFD7MIggAXnpqnVS ID2FI1GaiZFtfsX5LoixIIXJP0jJpftfK7jHAQ/hHona7EIP8lGMLtH2ggAAMd5L/e vlrk6qsAP/CjTn6GpLjsG7fkWifsXMd/j4O7ahabsR9ZQJrqhGnyNi+TsWLjwVq6E2 eDci/Cd+dvSGavZJBkJmF3gLVVOIs3vxRy7nD3xFF0RN+iCspjMdqfe+NKdpZDhMVf THCzdK9MIDqnw== Date: Thu, 27 Jul 2023 02:39:51 +0200 From: Andi Shyti To: Rob Herring Cc: Codrin Ciubotariu , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Jochen Friedrich , Bartosz Golaszewski , Wolfram Sang , Krzysztof Kozlowski , Alim Akhtar , Jean-Marie Verdun , Nick Hawkins , Dong Aisheng , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Oleksij Rempel , Paul Cercueil , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Khalil Blaiech , Asmaa Mnebhi , Chris Packham , Qii Wang , Matthias Brugger , AngeloGioacchino Del Regno , Stefan Roese , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , Chris Brandt , Orson Zhai , Baolin Wang , Chunyan Zhang , Thierry Reding , Jonathan Hunter , Laxman Dewangan , Dmitry Osipenko , Peter Rosin , Michael Hennerich , devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-actions@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] I2C: Explicitly include correct DT includes Message-ID: <20230727003951.q7vyps26t4kjfwmm@intel.intel> References: <20230714174619.4057577-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714174619.4057577-1-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230726_173957_312099_D5FF699C X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, Jul 14, 2023 at 11:46:16AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring I went through all of the changes and they look fine to me. Reviewed-by: Andi Shyti Thanks, Andi