From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD4F5C001DB for ; Fri, 4 Aug 2023 15:05:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+LZBwIaE+oAAZTAGTeOHXkg3Tm/u3i+LK+Ey4FTfqyE=; b=GgWuBWDqh8m+Qmu374hjhJqYEc RyYp1hDUbEqbSFtZGXJWphthe5abSOEYJx3x9WuLlgx9DudmC6aNNFmiyE/+76WU3qjL70Hm7ZfYY AmMxzAHDiodbTXgNxB5bZZj4GHRAbMU++tWqWldI+e3WB1bq+H74RLALKjKf5DWZmIZEUiVluM2li iPrB7PF9iUvgAGoIINOqgodUt/+4TzS1K9jUPmFh27U1nNz1syNvd279z/47Fs0SIvP9U26ADjga1 7h5Y6MgemTUneZkTmgRkAnAYKLFiUi5t2QaCLVzSJsyHQ7BDcchWWxXwyroWbdGSqsZ9bGAmRCVNs lKobrzeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRwMY-00Cf3y-0B; Fri, 04 Aug 2023 15:05:10 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRwMU-00Cf2F-2D; Fri, 04 Aug 2023 15:05:08 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C141012E4; Fri, 4 Aug 2023 17:03:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691161437; bh=tr+A81mL8nDcTz82HPvWaHO5DYHcvkl8gnXU6YqP/oA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NwnKqGOISSHCoT4g/onIOtdggT3c8VNVe6JntI6V+8rCGpENwgWORyCFsw5KPHQPn z9aUrJ9sF4Ag2/bqkXDyI2JmTZAejBZ21hI2p9CWsqv8wQDHzHf9Ryv+MgK5XnDPal Bm3mUPZxQnzBSY8IvBa5/qa4AO6u5zgCBJbM3K2k= Date: Fri, 4 Aug 2023 18:05:07 +0300 From: Laurent Pinchart To: Julien Stephan Cc: AngeloGioacchino Del Regno , Louis Kuo , Phi-bang Nguyen , Florian Sylvestre , Alexander Gordeev , Andy Hsieh , Conor Dooley , daoyuan huang , devicetree@vger.kernel.org, Hans Verkuil , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, Matthias Brugger , Mauro Carvalho Chehab , Moudy Ho , Rob Herring , Vasily Gorbik Subject: Re: [PATCH v2 2/4] media: platform: mediatek: isp_30: add mediatek ISP3.0 sensor interface Message-ID: <20230804150507.GI12951@pendragon.ideasonboard.com> References: <20230630100321.1951138-1-jstephan@baylibre.com> <20230630100321.1951138-3-jstephan@baylibre.com> <72ixohoacq4vgj7nqg4l5gt5bs5e5ewain6a5ovqs3winx3qzz@sbg5lfohq5mq> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <72ixohoacq4vgj7nqg4l5gt5bs5e5ewain6a5ovqs3winx3qzz@sbg5lfohq5mq> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_080506_867849_A8F73AE7 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Aug 04, 2023 at 04:50:05PM +0200, Julien Stephan wrote: > On Mon, Jul 03, 2023 at 01:02:02PM +0200, AngeloGioacchino Del Regno wrote: > > Il 30/06/23 12:01, Julien Stephan ha scritto: > ..snip.. > > > + > > > +static const struct mtk_seninf_format_info mtk_seninf_formats[] = { > > > + { > > > + .code = MEDIA_BUS_FMT_SBGGR8_1X8, > > > + .flags = MTK_SENINF_FORMAT_BAYER, > > > > Each entry fits in one line. > > > > { .code = MEDIA_BUS_FMT_SBGGR8_1X8, .flags = MTK_SENINF_FORMAT_BAYER }, > > > > Hi Angelo, > > Actually not all entries fit in one line. The last 4 ones don't: > > { .code = MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, .flags = MTK_SENINF_FORMAT_DPCM | MTK_SENINF_FORMAT_INPUT_ONLY }, > which is 115 chars.. > > so what is the best? put all in one line except the last 4 one? or keep > them all as is? I'd keep them all as is. > > > + }, { > ..snip.. > > > + udelay(1); > > > + mtk_seninf_input_update(input, SENINF_CTRL, CSI2_SW_RST, 0); > > > > Is there any way to check if the CSI port did reset, or is it *guaranteed* to get > > out of reset in a microsecond after deasserting SW_RST? > > I will double check this > > > > +} > > > + > ..snip.. > > > + > > > + val = mtk_seninf_mux_read(mux, SENINF_MUX_CTRL); > > > > rst_mask = SENINF_MUX_CTRL_SENINF_IRQ_SW_RST | SENINF_MUX_CTRL_SENINF_MUX_SW_RST; > > > > writel(mux->base + SENINF_MUX_CTRL, val | rst_mask); > > writel(mux->base + SENINFMUX_CTRL, val & ~rst_mask); > > > > that's better, right? :-) With mtk_seninf_mux_write() instead of writel(), yes :-) > right :) > > > > + mtk_seninf_mux_write(mux, SENINF_MUX_CTRL, val | > > > + SENINF_MUX_CTRL_SENINF_IRQ_SW_RST | > > > + SENINF_MUX_CTRL_SENINF_MUX_SW_RST); -- Regards, Laurent Pinchart