Re: [PATCH -next v2 02/12] mtd: rawnand: arasan: Use helper function devm_clk_get_enabled()

Miquel Raynal
2023-08-18T08:13:00Z

miquel.raynal@bootlin.com wrote on Fri, 18 Aug 2023 10:10:04 +0200:

> Hi Li,
>
> lizetao1@huawei.com wrote on Fri, 18 Aug 2023 15:46:32 +0800:
>
> > Since commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared
> > and enabled clocks"), devm_clk_get() and clk_prepare_enable() can now be
>
> > replaced by devm_clk_get_enabled() when driver enable (and possibly
>
> For all the commit logs: the driver enables (and possibly prepares)
>
> > prepare) the clocks for the whole lifetime of the device. Moreover, it is
> > no longer necessary to unprepare and disable the clock explicitly, so drop
>
> For all the commit logs: the clocks
>
> The ",so drop the label xxx" is not needed I believe.
>
> > the label "disable_bus_clk" and "disable_controller_clk".

Actually it does not bother, just keep it.

> > Signed-off-by: Li Zetao <lizetao1@huawei.com>
> > ---
>
> Thanks,
> Miquèl

Thanks,
Miquèl