From: Moudy Ho <moudy.ho@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Moudy Ho" <moudy.ho@mediatek.com>
Subject: [PATCH v5 09/14] media: platform: mtk-mdp3: extend GCE event waiting in RDMA and WROT
Date: Tue, 12 Sep 2023 15:58:00 +0800 [thread overview]
Message-ID: <20230912075805.11432-10-moudy.ho@mediatek.com> (raw)
In-Reply-To: <20230912075805.11432-1-moudy.ho@mediatek.com>
Support for multiple RDMA/WROT waits for GCE events.
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
.../media/platform/mediatek/mdp3/mdp_cfg_data.c | 2 ++
.../platform/mediatek/mdp3/mtk-mdp3-comp.c | 17 +++++++++++------
.../platform/mediatek/mdp3/mtk-mdp3-core.h | 2 ++
3 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c b/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c
index 8eac09f9d3dd..b69fa0452612 100644
--- a/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c
+++ b/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c
@@ -56,8 +56,10 @@ static const struct mdp_platform_config mt8183_plat_cfg = {
.rdma_support_10bit = true,
.rdma_rsz1_sram_sharing = true,
.rdma_upsample_repeat_only = true,
+ .rdma_event_num = 1,
.rsz_disable_dcm_small_sample = false,
.wrot_filter_constraint = false,
+ .wrot_event_num = 1,
};
static const u32 mt8183_mutex_idx[MDP_MAX_COMP_COUNT] = {
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index 667933ea15f4..ec296d4fd0c5 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -251,14 +251,17 @@ static int config_rdma_subfrm(struct mdp_comp_ctx *ctx,
static int wait_rdma_event(struct mdp_comp_ctx *ctx, struct mdp_cmdq_cmd *cmd)
{
+ const struct mdp_platform_config *mdp_cfg = __get_plat_cfg(ctx);
struct device *dev = &ctx->comp->mdp_dev->pdev->dev;
phys_addr_t base = ctx->comp->reg_base;
u8 subsys_id = ctx->comp->subsys_id;
- if (ctx->comp->alias_id == 0)
+ if (ctx->comp->alias_id < mdp_cfg->rdma_event_num) {
MM_REG_WAIT(cmd, ctx->comp->gce_event[MDP_GCE_EVENT_EOF]);
- else
- dev_err(dev, "Do not support RDMA1_DONE event\n");
+ } else {
+ dev_err(dev, "Invalid RDMA event %d\n", ctx->comp->alias_id);
+ return -EINVAL;
+ }
/* Disable RDMA */
MM_REG_WRITE(cmd, subsys_id, base, MDP_RDMA_EN, 0x0, BIT(0));
@@ -553,10 +556,12 @@ static int wait_wrot_event(struct mdp_comp_ctx *ctx, struct mdp_cmdq_cmd *cmd)
phys_addr_t base = ctx->comp->reg_base;
u8 subsys_id = ctx->comp->subsys_id;
- if (ctx->comp->alias_id == 0)
+ if (ctx->comp->alias_id < mdp_cfg->wrot_event_num) {
MM_REG_WAIT(cmd, ctx->comp->gce_event[MDP_GCE_EVENT_EOF]);
- else
- dev_err(dev, "Do not support WROT1_DONE event\n");
+ } else {
+ dev_err(dev, "Invalid WROT event %d!\n", ctx->comp->alias_id);
+ return -EINVAL;
+ }
if (mdp_cfg && mdp_cfg->wrot_filter_constraint)
MM_REG_WRITE(cmd, subsys_id, base, VIDO_MAIN_BUF_SIZE, 0x0,
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h
index a063a655248c..b2a3e4b2ee1a 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h
@@ -39,8 +39,10 @@ struct mdp_platform_config {
bool rdma_support_10bit;
bool rdma_rsz1_sram_sharing;
bool rdma_upsample_repeat_only;
+ u32 rdma_event_num;
bool rsz_disable_dcm_small_sample;
bool wrot_filter_constraint;
+ u32 wrot_event_num;
};
/* indicate which mutex is used by each pipepline */
--
2.18.0
next prev parent reply other threads:[~2023-09-12 7:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 7:57 [PATCH v5 00/14] add support MDP3 on MT8195 platform Moudy Ho
2023-09-12 7:57 ` [PATCH v5 01/14] arm64: dts: mediatek: mt8183: correct MDP3 DMA-related nodes Moudy Ho
2023-09-12 7:57 ` [PATCH v5 02/14] arm64: dts: mediatek: mt8195: add MDP3 nodes Moudy Ho
2023-09-12 8:23 ` Krzysztof Kozlowski
2023-09-13 2:49 ` Moudy Ho (何宗原)
2023-09-12 7:57 ` [PATCH v5 03/14] media: platform: mtk-mdp3: add support second sets of MMSYS Moudy Ho
2023-09-12 9:18 ` AngeloGioacchino Del Regno
2023-09-13 9:19 ` Moudy Ho (何宗原)
2023-09-12 7:57 ` [PATCH v5 04/14] media: platform: mtk-mdp3: add support second sets of MUTEX Moudy Ho
2023-09-12 7:57 ` [PATCH v5 05/14] media: platform: mtk-mdp3: introduce more pipelines from MT8195 Moudy Ho
2023-09-12 7:57 ` [PATCH v5 06/14] media: platform: mtk-mdp3: introduce more MDP3 components Moudy Ho
2023-09-12 7:57 ` [PATCH v5 07/14] media: platform: mtk-mdp3: add checks for dummy components Moudy Ho
2023-09-12 7:57 ` [PATCH v5 08/14] media: platform: mtk-mdp3: avoid multiple driver registrations Moudy Ho
2023-09-12 7:58 ` Moudy Ho [this message]
2023-09-12 7:58 ` [PATCH v5 10/14] media: platform: mtk-mdp3: add support for blending multiple components Moudy Ho
2023-09-12 7:58 ` [PATCH v5 11/14] media: platform: mtk-mdp3: add mt8195 platform configuration Moudy Ho
2023-09-12 8:21 ` Krzysztof Kozlowski
2023-09-13 2:08 ` Moudy Ho (何宗原)
2023-09-13 6:39 ` Krzysztof Kozlowski
2023-09-12 7:58 ` [PATCH v5 12/14] media: platform: mtk-mdp3: add mt8195 shared memory configurations Moudy Ho
2023-09-12 7:58 ` [PATCH v5 13/14] media: platform: mtk-mdp3: add mt8195 MDP3 component settings Moudy Ho
2023-09-12 7:58 ` [PATCH v5 14/14] media: platform: mtk-mdp3: add support for parallel pipe to improve FPS Moudy Ho
2023-09-12 9:00 ` [PATCH v5 00/14] add support MDP3 on MT8195 platform AngeloGioacchino Del Regno
2023-09-12 9:37 ` Chen-Yu Tsai
2023-09-12 9:43 ` AngeloGioacchino Del Regno
2023-09-12 10:28 ` Chen-Yu Tsai
2023-09-12 10:44 ` Krzysztof Kozlowski
2023-09-15 10:16 ` Hans Verkuil
2023-09-15 10:27 ` Hans Verkuil
2023-09-19 6:43 ` Moudy Ho (何宗原)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912075805.11432-10-moudy.ho@mediatek.com \
--to=moudy.ho@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox