From: Moudy Ho <moudy.ho@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Moudy Ho" <moudy.ho@mediatek.com>
Subject: [PATCH v5 10/14] media: platform: mtk-mdp3: add support for blending multiple components
Date: Tue, 12 Sep 2023 15:58:01 +0800 [thread overview]
Message-ID: <20230912075805.11432-11-moudy.ho@mediatek.com> (raw)
In-Reply-To: <20230912075805.11432-1-moudy.ho@mediatek.com>
Certain chips can combine several components to form complex virtual
units with advanced functions.
These components require simultaneous configuration of their MODs and
clocks.
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
.../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 10 +++++++++-
.../platform/mediatek/mdp3/mtk-mdp3-comp.c | 20 ++++++++++++++++++-
.../platform/mediatek/mdp3/mtk-mdp3-comp.h | 7 +++++++
3 files changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
index 6204173ecc5d..9c2afd002e7c 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
@@ -117,17 +117,25 @@ static int mdp_path_subfrm_require(const struct mdp_path *path,
/* Set mutex mod */
for (index = 0; index < num_comp; index++) {
s32 inner_id = MDP_COMP_NONE;
+ const u32 *mutex_idx;
+ const struct mdp_comp_blend *b;
if (CFG_CHECK(MT8183, p_id))
inner_id = CFG_GET(MT8183, path->config, components[index].type);
if (mdp_cfg_comp_is_dummy(path->mdp_dev, inner_id))
continue;
+
ctx = &path->comps[index];
if (is_output_disabled(p_id, ctx->param, count))
continue;
+
+ mutex_idx = data->mdp_mutex_table_idx;
id = ctx->comp->public_id;
- mtk_mutex_write_mod(mutex, data->mdp_mutex_table_idx[id], false);
+ mtk_mutex_write_mod(mutex, mutex_idx[id], false);
+ b = &data->comp_data[id].blend;
+ if (b && b->aid_mod)
+ mtk_mutex_write_mod(mutex, mutex_idx[b->b_id], false);
}
mtk_mutex_write_sof(mutex, MUTEX_SOF_IDX_SINGLE_MODE);
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
index ec296d4fd0c5..bb21fa2f5c3b 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c
@@ -858,9 +858,19 @@ int mdp_comp_clocks_on(struct device *dev, struct mdp_comp *comps, int num)
int i, ret;
for (i = 0; i < num; i++) {
+ struct mdp_dev *mdp_dev = comps[i].mdp_dev;
+ enum mtk_mdp_comp_id id = comps[i].public_id;
+ const struct mdp_comp_blend *b = &mdp_dev->mdp_data->comp_data[id].blend;
+
ret = mdp_comp_clock_on(dev, &comps[i]);
if (ret)
return ret;
+
+ if (b && b->aid_clk) {
+ ret = mdp_comp_clock_on(dev, mdp_dev->comp[id]);
+ if (ret)
+ return ret;
+ }
}
return 0;
@@ -870,8 +880,16 @@ void mdp_comp_clocks_off(struct device *dev, struct mdp_comp *comps, int num)
{
int i;
- for (i = 0; i < num; i++)
+ for (i = 0; i < num; i++) {
+ struct mdp_dev *mdp_dev = comps[i].mdp_dev;
+ enum mtk_mdp_comp_id id = comps[i].public_id;
+ const struct mdp_comp_blend *b = &mdp_dev->mdp_data->comp_data[id].blend;
+
mdp_comp_clock_off(dev, &comps[i]);
+
+ if (b && b->aid_clk)
+ mdp_comp_clock_off(dev, mdp_dev->comp[id]);
+ }
}
static int mdp_get_subsys_id(struct mdp_dev *mdp, struct device *dev,
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h
index 09e46dfe4f02..e31e1f088b32 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.h
@@ -201,9 +201,16 @@ struct mdp_comp_info {
u32 dts_reg_ofst;
};
+struct mdp_comp_blend {
+ enum mtk_mdp_comp_id b_id;
+ bool aid_mod;
+ bool aid_clk;
+};
+
struct mdp_comp_data {
struct mdp_comp_match match;
struct mdp_comp_info info;
+ struct mdp_comp_blend blend;
};
struct mdp_comp_ops;
--
2.18.0
next prev parent reply other threads:[~2023-09-12 7:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 7:57 [PATCH v5 00/14] add support MDP3 on MT8195 platform Moudy Ho
2023-09-12 7:57 ` [PATCH v5 01/14] arm64: dts: mediatek: mt8183: correct MDP3 DMA-related nodes Moudy Ho
2023-09-12 7:57 ` [PATCH v5 02/14] arm64: dts: mediatek: mt8195: add MDP3 nodes Moudy Ho
2023-09-12 8:23 ` Krzysztof Kozlowski
2023-09-13 2:49 ` Moudy Ho (何宗原)
2023-09-12 7:57 ` [PATCH v5 03/14] media: platform: mtk-mdp3: add support second sets of MMSYS Moudy Ho
2023-09-12 9:18 ` AngeloGioacchino Del Regno
2023-09-13 9:19 ` Moudy Ho (何宗原)
2023-09-12 7:57 ` [PATCH v5 04/14] media: platform: mtk-mdp3: add support second sets of MUTEX Moudy Ho
2023-09-12 7:57 ` [PATCH v5 05/14] media: platform: mtk-mdp3: introduce more pipelines from MT8195 Moudy Ho
2023-09-12 7:57 ` [PATCH v5 06/14] media: platform: mtk-mdp3: introduce more MDP3 components Moudy Ho
2023-09-12 7:57 ` [PATCH v5 07/14] media: platform: mtk-mdp3: add checks for dummy components Moudy Ho
2023-09-12 7:57 ` [PATCH v5 08/14] media: platform: mtk-mdp3: avoid multiple driver registrations Moudy Ho
2023-09-12 7:58 ` [PATCH v5 09/14] media: platform: mtk-mdp3: extend GCE event waiting in RDMA and WROT Moudy Ho
2023-09-12 7:58 ` Moudy Ho [this message]
2023-09-12 7:58 ` [PATCH v5 11/14] media: platform: mtk-mdp3: add mt8195 platform configuration Moudy Ho
2023-09-12 8:21 ` Krzysztof Kozlowski
2023-09-13 2:08 ` Moudy Ho (何宗原)
2023-09-13 6:39 ` Krzysztof Kozlowski
2023-09-12 7:58 ` [PATCH v5 12/14] media: platform: mtk-mdp3: add mt8195 shared memory configurations Moudy Ho
2023-09-12 7:58 ` [PATCH v5 13/14] media: platform: mtk-mdp3: add mt8195 MDP3 component settings Moudy Ho
2023-09-12 7:58 ` [PATCH v5 14/14] media: platform: mtk-mdp3: add support for parallel pipe to improve FPS Moudy Ho
2023-09-12 9:00 ` [PATCH v5 00/14] add support MDP3 on MT8195 platform AngeloGioacchino Del Regno
2023-09-12 9:37 ` Chen-Yu Tsai
2023-09-12 9:43 ` AngeloGioacchino Del Regno
2023-09-12 10:28 ` Chen-Yu Tsai
2023-09-12 10:44 ` Krzysztof Kozlowski
2023-09-15 10:16 ` Hans Verkuil
2023-09-15 10:27 ` Hans Verkuil
2023-09-19 6:43 ` Moudy Ho (何宗原)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912075805.11432-11-moudy.ho@mediatek.com \
--to=moudy.ho@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox