From: Moudy Ho <moudy.ho@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
<dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
"Moudy Ho" <moudy.ho@mediatek.com>
Subject: [PATCH v5 08/14] media: platform: mtk-mdp3: avoid multiple driver registrations
Date: Tue, 12 Sep 2023 15:57:59 +0800 [thread overview]
Message-ID: <20230912075805.11432-9-moudy.ho@mediatek.com> (raw)
In-Reply-To: <20230912075805.11432-1-moudy.ho@mediatek.com>
The amount of MDP3 driver probes is determined by the registered
clocks of MMSYS.
Since MT8195 MDP3 utilizes VPPSYS0 and VPPSYS1, it's necessary to
prevent multiple driver registrations.
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
---
drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c | 1 +
drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 8 ++++++++
drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h | 1 +
3 files changed, 10 insertions(+)
diff --git a/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c b/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c
index b7efdafb1620..8eac09f9d3dd 100644
--- a/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c
+++ b/drivers/media/platform/mediatek/mdp3/mdp_cfg_data.c
@@ -410,6 +410,7 @@ static const struct mdp_pipe_info mt8183_pipe_info[] = {
const struct mtk_mdp_driver_data mt8183_mdp_driver_data = {
.mdp_plat_id = MT8183,
+ .mdp_con_res = 0x14001000,
.mdp_probe_infra = mt8183_mdp_probe_infra,
.mdp_cfg = &mt8183_plat_cfg,
.mdp_mutex_table_idx = mt8183_mutex_idx,
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
index 239f496b7a30..06b7d2b0b814 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
@@ -161,6 +161,7 @@ static int mdp_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct mdp_dev *mdp;
struct platform_device *mm_pdev, *mm2_pdev;
+ struct resource *res;
int ret, i, mutex_id;
mdp = kzalloc(sizeof(*mdp), GFP_KERNEL);
@@ -172,6 +173,12 @@ static int mdp_probe(struct platform_device *pdev)
mdp->pdev = pdev;
mdp->mdp_data = of_device_get_match_data(&pdev->dev);
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (res->start != mdp->mdp_data->mdp_con_res) {
+ platform_set_drvdata(pdev, mdp);
+ goto success_return;
+ }
+
mm_pdev = __get_pdev_by_id(pdev, NULL, MDP_INFRA_MMSYS);
if (IS_ERR_OR_NULL(mm_pdev)) {
ret = -ENODEV;
@@ -279,6 +286,7 @@ static int mdp_probe(struct platform_device *pdev)
goto err_unregister_device;
}
+success_return:
dev_dbg(dev, "mdp-%d registered successfully\n", pdev->id);
return 0;
diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h
index e4ffa25b9271..a063a655248c 100644
--- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h
+++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h
@@ -61,6 +61,7 @@ enum mdp_pipe_id {
struct mtk_mdp_driver_data {
const int mdp_plat_id;
+ const resource_size_t mdp_con_res;
const struct of_device_id *mdp_probe_infra;
const struct mdp_platform_config *mdp_cfg;
const u32 *mdp_mutex_table_idx;
--
2.18.0
next prev parent reply other threads:[~2023-09-12 7:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 7:57 [PATCH v5 00/14] add support MDP3 on MT8195 platform Moudy Ho
2023-09-12 7:57 ` [PATCH v5 01/14] arm64: dts: mediatek: mt8183: correct MDP3 DMA-related nodes Moudy Ho
2023-09-12 7:57 ` [PATCH v5 02/14] arm64: dts: mediatek: mt8195: add MDP3 nodes Moudy Ho
2023-09-12 8:23 ` Krzysztof Kozlowski
2023-09-13 2:49 ` Moudy Ho (何宗原)
2023-09-12 7:57 ` [PATCH v5 03/14] media: platform: mtk-mdp3: add support second sets of MMSYS Moudy Ho
2023-09-12 9:18 ` AngeloGioacchino Del Regno
2023-09-13 9:19 ` Moudy Ho (何宗原)
2023-09-12 7:57 ` [PATCH v5 04/14] media: platform: mtk-mdp3: add support second sets of MUTEX Moudy Ho
2023-09-12 7:57 ` [PATCH v5 05/14] media: platform: mtk-mdp3: introduce more pipelines from MT8195 Moudy Ho
2023-09-12 7:57 ` [PATCH v5 06/14] media: platform: mtk-mdp3: introduce more MDP3 components Moudy Ho
2023-09-12 7:57 ` [PATCH v5 07/14] media: platform: mtk-mdp3: add checks for dummy components Moudy Ho
2023-09-12 7:57 ` Moudy Ho [this message]
2023-09-12 7:58 ` [PATCH v5 09/14] media: platform: mtk-mdp3: extend GCE event waiting in RDMA and WROT Moudy Ho
2023-09-12 7:58 ` [PATCH v5 10/14] media: platform: mtk-mdp3: add support for blending multiple components Moudy Ho
2023-09-12 7:58 ` [PATCH v5 11/14] media: platform: mtk-mdp3: add mt8195 platform configuration Moudy Ho
2023-09-12 8:21 ` Krzysztof Kozlowski
2023-09-13 2:08 ` Moudy Ho (何宗原)
2023-09-13 6:39 ` Krzysztof Kozlowski
2023-09-12 7:58 ` [PATCH v5 12/14] media: platform: mtk-mdp3: add mt8195 shared memory configurations Moudy Ho
2023-09-12 7:58 ` [PATCH v5 13/14] media: platform: mtk-mdp3: add mt8195 MDP3 component settings Moudy Ho
2023-09-12 7:58 ` [PATCH v5 14/14] media: platform: mtk-mdp3: add support for parallel pipe to improve FPS Moudy Ho
2023-09-12 9:00 ` [PATCH v5 00/14] add support MDP3 on MT8195 platform AngeloGioacchino Del Regno
2023-09-12 9:37 ` Chen-Yu Tsai
2023-09-12 9:43 ` AngeloGioacchino Del Regno
2023-09-12 10:28 ` Chen-Yu Tsai
2023-09-12 10:44 ` Krzysztof Kozlowski
2023-09-15 10:16 ` Hans Verkuil
2023-09-15 10:27 ` Hans Verkuil
2023-09-19 6:43 ` Moudy Ho (何宗原)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230912075805.11432-9-moudy.ho@mediatek.com \
--to=moudy.ho@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox