From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18058C25B48 for ; Thu, 26 Oct 2023 22:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BZVyVYzi+6QbDuBCDPXiv+7wbOfcRmZKqyElOZWrfZc=; b=Q1HGTsR/U2P7HUVBxbbpVRVbem WOqgY+dCcmlvJOsDuhWqysySGWIw+13Gr1UxmscuvxJNkg/4iPJ1iV/8XBvvywukDFfiJRvmcIujI Lppkv1vqnTng9EqbcQVMUY8K4SyGj4wuIxeKMrHEqN827Y1pdyptQJRLo0Zh5Gith93dHtf2L0fxu XynWsLmxjZQGilAUtgzfeD3Cj7yJWlJJTEJ4x3TlRQNOwl0wr+fetIilUzpKPtSwuVhR0YhpNzYjG kZd+Zk0ZK7AHdROxC7M+Oz8GWhMrzHjnc/tVJ2gD+UbivO1Km5gMHM1ts4iu2J5GVJ2RJn2V9jKgj 8doHyjfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qw8j1-00FFCo-0R; Thu, 26 Oct 2023 22:21:11 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qw8ix-00FFCH-2a; Thu, 26 Oct 2023 22:21:09 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40859c466efso11025455e9.3; Thu, 26 Oct 2023 15:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698358866; x=1698963666; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=BZVyVYzi+6QbDuBCDPXiv+7wbOfcRmZKqyElOZWrfZc=; b=JXeIfREWXh8a+UinDBw0DN527ZVpA60qZA55esLzpW12XX5HFkBUcxSm4bApbGkFqg KX/7mwm/L2xzmIqNglKGqHGOFtgg9gTgljCpYn9v+rO8OcyuwubjeF6cPV5eK32+KCYN dAlpRExLZbD9OB8FxAPDGs/qJ86lQBaI1ePTWN8iW7q02ExjsG3lHcLQb14BJRkSPwnk 6JRdu4FZ3z/dwmcIJEp1rNwcto6hv8kNfNk/D2LAd5imRrT2dgmF8KlJpyTPZbNUW8bE 1Apeki/xK8cca27bKtQN0q3at4THReJtUPixkdGSM8CTW2uJ3YGS4MwNGpDmnDKemzu9 c3TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698358866; x=1698963666; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BZVyVYzi+6QbDuBCDPXiv+7wbOfcRmZKqyElOZWrfZc=; b=FqGMGYn+G70fy2xdWKDsnDZ8S99NTT4JnJd+nOWK5KqO53qBzqjqOW5lV/DGeU3Xzq 8mRKKmivgRgV77ZpZ7BA9c8H2ixZsAIJY+R80ZjMR1cXFcPiF6Mqi43JnBrXc505AJ4P tQcuU6oQ3O5e6RPIuoP61GCKrOcs4CToVg1zTR0riSLqbMGHNr7zmuRxiVBbpQvnAaYx ekDks7IjqQjV0oJLSAbz2mLct5G8Q1sFZX+s89xnUu5sSRd05/ASlrPDjaHmDh/hqkeJ 6bBteCqiLXB+mWLC1SW8Ekht+Me+XwKLxSRXr9uiF4VEZ7Td39jEi69UvyFz5PAc2Ubg l9hQ== X-Gm-Message-State: AOJu0Yy2mfLSMZZI4qMaMhDwBVAkajubThCFAD9z3jsfGSXCaW66hxxJ F45y51tVHrYJ/1SdFlLlX3Y= X-Google-Smtp-Source: AGHT+IEKimHb5xke6jH18TsHWKRxjcjGmlx0/kFhipt1/3/BG8Q2ivqVE2EsAdNFToNo9uL7wPtB6A== X-Received: by 2002:a05:600c:3c9a:b0:409:1d9a:1dec with SMTP id bg26-20020a05600c3c9a00b004091d9a1decmr908421wmb.35.1698358866086; Thu, 26 Oct 2023 15:21:06 -0700 (PDT) Received: from skbuf ([188.26.57.160]) by smtp.gmail.com with ESMTPSA id hg10-20020a05600c538a00b0040775fd5bf9sm148982wmb.0.2023.10.26.15.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 15:21:05 -0700 (PDT) Date: Fri, 27 Oct 2023 01:21:00 +0300 From: Vladimir Oltean To: Justin Stitt Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Rasesh Mody , Sudarsana Kalluru , GR-Linux-NIC-Dev@marvell.com, Dimitris Michailidis , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Louis Peens , Shannon Nelson , Brett Creeley , drivers@pensando.io, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Ronak Doshi , VMware PV-Drivers Reviewers , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Hauke Mehrtens , Andrew Lunn , Florian Fainelli , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Linus Walleij , Alvin =?utf-8?Q?=C5=A0ipraga?= , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Jiawen Wu , Mengyuan Lou , Heiner Kallweit , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Nick Desaulniers , Nathan Chancellor , Kees Cook , intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com, linux-hyperv@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH next v2 1/3] ethtool: Implement ethtool_puts() Message-ID: <20231026222100.yrjsdlq47djaurjf@skbuf> References: <20231026-ethtool_puts_impl-v2-0-0d67cbdd0538@google.com> <20231026-ethtool_puts_impl-v2-1-0d67cbdd0538@google.com> <20231026220248.blgf7kgt5fkkbg7f@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_152107_862014_6DBCFE5B X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Oct 26, 2023 at 03:11:28PM -0700, Justin Stitt wrote: > On Thu, Oct 26, 2023 at 3:09 PM Justin Stitt wrote: > > On Thu, Oct 26, 2023 at 3:02 PM Vladimir Oltean wrote: > > > Maybe this is due to an incorrect rebase conflict resolution, but you > > > shouldn't have touched any of the ethtool force speed maps. > > > > Ah, I did have a conflict and resolved by simply moving the hunks > > out of each other's way. Trivial resolution. > > > > Should I undo this? I want my patch against next since it's targeting > > some stuff in-flight over there. BUT, I also want ethtool_puts() to be > > directly below ethtool_sprintf() in the source code. What to do? > > Oh, I just realized my auto formatter had a field day with that function. > I will rectify this in a new version after waiting 24hrs for comments to > trickle in as well. Nothing other than ethtool_puts() should appear in the patch delta. pw-bot: cr