From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53ED6C4332F for ; Thu, 2 Nov 2023 05:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:CC:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rlsif4ZFTca+eY2ZA2T8CDailYwP0BK2oKzGYMrtj/o=; b=umHImXODAanRYr2ZVmOETfuwTa 39Rl/MYn0OHk2FgdmmGEzK7pNvpUAPgbAilVkShCa1ss79fiFAdGnxOJd4tuD9GDcjEI8tPnofLKr fcJXG76jC4rTLHlJC4WdBESGcWt+l7V8CfAdWs4SyEA/u5oN7gBl6n03ek312J3SS/3oIpnpR5B07 VVV0RdPMsgRwFMo6Wu3Lxxvvf7ZG7VycmpSeiisNhkQKZvUZVthJecjKk04N9XxprzhGZrF6Rg7ko 4Sw3T5c4bfxKZJdR0yAxdqHvt9SS1Tb7NUJjx2emDPJnetPL4FvJdyPjBliSYt4RLmLtJMNirIYgN SM6ibj9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyQE4-008l36-0e; Thu, 02 Nov 2023 05:26:40 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyQDz-008l0u-1X; Thu, 02 Nov 2023 05:26:39 +0000 X-UUID: 6225a222794011ee86758d4a7c00f3a0-20231101 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=rlsif4ZFTca+eY2ZA2T8CDailYwP0BK2oKzGYMrtj/o=; b=BFvcSfqFYIzavPXUJ+5MjrGZ4Nwh+0rDZOz1kbaoLZQ3Q2TDgR6y2Aux4ZGYP+oDu2QwsPS1FgGfOKJy+ZkhOH16cyyJhd+gKzfRmzhHqW8+qMRiWvtzF9TXpmAug/WLS6hElxpwLAgdxN15DTTVbHF3Z7WvgZwIlg5ej/BQWEc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:e6603337-e878-433f-922d-63745d821c6e,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:364b77b,CLOUDID:83eb965f-c89d-4129-91cb-8ebfae4653fc,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 6225a222794011ee86758d4a7c00f3a0-20231101 Received: from mtkmbs14n1.mediatek.inc [(172.21.101.75)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 35352567; Wed, 01 Nov 2023 22:26:32 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 2 Nov 2023 13:26:06 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 2 Nov 2023 13:26:06 +0800 From: To: , , , , Alim Akhtar , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , AngeloGioacchino Del Regno , Manivannan Sadhasivam , Asutosh Das , Can Guo CC: , , , , , , , , Subject: [PATCH v3 1/1] ufs: core: Expand MCQ queue slot to DeviceQueueDepth + 1 Date: Thu, 2 Nov 2023 13:24:24 +0800 Message-ID: <20231102052426.12006-2-naomi.chu@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20231102052426.12006-1-naomi.chu@mediatek.com> References: <20231102052426.12006-1-naomi.chu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--0.972200-8.000000 X-TMASE-MatchedRID: zfURmU8ZpfFehll0JtAbYS1Hx9UxMGjdP2/oiZRTnW/nD8OB/Tc9os7P jWXN0Yiv0UKtSUr3c5JNLy5V2gDccNkPtqv8VrRJ7spMO3HwKCBCX8V1FiRRktVTZaI6TuNo4nP T8jZv1NHi8zVgXoAltsIJ+4gwXrEtWBd6ltyXuvu54yg6atPTl9jC2YE+B5qM7bPFPqc46vfpvj PU/kx5iJ5Hk4JddbJQC1BC+x/F4/rZtHw34RTA7rmywIZuCO7ltYzBRJiBZNuAhOcaQrQ0U1GyR coeF18qmKP0zzpTAeGwod8xOMKmvMCBO+zxAW5pftwZ3X11IV0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--0.972200-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: C9DCDF7A4917A6AB6CA69165C494FC7E94109658CA567B084E43FB4D3418AD782000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231101_222635_524013_8107CA55 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Naomi Chu The UFSHCI 4.0 specification mandates that there should always be at least one empty slot in each queue for distinguishing between full and empty states. Enlarge the `hwq->max_entries` to `DeviceQueueDepth +1` to allow UFSHCI 4.0 controllers to fully utilize MCQ queue slots. Fixes: 4682abfae2eb ("scsi: ufs: core: mcq: Allocate memory for MCQ mode") Signed-off-by: Naomi Chu --- drivers/ufs/core/ufs-mcq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c index 2ba8ec254dce..5c75ab9d6bb5 100644 --- a/drivers/ufs/core/ufs-mcq.c +++ b/drivers/ufs/core/ufs-mcq.c @@ -436,7 +436,7 @@ int ufshcd_mcq_init(struct ufs_hba *hba) for (i = 0; i < hba->nr_hw_queues; i++) { hwq = &hba->uhq[i]; - hwq->max_entries = hba->nutrs; + hwq->max_entries = hba->nutrs + 1; spin_lock_init(&hwq->sq_lock); spin_lock_init(&hwq->cq_lock); mutex_init(&hwq->sq_mutex); -- 2.18.0