Re: [PATCH v2 1/2] dt-bindings: arm64: mediatek: add Kontron 3.5"-SBC-i1200

Michael Walle
2024-02-19T09:36:53Z

[-- Attachment #1: Type: text/plain, Size: 2234 bytes --]

On Mon Feb 19, 2024 at 10:23 AM CET, AngeloGioacchino Del Regno wrote:
> Il 19/02/24 09:44, Michael Walle ha scritto:
> > Add the compatible string for the Kontron 3.5"-SBC-i1200 single board
> > computer.
> >
> > Signed-off-by: Michael Walle <mwalle@kernel.org>
> > ---
> > v2:
> > - convert enum to const as there is only one specific board
> >
> > Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index 09f9ffd3ff7b..add167d8b8da 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -357,6 +357,11 @@ properties:
> > - radxa,nio-12l
> > - const: mediatek,mt8395
> > - const: mediatek,mt8195
> > + - description: Kontron 3.5"-SBC-i1200
> > + items:
> > + - const: kontron,3-5-sbc-i1200
> > + - const: mediatek,mt8395
> > + - const: mediatek,mt8195
> > - items:
> > - enum:
> > - mediatek,mt8516-pumpkin
>
> I understand that you took inspiration from the Google Chromebooks entries, but
> those are separated only because they've got "a bunch of revisions".
>

I don't really care about the description. It's just the way I've
done it in the past. And in this file, there is also google,burnet,
google,cozmo, google,damu, without any further revs.

> For machines that don't have a billion compatible strings, I would suggest to
> add the compatible under a single big entry: like this, the binding is (imo) a
> bit more readable .. and cleaner.
>
> Eventually, the machine name is in the devicetree so we're not losing any kind
> of information anyway... :-)
>
> - items:
> - enum:
> - kontron,3-5-sbc-i1200
> - mediatek,mt8395-evk
> - radxa,nio-12l
> - const: mediatek,mt8395
> - const: mediatek,mt8195

Ack. I'll give you some time to look at the actual DTS before
posting a new version.

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 252 bytes --]