Re: [PATCH 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

Krzysztof Kozlowski
2024-02-28T12:09:22Z

On 28/02/2024 11:25, AngeloGioacchino Del Regno wrote:
> Il 28/02/24 10:57, Alexandre Mergnat ha scritto:
>> I think I got it.
>>
>> - mediatek,i2s-shared-clock: will be remove from DT
>> - mediatek,dmic-iir-on: will be remove from DT
>> - mediatek,dmic-irr-mode: will be remove from DT
>> - mediatek,dmic-two-wire-mode: rephrase description needed
>>
>> I've did abstraction (despite me) that IIR settings are runtime config because the
>> driver implement its usage like a one-time-setup -_-'
>>
>
> Yes but just one more thing I just noticed: `mediatek,dmic-two-wire-mode` - can we
> please rename this to `mediatek,dmic-mode` ?
>
> That'd be for consistency check mt6359.yaml and mt6358.txt
>
> mediatek,dmic-mode:
> $ref: /schemas/types.yaml#/definitions/uint32
> description: |
> Indicates how many data pins are used to transmit two channels of PDM
> signal. 0 means two wires, 1 means one wire. Default value is 0.
> enum:
> - 0 # one wire
> - 1 # two wires

Thanks for checking. Now I wonder if entire binding just ignored
existing work and started doing things from scratch...

Best regards,
Krzysztof