From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C13DC4345F for ; Wed, 1 May 2024 17:07:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5UtxZqXH0BeyQTwJfcWgL8YkMU5EaeZPIDlc8+WEKqw=; b=XKKar4O3Sz+Ge2LNQu1+gbLW7f /RlB0LkWVgsJLx1CgaQagwSYV62IhEuKBiF4p5MEhMwQGAc6HDQz4bwHIf+OKc7zmi6Ro1PAtUcjr kqGhl8rNM7LNPhz/CZxIEFbIz0ocKsK/eM6GyRgg4Dhg6I1k52K38/Ne5biLq/A/cVI1fZREQal7J kO6ZeLFVEBiU3UUQTxkdgBCQgn/F+2aS4kPU4YgNRxlxAT9QB323C39wxpYJCcsfWlubtuYA+2z4/ WU0W9Pbh0tJCmw7vdfZIYcd7czjD2MWJX96974Q3fSxV0xKH3mVP7CkT8q4DaV04gA/CAvePPzcVj MysNTmIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2DR0-0000000AGdD-2mg3; Wed, 01 May 2024 17:07:58 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2DQx-0000000AGbK-04wt; Wed, 01 May 2024 17:07:56 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 5A672CE1375; Wed, 1 May 2024 17:07:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E807C072AA; Wed, 1 May 2024 17:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714583269; bh=8/png6sxsqEGBRMcXp6Bjwq65G0P803V71/0WDXSe9Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U5EPMXKHlB4SDJriFUqz44y53RD4A4LCX3HHMjR9aPglBpE3/T1/QFAGTBfxIriFc HT57GzvsDFFNwRYNYrnW+qhDr4Lz+BfijWMLpYbTNW8uWKmh1znJO6KrQ95ZpNt+nU fQDZ0mybKZitIuvm8e+6qPLfF/04nfjKc3DSNokViAZ2ZVkBQcoyeeESvdQNqF8qTO ONaG2w9eamgRMad9Yfq8gKpcqDHexNAD7vpi29kk0fL2/B5mJxnweXjJUjBBSbRUyr KwYrB7CX1coBz497nT2Wf6OA1ScS/hbd2upZXmN2yCjj4VIg3VVM9dlrC0+KPPSh7h RRKngkClwAnWA== Date: Wed, 1 May 2024 18:07:44 +0100 From: Conor Dooley To: Daniel Golle Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lorenzo Bianconi , Felix Fietkau , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes Message-ID: <20240501-prorate-hanky-5fbb9ff28bc5@spud> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iA7tPiIVLweNoVjq" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_100755_507351_B9EEE99A X-CRM114-Status: GOOD ( 21.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --iA7tPiIVLweNoVjq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 30, 2024 at 10:53:55PM +0100, Daniel Golle wrote: > Several clocks as well as both sgmiisys phandles were added by mistake > to the Ethernet bindings for MT7988. >=20 > This happened because the vendor driver which served as a reference uses > a high number of syscon phandles to access various parts of the SoC > which wasn't acceptable upstream. Hence several parts which have never > previously been supported (such SerDes PHY and USXGMII PCS) are going to > be implemented by separate drivers. As a result the device tree will > look much more sane. >=20 > Quickly align the bindings with the upcoming reality of the drivers > actually adding support for the remaining Ethernet-related features of > the MT7988 SoC. >=20 > Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth bind= ing") > Signed-off-by: Daniel Golle > --- > .../devicetree/bindings/net/mediatek,net.yaml | 32 ++++--------------- > 1 file changed, 7 insertions(+), 25 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Do= cumentation/devicetree/bindings/net/mediatek,net.yaml > index e74502a0afe8..030d106bc7d3 100644 > --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml > +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml > @@ -337,32 +337,23 @@ allOf: > minItems: 4 > =20 > clocks: > - minItems: 34 > - maxItems: 34 > + minItems: 24 > + maxItems: 24 > =20 > clock-names: > items: > - - const: crypto > + - const: xgp1 > + - const: xgp2 > + - const: xgp3 Why is the ordering changing too? > - const: fe > - const: gp2 > - const: gp1 > - const: gp3 > + - const: esw > + - const: crypto > - const: ethwarp_wocpu2 > - const: ethwarp_wocpu1 > - const: ethwarp_wocpu0 > - - const: esw > - - const: netsys0 > - - const: netsys1 > - - const: sgmii_tx250m > - - const: sgmii_rx250m > - - const: sgmii2_tx250m > - - const: sgmii2_rx250m > - - const: top_usxgmii0_sel > - - const: top_usxgmii1_sel > - - const: top_sgm0_sel > - - const: top_sgm1_sel > - - const: top_xfi_phy0_xtal_sel > - - const: top_xfi_phy1_xtal_sel > - const: top_eth_gmii_sel > - const: top_eth_refck_50m_sel > - const: top_eth_sys_200m_sel > @@ -375,15 +366,6 @@ allOf: > - const: top_netsys_sync_250m_sel > - const: top_netsys_ppefb_250m_sel > - const: top_netsys_warp_sel > - - const: wocpu1 > - - const: wocpu0 > - - const: xgp1 > - - const: xgp2 > - - const: xgp3 > - > - mediatek,sgmiisys: > - minItems: 2 > - maxItems: 2 > =20 > patternProperties: > "^mac@[0-1]$": > --=20 > 2.44.0 >=20 --iA7tPiIVLweNoVjq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZjJ23wAKCRB4tDGHoIJi 0jQoAQCrI827zGT9l/GNCLHhBDxuB2DyQ+FKu0l+4FvZTur7ZwEA3BOvbyZ4jXdL DGa1XxfE8CunnKNn9b20At6jUlGZwwk= =dQTZ -----END PGP SIGNATURE----- --iA7tPiIVLweNoVjq--