From: Yunfei Dong <yunfei.dong@mediatek.com>
To: "Jeffrey Kardatzke" <jkardatzke@google.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Nathan Hebert" <nhebert@chromium.org>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Sebastian Fricke" <sebastian.fricke@collabora.com>,
"Tomasz Figa" <tfiga@chromium.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Cc: "Chen-Yu Tsai" <wenst@chromium.org>,
"Yong Wu" <yong.wu@mediatek.com>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
"Fritz Koenig" <frkoenig@chromium.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Steve Cho" <stevecho@chromium.org>,
"Yunfei Dong" <yunfei.dong@mediatek.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Brian Starkey" <Brian.Starkey@arm.com>,
"John Stultz" <jstultz@google.com>,
"T . J . Mercier" <tjmercier@google.com>,
"Christian König" <christian.koenig@amd.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: [PATCH v6,23/24] media: mediatek: vcodec: support av1 svp decoder for mt8188
Date: Thu, 16 May 2024 20:21:01 +0800 [thread overview]
Message-ID: <20240516122102.16379-24-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20240516122102.16379-1-yunfei.dong@mediatek.com>
From: Xiaoyong Lu <xiaoyong.lu@mediatek.com>
Change av1 driver to support secure video playback(svp) for
mt8188. Need to map shared memory with optee interface and
wait interrupt in optee-os.
Signed-off-by: Xiaoyong Lu <xiaoyong.lu@mediatek.com>
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
.../vcodec/decoder/vdec/vdec_av1_req_lat_if.c | 97 ++++++++++++-------
1 file changed, 63 insertions(+), 34 deletions(-)
diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
index bf21f2467a0f..a3ad35df7f73 100644
--- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
+++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_av1_req_lat_if.c
@@ -58,6 +58,9 @@
#define SEG_LVL_ALT_Q 0
#define SECONDARY_FILTER_STRENGTH_NUM_BITS 2
+#define AV1_IQ_TABLE_SIZE 0x12200
+#define AV1_CDF_TABLE_SIZE 0xFE80
+
static const short div_lut[DIV_LUT_NUM + 1] = {
16384, 16320, 16257, 16194, 16132, 16070, 16009, 15948, 15888, 15828, 15768,
15709, 15650, 15592, 15534, 15477, 15420, 15364, 15308, 15252, 15197, 15142,
@@ -641,6 +644,8 @@ struct vdec_av1_slice_fb {
* @frame: current frame info
* @state: status after decode done
* @cur_lst_tile_id: tile id for large scale
+ * @tile_group: tile group info
+ * @reservd: reserved
*/
struct vdec_av1_slice_vsi {
/* lat */
@@ -665,6 +670,8 @@ struct vdec_av1_slice_vsi {
struct vdec_av1_slice_frame frame;
struct vdec_av1_slice_state state;
u32 cur_lst_tile_id;
+ struct vdec_av1_slice_tile_group tile_group;
+ unsigned int reservd[4];
};
/**
@@ -692,7 +699,6 @@ struct vdec_av1_slice_pfc {
* @cdf_temp: cdf temp buffer
* @tile: tile buffer
* @slots: slots info
- * @tile_group: tile_group entry
* @level: level of current resolution
* @width: width of last picture
* @height: height of last picture
@@ -717,7 +723,6 @@ struct vdec_av1_slice_instance {
struct mtk_vcodec_mem cdf_temp;
struct mtk_vcodec_mem tile;
struct vdec_av1_slice_slot slots;
- struct vdec_av1_slice_tile_group tile_group;
/* for resolution change and get_pic_info */
enum vdec_av1_slice_resolution_level level;
@@ -774,24 +779,28 @@ static int vdec_av1_slice_init_cdf_table(struct vdec_av1_slice_instance *instanc
ctx = instance->ctx;
vsi = instance->vpu.vsi;
- remote_cdf_table = mtk_vcodec_fw_map_dm_addr(ctx->dev->fw_handler,
- (u32)vsi->cdf_table_addr);
- if (IS_ERR(remote_cdf_table)) {
- mtk_vdec_err(ctx, "failed to map cdf table\n");
- return PTR_ERR(remote_cdf_table);
- }
-
- mtk_vdec_debug(ctx, "map cdf table to 0x%p\n", remote_cdf_table);
if (instance->cdf_table.va)
mtk_vcodec_mem_free(ctx, &instance->cdf_table);
+ vsi->cdf_table_size = AV1_CDF_TABLE_SIZE;
+ mtk_vdec_debug(ctx, "svp %d. cdf table size 0x%x\n",
+ instance->ctx->is_secure_playback, vsi->cdf_table_size);
instance->cdf_table.size = vsi->cdf_table_size;
ret = mtk_vcodec_mem_alloc(ctx, &instance->cdf_table);
if (ret)
return ret;
- memcpy(instance->cdf_table.va, remote_cdf_table, vsi->cdf_table_size);
+ if (!instance->ctx->is_secure_playback) {
+ remote_cdf_table = mtk_vcodec_fw_map_dm_addr(ctx->dev->fw_handler,
+ (u32)vsi->cdf_table_addr);
+ if (IS_ERR(remote_cdf_table)) {
+ mtk_vdec_err(ctx, "failed to map cdf table\n");
+ return PTR_ERR(remote_cdf_table);
+ }
+
+ memcpy(instance->cdf_table.va, remote_cdf_table, vsi->cdf_table_size);
+ }
return 0;
}
@@ -805,25 +814,26 @@ static int vdec_av1_slice_init_iq_table(struct vdec_av1_slice_instance *instance
ctx = instance->ctx;
vsi = instance->vpu.vsi;
- remote_iq_table = mtk_vcodec_fw_map_dm_addr(ctx->dev->fw_handler,
- (u32)vsi->iq_table_addr);
- if (IS_ERR(remote_iq_table)) {
- mtk_vdec_err(ctx, "failed to map iq table\n");
- return PTR_ERR(remote_iq_table);
- }
-
- mtk_vdec_debug(ctx, "map iq table to 0x%p\n", remote_iq_table);
if (instance->iq_table.va)
mtk_vcodec_mem_free(ctx, &instance->iq_table);
+ vsi->iq_table_size = AV1_IQ_TABLE_SIZE;
instance->iq_table.size = vsi->iq_table_size;
ret = mtk_vcodec_mem_alloc(ctx, &instance->iq_table);
if (ret)
return ret;
- memcpy(instance->iq_table.va, remote_iq_table, vsi->iq_table_size);
+ if (!instance->ctx->is_secure_playback) {
+ remote_iq_table = mtk_vcodec_fw_map_dm_addr(ctx->dev->fw_handler,
+ (u32)vsi->iq_table_addr);
+ if (IS_ERR(remote_iq_table)) {
+ mtk_vdec_err(ctx, "failed to map iq table\n");
+ return PTR_ERR(remote_iq_table);
+ }
+ memcpy(instance->iq_table.va, remote_iq_table, vsi->iq_table_size);
+ }
return 0;
}
@@ -1388,7 +1398,7 @@ static int vdec_av1_slice_setup_tile_group(struct vdec_av1_slice_instance *insta
struct vdec_av1_slice_vsi *vsi)
{
struct v4l2_ctrl_av1_tile_group_entry *ctrl_tge;
- struct vdec_av1_slice_tile_group *tile_group = &instance->tile_group;
+ struct vdec_av1_slice_tile_group *tile_group = &vsi->tile_group;
struct vdec_av1_slice_uncompressed_header *uh = &vsi->frame.uh;
struct vdec_av1_slice_tile *tile = &uh->tile;
struct v4l2_ctrl *ctrl;
@@ -1629,7 +1639,9 @@ static void vdec_av1_slice_setup_lat_buffer(struct vdec_av1_slice_instance *inst
vsi->tile.buf = instance->tile.dma_addr;
vsi->tile.size = instance->tile.size;
- memcpy(lat_buf->tile_addr.va, instance->tile.va, 64 * instance->tile_group.num_tiles);
+ if (!instance->ctx->is_secure_playback)
+ memcpy(lat_buf->tile_addr.va, instance->tile.va,
+ 64 * vsi->tile_group.num_tiles);
vsi->cdf_table.buf = instance->cdf_table.dma_addr;
vsi->cdf_table.size = instance->cdf_table.size;
@@ -1646,7 +1658,7 @@ static void vdec_av1_slice_setup_seg_buffer(struct vdec_av1_slice_instance *inst
/* reset segment buffer */
if (uh->primary_ref_frame == AV1_PRIMARY_REF_NONE || !uh->seg.segmentation_enabled) {
mtk_vdec_debug(instance->ctx, "reset seg %d\n", vsi->slot_id);
- if (vsi->slot_id != AV1_INVALID_IDX) {
+ if (!instance->ctx->is_secure_playback && vsi->slot_id != AV1_INVALID_IDX) {
buf = &instance->seg[vsi->slot_id];
memset(buf->va, 0, buf->size);
}
@@ -1657,7 +1669,7 @@ static void vdec_av1_slice_setup_tile_buffer(struct vdec_av1_slice_instance *ins
struct vdec_av1_slice_vsi *vsi,
struct mtk_vcodec_mem *bs)
{
- struct vdec_av1_slice_tile_group *tile_group = &instance->tile_group;
+ struct vdec_av1_slice_tile_group *tile_group = &vsi->tile_group;
struct vdec_av1_slice_uncompressed_header *uh = &vsi->frame.uh;
struct vdec_av1_slice_tile *tile = &uh->tile;
u32 tile_num, tile_row, tile_col;
@@ -1740,7 +1752,9 @@ static int vdec_av1_slice_setup_lat(struct vdec_av1_slice_instance *instance,
return ret;
vdec_av1_slice_setup_seg_buffer(instance, vsi);
- vdec_av1_slice_setup_tile_buffer(instance, vsi, bs);
+ if (!instance->ctx->is_secure_playback)
+ vdec_av1_slice_setup_tile_buffer(instance, vsi, bs);
+
vdec_av1_slice_setup_lat_buffer(instance, vsi, bs, lat_buf);
return 0;
@@ -1803,10 +1817,15 @@ static int vdec_av1_slice_setup_core_buffer(struct vdec_av1_slice_instance *inst
/* frame buffer */
vsi->fb.y.dma_addr = fb->base_y.dma_addr;
- if (plane == 1)
- vsi->fb.c.dma_addr = fb->base_y.dma_addr + size;
- else
- vsi->fb.c.dma_addr = fb->base_c.dma_addr;
+
+ if (!instance->ctx->is_secure_playback) {
+ if (plane == 1)
+ vsi->fb.c.dma_addr = fb->base_y.dma_addr + size;
+ else
+ vsi->fb.c.dma_addr = fb->base_c.dma_addr;
+ }
+ vsi->fb.y.size = instance->ctx->picinfo.fb_sz[0];
+ vsi->fb.c.size = instance->ctx->picinfo.fb_sz[1];
/* reference buffers */
vq = v4l2_m2m_get_vq(instance->ctx->m2m_ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE);
@@ -1829,6 +1848,7 @@ static int vdec_av1_slice_setup_core_buffer(struct vdec_av1_slice_instance *inst
}
vref->y.dma_addr = vb2_dma_contig_plane_dma_addr(vb, 0);
+ vref->y.size = size;
if (plane == 1)
vref->c.dma_addr = vref->y.dma_addr + size;
else
@@ -1905,7 +1925,13 @@ static int vdec_av1_slice_init(struct mtk_vcodec_dec_ctx *ctx)
goto error_vsi;
}
instance->init_vsi = vsi;
- instance->core_vsi = mtk_vcodec_fw_map_dm_addr(ctx->dev->fw_handler, (u32)vsi->core_vsi);
+ if (ctx->is_secure_playback)
+ instance->core_vsi =
+ mtk_vcodec_dec_get_shm_buffer_va(ctx->dev->optee_private, MTK_VDEC_CORE,
+ OPTEE_DATA_INDEX);
+ else
+ instance->core_vsi = mtk_vcodec_fw_map_dm_addr(ctx->dev->fw_handler,
+ (u32)vsi->core_vsi);
if (!instance->core_vsi) {
mtk_vdec_err(ctx, "failed to get AV1 core vsi\n");
@@ -1917,11 +1943,12 @@ static int vdec_av1_slice_init(struct mtk_vcodec_dec_ctx *ctx)
mtk_vdec_err(ctx, "remote vsi size 0x%x mismatch! expected: 0x%zx\n",
vsi->vsi_size, sizeof(struct vdec_av1_slice_vsi));
- instance->irq_enabled = 1;
+ instance->irq_enabled = !ctx->is_secure_playback;
instance->inneracing_mode = IS_VDEC_INNER_RACING(instance->ctx->dev->dec_capability);
- mtk_vdec_debug(ctx, "vsi 0x%p core_vsi 0x%llx 0x%p, inneracing_mode %d\n",
- vsi, vsi->core_vsi, instance->core_vsi, instance->inneracing_mode);
+ mtk_vdec_debug(ctx, "secure %d:vsi 0x%p core_vsi 0x%llx 0x%p, inneracing_mode %d\n",
+ ctx->is_secure_playback, vsi, vsi->core_vsi, instance->core_vsi,
+ instance->inneracing_mode);
ret = vdec_av1_slice_init_cdf_table(instance);
if (ret)
@@ -2114,7 +2141,9 @@ static int vdec_av1_slice_lat_decode(void *h_vdec, struct mtk_vcodec_mem *bs,
vdec_msg_queue_qbuf(&ctx->msg_queue.lat_ctx, lat_buf);
return -EBUSY;
}
- vsi->trans.dma_addr_end += ctx->msg_queue.wdma_addr.dma_addr;
+ if (!instance->ctx->is_secure_playback)
+ vsi->trans.dma_addr_end += ctx->msg_queue.wdma_addr.dma_addr;
+
mtk_vdec_debug(ctx, "lat dma 1 0x%pad 0x%pad\n",
&pfc->vsi.trans.dma_addr, &pfc->vsi.trans.dma_addr_end);
--
2.25.1
next prev parent reply other threads:[~2024-05-16 12:23 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 12:20 [PATCH v6,00/24] media: mediatek: add driver to support secure video decoder Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,01/24] v4l2: add restricted memory flags Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,02/24] v4l2: handle restricted memory flags in queue setup Yunfei Dong
2024-05-22 12:20 ` Andrzej Pietrasiewicz
2024-06-17 7:11 ` Yunfei Dong (董云飞)
2024-05-16 12:20 ` [PATCH v6,03/24] v4l2: verify restricted dmabufs are used in restricted queue Yunfei Dong
2024-06-12 4:31 ` Tomasz Figa
2024-05-16 12:20 ` [PATCH v6,04/24] v4l: add documentation for restricted memory flag Yunfei Dong
2024-05-22 11:16 ` Laurent Pinchart
2024-06-12 4:37 ` Tomasz Figa
2024-06-12 19:43 ` Nicolas Dufresne
2024-06-12 20:25 ` Laurent Pinchart
2024-06-12 20:58 ` Nicolas Dufresne
2024-06-17 19:02 ` Nicolas Dufresne
2024-05-22 12:24 ` Andrzej Pietrasiewicz
2024-05-16 12:20 ` [PATCH v6,05/24] dma-buf: heaps: Deduplicate docs and adopt common format Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,06/24] dma-heap: Add proper kref handling on dma-buf heaps Yunfei Dong
2024-06-18 7:22 ` [PATCH v6 06/24] " Markus Elfring
2024-05-16 12:20 ` [PATCH v6,07/24] dma-heap: Provide accessors so that in-kernel drivers can allocate dmabufs from specific heaps Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,08/24] media: mediatek: vcodec: add tee client interface to communiate with optee-os Yunfei Dong
2024-05-22 12:21 ` Andrzej Pietrasiewicz
2024-06-17 7:25 ` Yunfei Dong (董云飞)
2024-05-27 8:19 ` Chen-Yu Tsai
2024-05-16 12:20 ` [PATCH v6,09/24] media: mediatek: vcodec: allocate tee share memory Yunfei Dong
2024-05-22 12:23 ` Andrzej Pietrasiewicz
2024-05-16 12:20 ` [PATCH v6,10/24] media: mediatek: vcodec: send share memory data to optee Yunfei Dong
2024-05-22 12:22 ` Andrzej Pietrasiewicz
2024-06-17 7:45 ` Yunfei Dong (董云飞)
2024-05-16 12:20 ` [PATCH v6,11/24] media: mediatek: vcodec: initialize msg and vsi information Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory Yunfei Dong
2024-05-22 12:25 ` Andrzej Pietrasiewicz
2024-06-17 7:53 ` Yunfei Dong (董云飞)
2024-06-12 5:22 ` Tomasz Figa
2024-06-17 6:53 ` Yong Wu (吴勇)
2024-06-18 6:16 ` Tomasz Figa
2024-05-16 12:20 ` [PATCH v6,13/24] media: mediatek: vcodec: using shared memory as vsi address Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,14/24] media: mediatek: vcodec: Add capture format to support one plane memory Yunfei Dong
2024-05-22 12:26 ` Andrzej Pietrasiewicz
2024-05-23 10:14 ` Andrzej Pietrasiewicz
2024-05-23 10:36 ` Chen-Yu Tsai
2024-05-31 13:06 ` Nicolas Dufresne
2024-06-17 9:44 ` Yunfei Dong (董云飞)
2024-05-27 7:07 ` Chen-Yu Tsai
2024-05-16 12:20 ` [PATCH v6,15/24] media: mediatek: vcodec: Add one plane format Yunfei Dong
2024-05-31 13:08 ` Nicolas Dufresne
2024-05-16 12:20 ` [PATCH v6,16/24] media: mediatek: vcodec: support one plane capture buffer Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,17/24] media: mediatek: vcodec: re-construct h264 driver to support svp mode Yunfei Dong
2024-05-27 5:58 ` Chen-Yu Tsai
2024-05-28 7:37 ` Chen-Yu Tsai
2024-05-16 12:20 ` [PATCH v6,18/24] media: mediatek: vcodec: remove parse nal_info in kernel Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,19/24] media: mediatek: vcodec: disable wait interrupt for svp mode Yunfei Dong
2024-05-17 9:53 ` [PATCH v6, 19/24] " CK Hu (胡俊光)
2024-06-17 6:00 ` Yunfei Dong (董云飞)
2024-05-16 12:20 ` [PATCH v6,20/24] media: mediatek: vcodec: support tee decoder Yunfei Dong
2024-05-16 12:20 ` [PATCH v6,21/24] media: mediatek: vcodec: move vdec init interface to setup callback Yunfei Dong
2024-05-16 12:21 ` [PATCH v6,22/24] media: mediatek: vcodec: support hevc svp for mt8188 Yunfei Dong
2024-05-16 12:21 ` Yunfei Dong [this message]
2024-05-23 13:32 ` [PATCH v6,23/24] media: mediatek: vcodec: support av1 svp decoder " Andrzej Pietrasiewicz
2024-05-16 12:21 ` [PATCH v6,24/24] media: mediatek: vcodec: support vp9 " Yunfei Dong
2024-05-27 7:54 ` [PATCH v6, 24/24] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240516122102.16379-24-yunfei.dong@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Brian.Starkey@arm.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jkardatzke@google.com \
--cc=jstultz@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nfraprado@collabora.com \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=sebastian.fricke@collabora.com \
--cc=stevecho@chromium.org \
--cc=sumit.semwal@linaro.org \
--cc=tfiga@chromium.org \
--cc=tjmercier@google.com \
--cc=wenst@chromium.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox