From: "Krzysztof Wilczyński" <kw@linux.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: linux-pci@vger.kernel.org, bhelgaas@google.com,
lpieralisi@kernel.org, robh@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH] PCI: mt7621: Fix possible string truncation in snprintf
Date: Fri, 17 May 2024 20:29:29 +0900 [thread overview]
Message-ID: <20240517112929.GZ202520@rocinante> (raw)
In-Reply-To: <20240111082704.2259450-1-sergio.paracuellos@gmail.com>
Hello,
> The following warning appears when driver is compiled with W=1.
>
> CC drivers/pci/controller/pcie-mt7621.o
> drivers/pci/controller/pcie-mt7621.c: In function ‘mt7621_pcie_probe’:
> drivers/pci/controller/pcie-mt7621.c:228:49: error: ‘snprintf’ output may
> be truncated before the last format character [-Werror=format-truncation=]
> 228 | snprintf(name, sizeof(name), "pcie-phy%d", slot);
> | ^
> drivers/pci/controller/pcie-mt7621.c:228:9: note: ‘snprintf’ output between
> 10 and 11 bytes into a destination of size 10
> 228 | snprintf(name, sizeof(name), "pcie-phy%d", slot);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Clean this up increasing destination buffer one byte.
Applied to controller/mt7621, thank you!
[1/1] PCI: mt7621: Fix string truncation in mt7621_pcie_parse_port()
https://git.kernel.org/pci/pci/c/fd6eb49a84a8
Krzysztof
prev parent reply other threads:[~2024-05-17 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 8:27 [PATCH] PCI: mt7621: Fix possible string truncation in snprintf Sergio Paracuellos
2024-02-23 11:24 ` Sergio Paracuellos
2024-04-11 9:12 ` Sergio Paracuellos
2024-04-12 21:33 ` Bjorn Helgaas
2024-04-13 10:10 ` Sergio Paracuellos
2024-05-17 11:29 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517112929.GZ202520@rocinante \
--to=kw@linux.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox