Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Sung <shawn.sung@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Daniel Vetter <daniel@ffwll.ch>, Sean Paul <sean@poorly.run>,
	Jason Chen <jason-ch.chen@mediatek.corp-partner.google.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	CK Hu <ck.hu@mediatek.com>,
	"Nancy . Lin" <nancy.lin@mediatek.com>,
	linux-mediatek@lists.infradead.org,
	Bibby Hsieh <bibby.hsieh@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Hsiao Chien Sung <shawn.sung@mediatek.com>,
	David Airlie <airlied@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v9 05/21] drm/mediatek: Set DRM mode configs accordingly
Date: Fri, 14 Jun 2024 10:46:04 +0800	[thread overview]
Message-ID: <20240614024620.19011-6-shawn.sung@mediatek.com> (raw)
In-Reply-To: <20240614024620.19011-1-shawn.sung@mediatek.com>

From: Hsiao Chien Sung <shawn.sung@mediatek.com>

Set DRM mode configs limitation according to the hardware capabilities
and pass the IGT checks as below:

- The test "graphics.IgtKms.kms_plane" requires a frame buffer with
  width of 4512 pixels (> 4096).
- The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor size is
  defined, and run the test with cursor size from 1x1 to 512x512.

Please notice that the test conditions may change as IGT is updated.

Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 22 ++++++++++++++++++++++
 drivers/gpu/drm/mediatek/mtk_drm_drv.h |  4 ++++
 2 files changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 34d1a3aacde5..3737180e1e53 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -298,6 +298,9 @@ static const struct mtk_mmsys_driver_data mt8188_vdosys0_driver_data = {
 	.conn_routes = mt8188_mtk_ddp_main_routes,
 	.num_conn_routes = ARRAY_SIZE(mt8188_mtk_ddp_main_routes),
 	.mmsys_dev_num = 2,
+	.max_width = 8191,
+	.min_width = 1,
+	.min_height = 1,
 };
 
 static const struct mtk_mmsys_driver_data mt8192_mmsys_driver_data = {
@@ -312,6 +315,9 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = {
 	.main_path = mt8195_mtk_ddp_main,
 	.main_len = ARRAY_SIZE(mt8195_mtk_ddp_main),
 	.mmsys_dev_num = 2,
+	.max_width = 8191,
+	.min_width = 1,
+	.min_height = 1,
 };
 
 static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
@@ -319,6 +325,9 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
 	.ext_len = ARRAY_SIZE(mt8195_mtk_ddp_ext),
 	.mmsys_id = 1,
 	.mmsys_dev_num = 2,
+	.max_width = 8191,
+	.min_width = 2, /* 2-pixel align when ethdr is bypassed */
+	.min_height = 1,
 };
 
 static const struct of_device_id mtk_drm_of_ids[] = {
@@ -497,6 +506,15 @@ static int mtk_drm_kms_init(struct drm_device *drm)
 		for (j = 0; j < private->data->mmsys_dev_num; j++) {
 			priv_n = private->all_drm_private[j];
 
+			if (priv_n->data->max_width)
+				drm->mode_config.max_width = priv_n->data->max_width;
+
+			if (priv_n->data->min_width)
+				drm->mode_config.min_width = priv_n->data->min_width;
+
+			if (priv_n->data->min_height)
+				drm->mode_config.min_height = priv_n->data->min_height;
+
 			if (i == CRTC_MAIN && priv_n->data->main_len) {
 				ret = mtk_crtc_create(drm, priv_n->data->main_path,
 						      priv_n->data->main_len, j,
@@ -524,6 +542,10 @@ static int mtk_drm_kms_init(struct drm_device *drm)
 		}
 	}
 
+	/* IGT will check if the cursor size is configured */
+	drm->mode_config.cursor_width = drm->mode_config.max_width;
+	drm->mode_config.cursor_height = drm->mode_config.max_height;
+
 	/* Use OVL device for all DMA memory allocations */
 	crtc = drm_crtc_from_index(drm, 0);
 	if (crtc)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.h b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
index 78d698ede1bf..ce897984de51 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.h
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.h
@@ -46,6 +46,10 @@ struct mtk_mmsys_driver_data {
 	bool shadow_register;
 	unsigned int mmsys_id;
 	unsigned int mmsys_dev_num;
+
+	u16 max_width;
+	u16 min_width;
+	u16 min_height;
 };
 
 struct mtk_drm_private {
-- 
2.18.0



  parent reply	other threads:[~2024-06-14  2:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14  2:45 [PATCH v9 00/21] Support IGT in display driver Shawn Sung
2024-06-14  2:46 ` [PATCH v9 01/21] soc: mediatek: Disable 9-bit alpha in ETHDR Shawn Sung
2024-06-14  2:46 ` [PATCH v9 02/21] drm/mediatek: Add OVL compatible name for MT8195 Shawn Sung
2024-06-14  2:46 ` [PATCH v9 03/21] drm/mediatek: Add missing plane settings when async update Shawn Sung
2024-06-14  2:46 ` [PATCH v9 04/21] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property Shawn Sung
2024-06-14  2:46 ` Shawn Sung [this message]
2024-06-14  2:46 ` [PATCH v9 06/21] drm/mediatek: Turn off the layers with zero width or height Shawn Sung
2024-06-14  2:46 ` [PATCH v9 07/21] drm/mediatek: Support more 10bit formats in OVL Shawn Sung
2024-06-14  2:46 ` [PATCH v9 08/21] drm/mediatek: Support RGBA8888 and RGBX8888 in OVL on MT8195 Shawn Sung
2024-06-14  2:46 ` [PATCH v9 09/21] drm/mediatek: Fix XRGB setting error in OVL Shawn Sung
2024-06-14  6:06   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 10/21] drm/mediatek: Fix XRGB setting error in Mixer Shawn Sung
2024-06-14  3:58   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 11/21] drm/mediatek: Add new color format MACROs in OVL Shawn Sung
2024-06-14  4:04   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 12/21] drm/mediatek: Support DRM plane alpha " Shawn Sung
2024-06-14  5:06   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 13/21] drm/mediatek: Support DRM plane alpha in Mixer Shawn Sung
2024-06-14  5:08   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 14/21] drm/mediatek: Support "None" blending in OVL Shawn Sung
2024-06-14  5:11   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 15/21] drm/mediatek: Support "None" blending in Mixer Shawn Sung
2024-06-14  5:13   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL Shawn Sung
2024-06-14  5:42   ` CK Hu (胡俊光)
2024-06-18 17:00     ` Jason-JH Lin (林睿祥)
2024-06-19  3:17       ` CK Hu (胡俊光)
2024-06-19 16:00         ` Jason-JH Lin (林睿祥)
2024-06-14  5:49   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 17/21] drm/mediatek: Support "Pre-multiplied" blending in Mixer Shawn Sung
2024-06-14  5:55   ` CK Hu (胡俊光)
2024-06-14  2:46 ` [PATCH v9 18/21] drm/mediatek: Support alpha blending in display driver Shawn Sung
2024-06-14  2:46 ` [PATCH v9 19/21] drm/mediatek: Support CRC " Shawn Sung
2024-06-14  2:46 ` [PATCH v9 20/21] drm/mediatek: Support CRC in OVL Shawn Sung
2024-06-14  2:46 ` [PATCH v9 21/21] drm/mediatek: Support CRC in OVL adaptor Shawn Sung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240614024620.19011-6-shawn.sung@mediatek.com \
    --to=shawn.sung@mediatek.com \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bibby.hsieh@mediatek.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-ch.chen@mediatek.corp-partner.google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nancy.lin@mediatek.com \
    --cc=p.zabel@pengutronix.de \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox