From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17AD4C27C79 for ; Mon, 17 Jun 2024 19:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S2axVuNtop/5vcxFV5zj/Dpr/EXs5QNuRQC9Ep7tCsQ=; b=x576Ivks4UtJpJkwC0SiSLIDa3 HfakeCVdeLqBAp1uL7y0AVJBcqrDz1G47nWmoJN96kYvD+ZqRm1e1qAuMDIm1WPXMzwHuEeyU3o4t DXwj9EHRBjdUF0h2FqhdfK+NIgB9JMCzQyBU/oVOJZBnxi3/Nnm+auN7s/2rYesujswiI2i2ndtEn PxewbOZjinC4YDy0/wCYLjM2OzX6pvqvzvnIStouAt4e+r8VujoJVETswvG6HjR6GUUcjygyMYzQL LN/EIisqV43fUkrMS9tywgS9BQy39xQXhU4vZgpYj6I+bfTPDVdlsP2ZXLrrTNJ7cGI6BZDDSKCEr IlxY57Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJI6c-0000000CMJo-49mX; Mon, 17 Jun 2024 19:33:30 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJI6Z-0000000CMJ3-1wa9; Mon, 17 Jun 2024 19:33:29 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EB72D6145E; Mon, 17 Jun 2024 19:33:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58DB2C2BD10; Mon, 17 Jun 2024 19:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718652805; bh=3XAO2VM0TXU6x8XweVvJD4YnI+f4rCAeGuLNKtf5XE0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r+IuhJ1uBSHjfadYASAvVJHfyMRxZTTpm+snaD2bLSHMAi6vmpcthDw/cDHndzhVU THVJsbfhoghlvFkOcqesR+EsZRZwd55HNJU4A+HR9P1cfAxkrocwVBxJqdPK5ugo+E i89KSDV57oDvnv6z+rvIhHPNSC+uCs92sKaAW2wFAnnyLsKTM0UciMIasQkrhKLnrW rsixpHiljYTjYOqJTHf3NGITJQF7maTBqiH0pRaYOTRJ7g7PgDceuAY1feWocVVHpY VZKRiGsfV9Ai40Zy3F1UbX7zLjsNkcdPcek4+hSp+m2dBP1UPN71qtjV/8I+Tvo7g6 y1z1f8pgITJ3Q== Date: Mon, 17 Jun 2024 20:33:14 +0100 From: Jonathan Cameron To: AngeloGioacchino Del Regno Cc: Rob Herring , lars@metafoo.de, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lee@kernel.org, andy@kernel.org, nuno.sa@analog.com, bigunclemax@gmail.com, dlechner@baylibre.com, marius.cristea@microchip.com, marcelo.schmitt@analog.com, fr0st61te@gmail.com, mitrutzceclan@gmail.com, mike.looijmans@topic.nl, marcus.folkesson@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, andy.shevchenko@gmail.com, kernel@collabora.com Subject: Re: [PATCH v2 1/5] dt-bindings: iio: adc: Add MediaTek MT6359 PMIC AUXADC Message-ID: <20240617203314.641e84a9@jic23-huawei> In-Reply-To: References: <20240604123008.327424-1-angelogioacchino.delregno@collabora.com> <20240604123008.327424-2-angelogioacchino.delregno@collabora.com> <20240605235239.GA3455504-robh@kernel.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_123327_630773_5416F5B2 X-CRM114-Status: GOOD ( 24.59 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 10 Jun 2024 10:00:55 +0200 AngeloGioacchino Del Regno wrote: > Il 06/06/24 01:52, Rob Herring ha scritto: > > On Tue, Jun 04, 2024 at 02:30:04PM +0200, AngeloGioacchino Del Regno wrote: > >> Add a new binding for the MT6350 Series (MT6357/8/9) PMIC AUXADC, > >> providing various ADC channels for both internal temperatures and > >> voltages, audio accessory detection (hp/mic/hp+mic and buttons, > >> usually on a 3.5mm jack) other than some basic battery statistics > >> on boards where the battery is managed by this PMIC. > >> > >> Also add the necessary dt-binding headers for devicetree consumers. > >> > >> Signed-off-by: AngeloGioacchino Del Regno > >> --- > >> .../iio/adc/mediatek,mt6359-auxadc.yaml | 33 +++++++++++++++++++ > >> .../iio/adc/mediatek,mt6357-auxadc.h | 21 ++++++++++++ > >> .../iio/adc/mediatek,mt6358-auxadc.h | 22 +++++++++++++ > >> .../iio/adc/mediatek,mt6359-auxadc.h | 22 +++++++++++++ > >> 4 files changed, 98 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml > >> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6357-auxadc.h > >> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6358-auxadc.h > >> create mode 100644 include/dt-bindings/iio/adc/mediatek,mt6359-auxadc.h > >> > >> diff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml > >> new file mode 100644 > >> index 000000000000..6497c416094d > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6359-auxadc.yaml > >> @@ -0,0 +1,33 @@ > >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6359-auxadc.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: MediaTek MT6350 series PMIC AUXADC > >> + > >> +maintainers: > >> + - AngeloGioacchino Del Regno > >> + > >> +description: > >> + The Auxiliary Analog/Digital Converter (AUXADC) is an ADC found > >> + in some MediaTek PMICs, performing various PMIC related measurements > >> + such as battery and PMIC internal voltage regulators temperatures, > >> + accessory detection resistance (usually, for a 3.5mm audio jack) > >> + other than voltages for various PMIC internal components. > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - mediatek,mt6357-auxadc > >> + - mediatek,mt6358-auxadc > >> + - mediatek,mt6359-auxadc > >> + > >> + "#io-channel-cells": > >> + const: 1 > > > > Why do you need a node here? Just add #io-channel-cells to the parent > > node. > > > > Because some boards will want to avoid probing the related driver, as that will > trigger a reset and this may not play well with ECs (namely, some Chromebooks), > which are reading the same AUXADC block. > > If I avoid using a new node, instead of just using `status`, I'll have to add a > "mediatek,disable-auxadc" property to the parent node, which isn't pretty... Rob, does this answer the question to your satisfaction? If you are fine with this I'd like to queue it up (with the typo in one of the patch descriptions that Andy caught fixed up). Thanks, Jonathan > > Cheers, > Angelo > > >> + > >> +required: > >> + - compatible > >> + - "#io-channel-cells" > >> + > >> +additionalProperties: false > >