From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65FE0E7718D for ; Mon, 23 Dec 2024 20:45:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A8k/Sr0lxLnyNfqzcacuC22SJll+VDfG28GdxyGW5dQ=; b=m6FkyAjRKh2+3kpMLDSyOOjJVb CIyR0eKl1HeMdCMIR6+ep8GDuU7XxSoppvzdAxxio9FZG2FLBe+0wcIJpU80BkxWMHBuMwPOFoD2n spWpywvS7/H6FTwYZmirrZ9WVwJXfpI4Th+c34RlY+Ksv0QssgZRJ7CR5MbAmyZvdkNST7M8R+Lca cMpqW0BoOV/2twlwITCQSEbzTXpsxBkmmscHa0skQLUtb0jCcm1GmAj5B+K/GZR6o2LjnYT2Ugbw5 k1xLgN9b74FCHObZHasK1CLHF8FZZuYUZa0B/TJZA3ZnlaePv1zunmnTaU/Fb9HgOb3oC6FWBrr0t l4aR6Etg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tPpIr-0000000Aiev-2SXn; Mon, 23 Dec 2024 20:45:25 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tPpIp-0000000Aidi-08Vp for linux-mediatek@lists.infradead.org; Mon, 23 Dec 2024 20:45:24 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YH94v6dSXz6K6mq; Tue, 24 Dec 2024 04:45:03 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 6AC22140517; Tue, 24 Dec 2024 04:45:21 +0800 (CST) Received: from localhost (10.47.75.118) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 23 Dec 2024 21:45:20 +0100 Date: Mon, 23 Dec 2024 20:45:18 +0000 From: Jonathan Cameron To: Zijun Hu CC: Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , James Bottomley , Thomas =?ISO-8859-1?Q?Wei=DFschu?= =?ISO-8859-1?Q?h?= , , , , , , , , , , , , , , , , , , , , , Zijun Hu Subject: Re: [PATCH v4 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode() Message-ID: <20241223204518.000003ad@huawei.com> In-Reply-To: <20241211-const_dfc_done-v4-8-583cc60329df@quicinc.com> References: <20241211-const_dfc_done-v4-0-583cc60329df@quicinc.com> <20241211-const_dfc_done-v4-8-583cc60329df@quicinc.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.75.118] X-ClientProxiedBy: lhrpeml500009.china.huawei.com (7.191.174.84) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241223_124523_235371_8997801C X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 11 Dec 2024 08:08:10 +0800 Zijun Hu wrote: > From: Zijun Hu > > gpio_sim_dev_match_fwnode() is a simple wrapper of API > device_match_fwnode(). > > Remove the needless wrapper and use the API instead. > > Signed-off-by: Zijun Hu Reviewed-by: Jonathan Cameron > --- > drivers/gpio/gpio-sim.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c > index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644 > --- a/drivers/gpio/gpio-sim.c > +++ b/drivers/gpio/gpio-sim.c > @@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip) > return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip); > } > > -static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data) > -{ > - return device_match_fwnode(dev, data); > -} > - > static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) > { > struct gpio_sim_chip *chip; > @@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) > if (ret) > return ret; > > - chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode); > + chip->dev = device_find_child(dev, swnode, device_match_fwnode); > if (!chip->dev) > return -ENODEV; > >