From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85241C02194 for ; Thu, 6 Feb 2025 16:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HsVx1KaNwgqNLZilcbZny92AtsUxM9BfF1vMwKADwMk=; b=0K6O7V1z4gFQhdLleE6mRo14vq xmU5otd2pucSYPnFiQ9jbvQ9Li2r3pHr9s/I3O6tljVtHkACl+LtYTWpaRTzWYaDsTPE6GqnzEXhh +SNi4asfDXmLb0o9dp8uNxofqfQOMNDyr1+gun6XYETXhWCkyJMaklwsIaELenenoPn9RLg9/Siv+ 0vEuB89rftOLlKXrt/xDfySERItXD4h5KHq+jq1HE4A29S6G4qoYKK3bjQpfMsENbP0KzEb+wrfmi aR8e0BtAnYktx2svgVEUPGEAaQk2QyhJFt/wVSFVEmPkkylWCUJEJOUboDnvu11/S6ULuzQ77KJBF 4OxqttPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tg4ai-00000006pXQ-1oQB; Thu, 06 Feb 2025 16:19:00 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tg4Vf-00000006oW3-2Nao; Thu, 06 Feb 2025 16:13:48 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 23F095C64A4; Thu, 6 Feb 2025 16:13:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F07F8C4CEDD; Thu, 6 Feb 2025 16:13:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738858425; bh=yugtap81E+1XEiUSlot9N/ao/3tXx/zIxbLqkf5yQ2s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dYCFPFSLLiDASvYd4s42uud1DtC2OYpyDgEeLT35r+DrvE2jij76XmTWQ9G67IkkY GXlKlZixxwv1mXchRyKAC2XLHInGz7nXltb/sepWggEKQB2TlbKf/zl7RmfFuI/bgH POQtLfiwx3vOBe+qHPtYDAHCNvMvnzxOt413CP2Ky6rkPlhy2ILdMwAJlRvRLqD0vj Zr7POyxFiXm5+iQmgkdVq1+ZtMEZUnmtN8vK+HRSG+ejF6wz2rbhMHSIENz/QYTel5 LTPtPbUTgV8Ae2h5Vlge1PtDZVU6vqHxlAMGJQmuO06gQkxOszYi8GtT6wvI2wkZns f+nG5+ZFP0G5A== Date: Thu, 6 Feb 2025 17:13:43 +0100 From: Maxime Ripard To: Anusha Srivatsa Cc: Joel Stanley , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrew Jeffery , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Marek Vasut , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Raphael Gallais-Pou , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Alexey Brodkin , Dave Stevenson , =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Jonathan Corbet , linux-aspeed@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH 11/12] drm/vc4: move to devm_platform_ioremap_resource() usage Message-ID: <20250206-hallowed-ultra-tiger-cfec8e@houat> References: <20250205-mem-cocci-newapi-v1-0-aebf2b0e2300@redhat.com> <20250205-mem-cocci-newapi-v1-11-aebf2b0e2300@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="nds2ddkwji5fimma" Content-Disposition: inline In-Reply-To: <20250205-mem-cocci-newapi-v1-11-aebf2b0e2300@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250206_081347_700895_CAE910CA X-CRM114-Status: GOOD ( 20.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --nds2ddkwji5fimma Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 11/12] drm/vc4: move to devm_platform_ioremap_resource() usage MIME-Version: 1.0 On Wed, Feb 05, 2025 at 03:08:07PM -0500, Anusha Srivatsa wrote: > Replace platform_get_resource_byname + devm_ioremap_resource > with just devm_platform_ioremap_resource() >=20 > Used Coccinelle to do this change. SmPl patch: > //rule s/(devm_)platform_get_resource_byname + > //(devm_)ioremap/devm_platform_ioremap_resource. > @rule_3@ > identifier res; > expression ioremap; > identifier pdev; > constant mem; > expression name; > @@ > -struct resource *res; > <+... > -res =3D platform_get_resource_byname(pdev,mem,name); > <... > -if (!res) { > -... > -} > ...> > -ioremap =3D devm_ioremap(...); > +ioremap =3D devm_platform_ioremap_resource_byname(pdev,name); > ...+> >=20 > v2: Change the SmPl patch to work on multiple occurences of > the pattern. This also fixes the compilation error. >=20 > Cc: Maxime Ripard > Cc: Dave Stevenson > Cc: Ma=EDra Canal > Signed-off-by: Anusha Srivatsa > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 55 +++++++++++-------------------------= ------ > 1 file changed, 14 insertions(+), 41 deletions(-) >=20 > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdm= i.c > index 47d9ada98430634cfd8c1e21c2a4d00d501bab7e..066f1246dab420ee889845b0c= 573d80ce7c88595 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -2951,71 +2951,44 @@ static int vc5_hdmi_init_resources(struct drm_dev= ice *drm, > { > struct platform_device *pdev =3D vc4_hdmi->pdev; > struct device *dev =3D &pdev->dev; > - struct resource *res; > int ret; > =20 > - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "hdmi"); > - if (!res) > - return -ENODEV; > - > - vc4_hdmi->hdmicore_regs =3D devm_ioremap(dev, res->start, > - resource_size(res)); > + vc4_hdmi->hdmicore_regs =3D devm_platform_ioremap_resource_byname(pdev, > + "hdmi"); > if (!vc4_hdmi->hdmicore_regs) > return -ENOMEM; > =20 > - res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "hd"); > - if (!res) > - return -ENODEV; > - > - vc4_hdmi->hd_regs =3D devm_ioremap(dev, res->start, resource_size(res)); > + vc4_hdmi->hd_regs =3D devm_platform_ioremap_resource_byname(pdev, "hd"); > if (!vc4_hdmi->hd_regs) > return -ENOMEM; I *think* that one is shared between both HDMI controllers on the RaspberryPi4, so we can't claim them from both instances. We should add a comment there to document that it's on purpose. The rest looks good. Maxime --nds2ddkwji5fimma Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ6TftgAKCRAnX84Zoj2+ drfXAYDBINKHBSckIuo/kq/HoUvq16io0SUMaLB/CVkeidnE3EXaDz9M3WhZ60Ha n8d4HmABf0i2bHqp4iPr3Cr3YiSEnV9zX0sFLdFl/FejJMglsT19c+7lwsGMwuaH 8nnPGZ1q6A== =1kXI -----END PGP SIGNATURE----- --nds2ddkwji5fimma--