Re: [PATCH v3 16/17] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver

kernel test robot
2025-05-16T07:39:11Z

Hi paul-pl.chen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.15-rc6 next-20250515]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/paul-pl-chen/dt-bindings-soc-mediatek-add-mutex-yaml-for-MT8196/20250515-173733
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20250515093454.1729720-17-paul-pl.chen%40mediatek.com
patch subject: [PATCH v3 16/17] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver
config: arm64-randconfig-001-20250516 (https://download.01.org/0day-ci/archive/20250516/202505161512.PmRwb8Li-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250516/202505161512.PmRwb8Li-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505161512.PmRwb8Li-lkp@intel.com/

All warnings (new ones prefixed by >>):

drivers/gpu/drm/mediatek/mtk_ddp_comp.c: In function 'mtk_find_possible_crtcs':
>> drivers/gpu/drm/mediatek/mtk_ddp_comp.c:670:3: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
670 | if (found)
| ^~
drivers/gpu/drm/mediatek/mtk_ddp_comp.c:673:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
673 | count++;
| ^~~~~

vim +/if +670 drivers/gpu/drm/mediatek/mtk_ddp_comp.c

622
623 int mtk_find_possible_crtcs(struct drm_device *drm, struct device *dev)
624 {
625 struct mtk_drm_private *private = drm->dev_private;
626 const struct mtk_mmsys_driver_data *data;
627 struct mtk_drm_private *priv_n;
628 int i, j, count = 0, ret;
629
630 /* search each path in private data */
631 for (i = 0; i < MAX_CRTC; i++) {
632 bool found = false;
633 int avail_mmsys_num = 0;
634
635 for (j = 0; j < private->data->mmsys_dev_num; j++) {
636 const unsigned int *path = NULL;
637 unsigned int path_len = 0;
638
639 priv_n = private->all_drm_private[j];
640 data = priv_n->data;
641
642 if (i == CRTC_MAIN) {
643 path = data->main_path;
644 path_len = data->main_len;
645 } else if (i == CRTC_EXT) {
646 path = data->ext_path;
647 path_len = data->ext_len;
648 } else if (i == CRTC_THIRD) {
649 path = data->third_path;
650 path_len = data->third_len;
651 }
652
653 /* skip if no path data in current mmsys */
654 if (path_len == 0 || !path) {
655 avail_mmsys_num++;
656 continue;
657 }
658
659 if (mtk_ddp_path_available(path, path_len, priv_n->comp_node))
660 avail_mmsys_num++;
661
662 if (mtk_ddp_comp_find(dev, path, path_len, priv_n->ddp_comp))
663 found = true;
664 }
665
666 /* skip invalid path */
667 if (avail_mmsys_num != private->data->mmsys_dev_num)
668 continue;
669
> 670 if (found)
671 return BIT(count);
672
673 count++;
674 }
675
676 ret = mtk_ddp_comp_find_in_route(dev,
677 private->data->conn_routes,
678 private->data->num_conn_routes,
679 private->ddp_comp);
680
681 if (ret < 0)
682 DRM_INFO("Failed to find comp in ddp table, ret = %d\n", ret);
683
684 return ret;
685 }
686

--
0-DAY CI Kernel Test Service